ltp-list — General Discussions

Re: [LTP] LTP-cpuset test cases

[Cyril H. <ch...@su...>]

Hi!
First of all the LTP list has been moved years ago to
https://lists.linux.it/listinfo/ltp

> I am running LTP to test cpuset test cases. I have created new command 
> file after copying 2 commands from runltp.
>
>  ?? cpuset_load_balance cpuset_load_balance_test.sh
>  ?? cpuset_base_ops cpuset_base_ops_testset.sh
> 
> with above sequence, crash is happening
> 
> [10546.587463] Workqueue: cgroup_destroy css_killed_work_fn
> [10546.592762] pstate: 80400009 (Nzcv daif +PAN -UAO)
> [10546.597550] pc : build_sched_domains+0x244/0xb48
> [10546.602154] lr : build_sched_domains+0x228/0xb48
> [10546.606757] sp : ffff000031fc3b70
> [10546.610059] x29: ffff000031fc3b70 x28: ffff00001157d730
> [10546.615357] x27: ffff0000115a7000 x26: ffff00001118d000
> [10546.620655] x25: 00000000000000e0 x24: 0000000000000000
> [10546.625953] x23: ffff00001118dc80 x22: ffff00001157d730
> [10546.631251] x21: ffff80bf54723940 x20: ffff80bded3aef00
> [10546.636549] x19: ffff00001157f1e4 x18: 0000000000000000
> [10546.641848] x17: 0000000000000000 x16: 0000000000000000
> .546
>  ?? kernel:Internal error: Oops: 96000007 [#1] SMP

Secondly this means that you have found a kernel bug. Which means that
the bug in the kernel has to be identified and fixed.

-- 
Cyril Hrubis
ch...@su...

[LTP] LTP-cpuset test cases

[Prabhakar K. <pra...@ou...>]

Hi All,

I am running LTP to test cpuset test cases. I have created new command 
file after copying 2 commands from runltp.

   cpuset_load_balance cpuset_load_balance_test.sh
   cpuset_base_ops cpuset_base_ops_testset.sh

with above sequence, crash is happening

[10546.587463] Workqueue: cgroup_destroy css_killed_work_fn
[10546.592762] pstate: 80400009 (Nzcv daif +PAN -UAO)
[10546.597550] pc : build_sched_domains+0x244/0xb48
[10546.602154] lr : build_sched_domains+0x228/0xb48
[10546.606757] sp : ffff000031fc3b70
[10546.610059] x29: ffff000031fc3b70 x28: ffff00001157d730
[10546.615357] x27: ffff0000115a7000 x26: ffff00001118d000
[10546.620655] x25: 00000000000000e0 x24: 0000000000000000
[10546.625953] x23: ffff00001118dc80 x22: ffff00001157d730
[10546.631251] x21: ffff80bf54723940 x20: ffff80bded3aef00
[10546.636549] x19: ffff00001157f1e4 x18: 0000000000000000
[10546.641848] x17: 0000000000000000 x16: 0000000000000000
.546
   kernel:Internal error: Oops: 96000007 [#1] SMP
[10546.661905] x13: 00000000ffffffff x12: ffffffff00000000
[10546.667203] x11: 0000000000000000 x10: 0000000000000000
[10546.672501] x9 : 0000000000000000 x8 : ffff80bded45c000
[10546.677799] x7 : 0000000000000000 x6 : 000000000000003f
[10546.683097] x5 : 0000000000000040 x4 : 0000000000000000
[10546.688395] x3 : 0000000000000000 x2 : 0000000000000000
[10546.693693] x1 : ffff00001118dc80 x0 : 00000000ffffffff
[10546.698991] Call trace:
[10546.701426]  build_sched_domains+0x244/0xb48
[10546.705684]  partition_sched_domains+0x1dc/0x2dc
[10546.710300]  rebuild_sched_domains_locked+0x64/0xa8
[10546.715166]  update_flag+0x174/0x190
[10546.718729]  cpuset_css_offline+0xb0/0xc8
[10546.722725]  css_killed_work_fn+0x54/0x118
[10546.726811]  process_one_work+0x1b4/0x3d8
[10546.730807]  worker_thread+0x4c/0x420
[10546.734463]  kthread+0x108/0x138
[10546.737685]  ret_from_fork+0x10/0x18
[10546.741249] Code: aa0003e1 12800000 f862dac2 aa0103f7 (f8616855)
[10546.747330] ---[ end trace c4f1497fb4a860c8 ]---


Strangely, If I run sequence [1] or [2] no crash is happening
[1]
cpuset_load_balance     cpuset_load_balance_test.sh
cpuset_load_balance     cpuset_load_balance_test.sh

[2]
cpuset_load_balance     cpuset_load_balance_test.sh
cpuset_sched_domains    cpuset_sched_domains_test.sh
cpuset_hotplug  cpuset_hotplug_test.sh

What I can infer that the cpuset_load_balance, cpuset_sched_domains, 
cpuset_hotplug are usig cpuset_set(). While cpuset_base_ops doesnt use 
cpuset_set().
Also, combination of cpuset_load_balance with any cpuset tests *not* 
using cpuset_set() causing above type of crash.

I have seen this crash on Linux 5.09 and 5.4.rc0 kernel.


Any clue will help me in moving forward.


https://github.com/linux-test-project/ltp.git
top commit:
commit ff3c9780438040ab955fdf4167ffae4e612a311d (HEAD -> master, 
origin/master, origin/HEAD)
Author: Petr Vorel <pv...@su...>
Date:   Wed Oct 2 12:51:04 2019 +0200

     lib: Replace GPL verbose text by SPDX license identifier

     from library sources for new API.

     Signed-off-by: Petr Vorel <pv...@su...>

--prabhakar

Re: [LTP] [PATCH] fs/ftest/ftest06.c: Fix too small name string and related failure

[Cyril H. <ch...@su...>]

Hi!
This mailing list has been replaced by lt...@li... long time ago,
please send patches to the new list instead.

-- 
Cyril Hrubis
ch...@su...

[LTP] [PATCH] fs/ftest/ftest06.c: Fix too small name string and related failure

[<zh...@wi...>]

From: He Zhe <zh...@wi...>

The name string is too small to contain normal full path names and causes
the following failure.

"ftest06     2  TFAIL  :  ftest06.c:223: Can't chdir(): errno=ENOENT(2): No such file or directory"

Signed-off-by: He Zhe <zh...@wi...>
---
 testcases/kernel/fs/ftest/ftest06.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/fs/ftest/ftest06.c b/testcases/kernel/fs/ftest/ftest06.c
index 2ca7c88..b434067 100644
--- a/testcases/kernel/fs/ftest/ftest06.c
+++ b/testcases/kernel/fs/ftest/ftest06.c
@@ -100,7 +100,7 @@ static char *fstyp;
 int main(int ac, char *av[])
 {
 	int pid, child, status, count, k, j;
-	char name[3];
+	char name[MAXPATHLEN];
 
 	int lc;
 
-- 
2.7.4

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

[Cyril H. <ch...@su...>]

Hi!
> > > BTW, Cyril, do you have a preference between github pull request
> > > and posting the patch to the list?
> > > I suppose I should have posted to fsdevel and CC Jan anyway...
> > 
> > I do prefer mailing list over pull requests but I work with both.
> 
> Cyril, should I rebase on top of that pull request or will you handle the
> conflict on your own?

I usually handle simple enough collisions myself, no need to rebase and
resend just because of that.

Also as we are in the middle of pre-release freeze please be patient as
the review will have to wait at least a week or two.

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

[Jan K. <ja...@su...>]

On Fri 04-05-18 16:06:22, Cyril Hrubis wrote:
> Hi!
> > inotify07 and inotify08 have already been merged to master
> > and FYI already "posted" inotify09:
> > https://github.com/linux-test-project/ltp/pull/260

Thanks for info!

> > BTW, Cyril, do you have a preference between github pull request
> > and posting the patch to the list?
> > I suppose I should have posted to fsdevel and CC Jan anyway...
> 
> I do prefer mailing list over pull requests but I work with both.

Cyril, should I rebase on top of that pull request or will you handle the
conflict on your own?

								Honza
-- 
Jan Kara <ja...@su...>
SUSE Labs, CR

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

[Cyril H. <ch...@su...>]

Hi!
> inotify07 and inotify08 have already been merged to master
> and FYI already "posted" inotify09:
> https://github.com/linux-test-project/ltp/pull/260
> 
> BTW, Cyril, do you have a preference between github pull request
> and posting the patch to the list?
> I suppose I should have posted to fsdevel and CC Jan anyway...

I do prefer mailing list over pull requests but I work with both.

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] [PATCH] inotify07: Add test for kernel crash during event notification

[Cyril H. <ch...@su...>]

Hi!
This is the old mailing list that has been abandoned a few years ago
when sourceforge had frequent outages, the new one is at lt...@li....

-- 
Cyril Hrubis
ch...@su...

[LTP] [PATCH] inotify07: Add test for kernel crash during event notification

[Jan K. <ja...@su...>]

When a removal of the last mark on inode / vfsmount races with a
notification about new event on that object, the kernel can crash. Test
for this failure. The problem was fixed by kernel commit d90a10e2444b
"fsnotify: Fix fsnotify_mark_connector race".

Signed-off-by: Jan Kara <ja...@su...>
---
 testcases/kernel/syscalls/inotify/inotify07.c | 104 ++++++++++++++++++++++++++
 1 file changed, 104 insertions(+)
 create mode 100644 testcases/kernel/syscalls/inotify/inotify07.c

diff --git a/testcases/kernel/syscalls/inotify/inotify07.c b/testcases/kernel/syscalls/inotify/inotify07.c
new file mode 100644
index 000000000000..d20a824f0e8d
--- /dev/null
+++ b/testcases/kernel/syscalls/inotify/inotify07.c
@@ -0,0 +1,104 @@
+/*
+ * Copyright (c) 2015 SUSE Linux.  All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it would be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ *
+ * Further, this software is distributed without any warranty that it is
+ * free of the rightful claim of any third person regarding infringement
+ * or the like.  Any license provided herein, whether implied or
+ * otherwise, applies only to this software file.  Patent licenses, if
+ * any, provided herein do not apply to combinations of this program with
+ * other software, or any other product whatsoever.
+ *
+ * Started by Jan Kara <ja...@su...>
+ *
+ * DESCRIPTION
+ * Test for inotify mark connector destruction race.
+ *
+ * Kernels prior to 4.17 have a race when the last fsnotify mark on the inode
+ * is being deleted while another process reports event happening on that
+ * inode. When the race is hit, the kernel crashes or loops.
+ *
+ * The problem has been fixed by commit:
+ * d90a10e2444b "fsnotify: Fix fsnotify_mark_connector race"
+ */
+
+#include "config.h"
+
+#include <stdio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <fcntl.h>
+#include <time.h>
+#include <signal.h>
+#include <sys/time.h>
+#include <sys/wait.h>
+#include <sys/syscall.h>
+
+#include "tst_test.h"
+#include "inotify.h"
+
+#if defined(HAVE_SYS_INOTIFY_H)
+#include <sys/inotify.h>
+
+/* Number of test loops to run the test for */
+#define TEARDOWNS 1000000
+
+static void verify_inotify(void)
+{
+	int inotify_fd, fd;
+	int wd;
+	pid_t pid;
+	int tests;
+	char *name = "stress_fname";
+
+	fd = SAFE_OPEN(name, O_CREAT | O_RDWR, 0600);
+	pid = SAFE_FORK();
+	if (pid == 0) {
+		char buf[64];
+
+		memset(buf, 'a', sizeof(buf));
+		while (1) {
+			SAFE_WRITE(0, fd, buf, sizeof(buf));
+			SAFE_LSEEK(fd, 0, SEEK_SET);
+		}
+		/* Never reached */
+	}
+	SAFE_CLOSE(fd);
+
+	inotify_fd = myinotify_init1(0);
+	if (inotify_fd < 0)
+		tst_brk(TBROK | TERRNO, "inotify_init failed");
+	for (tests = 0; tests < TEARDOWNS; tests++) {
+		wd = myinotify_add_watch(inotify_fd, name, IN_MODIFY);
+		if (wd < 0)
+			tst_brk(TBROK | TERRNO, "inotify_add_watch() failed.");
+		wd = myinotify_rm_watch(inotify_fd, wd);
+		if (wd < 0)
+			tst_brk(TBROK | TERRNO, "inotify_rm_watch() failed.");
+	}
+	SAFE_CLOSE(inotify_fd);
+	/* We survived for given time - test succeeded */
+	tst_res(TPASS, "kernel survived inotify beating");
+
+	/* Kill the child writing to file and wait for it */
+	SAFE_KILL(pid, SIGKILL);
+	SAFE_WAIT(NULL);
+}
+
+static struct tst_test test = {
+	.timeout = 600,
+	.needs_tmpdir = 1,
+	.forks_child = 1,
+	.test_all = verify_inotify,
+};
+
+#else
+	TST_TEST_TCONF("system doesn't have required inotify support");
+#endif
-- 
2.13.6

[LTP] Fwd: LTP Ipv6_lib failures

[ankit g. <ank...@gm...>]

Hi All,

I am executing the LTP(20160126) tests for one of my board, and in it
Ipv6_lib is failing. below is the tests results and logs.

Test Start Time: Thu Jun 22 18:22:27 2017
-----------------------------------------
Testcase                       Result     Exit Value
--------                       ------     ----------
in6_01                         PASS       0
in6_02                         FAIL       4
getaddrinfo_01                 FAIL       1
asapi_01                       FAIL       2
asapi_02                       FAIL       2
asapi_03                       FAIL       2

-----------------------------------------------
Total Tests: 6
Total Skipped Tests: 0
Total Failures: 5
Kernel Version: 4.1.29-4.1-1.0.x-imx-dms-ba16+g8eaed11
Machine Architecture: armv7l
Hostname: Development-board


In this* getaddrinfo_01* is passing after I make entry of my host name in
/etc/hosts file, but rest 4 tests are still failing. I did not find any
failure reason in LTP bugs list.

Please see the attachment for individual tests execution logs and let me
know if something else is required from my side?

Thanks & Regards,
Ankit Gupta

Re: [LTP] LTP for ARM64

[Senthil K <Sen...@ar...>]

OS – Linux.

Kernel Space is ARM 64 bit
Userspace is ARM 32 bit

I have compiled LTP using  ARM 32 bit tool chain.

From: $rik@nth [mailto:sri...@gm...]
Sent: Sunday, January 15, 2017 6:23 AM
To: Senthil K <Sen...@ar...>; ltp...@li...
Subject: Re: [LTP] LTP for ARM64

Is this for which OS?
On Fri, Jan 6, 2017 at 7:53 AM Senthil K <Sen...@ar...<mailto:Sen...@ar...>> wrote:













Hi All,



We are using user space 32bit and kernel space 64 bit for ARMV8 platform.



We have compiled the LTP using 32 bit tool chain. Follwoing are the steps we have followed



export AR=arm-buildroot-linux-ar

export LD=arm-buildroot-linux-ld

export CC=arm-buildroot-linux-gcc



./configure --host=arm-linux --target=arm-buildroot-linux --exec-prefix=/home/

make

make install.



The compilation was successful.



We are observing that there are more failures due to "getpwnam(nobody)" - ENOENT.



We have added the  nobody entry in /etc/passwd file but still we are getting the issue.



Please share your inputs.

























Senthil K
























"DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what

it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this

message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus."




------------------------------------------------------------------------------

Check out the vibrant tech community on one of the world's most

engaging tech sites, SlashDot.org! http://sdm.link/slashdot_______________________________________________

Ltp-list mailing list

Ltp...@li...<mailto:Ltp...@li...>

https://lists.sourceforge.net/lists/listinfo/ltp-list
"DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus."

Re: [LTP] LTP for ARM64

[$<ri...@nt...>]

Is this for which OS?
On Fri, Jan 6, 2017 at 7:53 AM Senthil K <Sen...@ar...> wrote:

>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> Hi All,
>
>
>
>
>
> We are using user space 32bit and kernel space 64 bit for ARMV8 platform.
>
>
>
>
>
> We have compiled the LTP using 32 bit tool chain. Follwoing are the steps
> we have followed
>
>
>
>
>
> export AR=arm-buildroot-linux-ar
>
>
> export LD=arm-buildroot-linux-ld
>
>
> export CC=arm-buildroot-linux-gcc
>
>
>
>
>
> ./configure --host=arm-linux --target=arm-buildroot-linux
> --exec-prefix=/home/
>
>
> make
>
>
> make install.
>
>
>
>
>
> The compilation was successful.
>
>
>
>
>
> We are observing that there are more failures due to "getpwnam(nobody)" -
> ENOENT.
>
>
>
>
>
> We have added the  nobody entry in /etc/passwd file but still we are
> getting the issue.
>
>
>
>
>
> Please share your inputs.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> *Senthil K*
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> "DISCLAIMER: This message is proprietary to Aricent and is intended solely
> for the use of the individual to whom it is addressed. It may contain
> privileged or confidential information and should not be circulated or used
> for any purpose other than for what
>
> it is intended. If you have received this message in error, please notify
> the originator immediately. If you are not the intended recipient, you are
> notified that you are strictly prohibited from using, copying, altering, or
> disclosing the contents of this
>
> message. Aricent accepts no responsibility for loss or damage arising from
> the use of the information transmitted by this email including damage from
> virus."
>
>
>
>
>
>
> ------------------------------------------------------------------------------
>
> Check out the vibrant tech community on one of the world's most
>
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
>
> Ltp-list mailing list
>
> Ltp...@li...
>
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>

[LTP] LTP for ARM64

[Senthil K <Sen...@ar...>]

Hi All,

We are using user space 32bit and kernel space 64 bit for ARMV8 platform.

We have compiled the LTP using 32 bit tool chain. Follwoing are the steps we have followed

export AR=arm-buildroot-linux-ar
export LD=arm-buildroot-linux-ld
export CC=arm-buildroot-linux-gcc

./configure --host=arm-linux --target=arm-buildroot-linux --exec-prefix=/home/
make
make install.

The compilation was successful.

We are observing that there are more failures due to "getpwnam(nobody)" - ENOENT.

We have added the  nobody entry in /etc/passwd file but still we are getting the issue.

Please share your inputs.



Senthil K









"DISCLAIMER: This message is proprietary to Aricent and is intended solely for the use of the individual to whom it is addressed. It may contain privileged or confidential information and should not be circulated or used for any purpose other than for what it is intended. If you have received this message in error, please notify the originator immediately. If you are not the intended recipient, you are notified that you are strictly prohibited from using, copying, altering, or disclosing the contents of this message. Aricent accepts no responsibility for loss or damage arising from the use of the information transmitted by this email including damage from virus."

Re: [LTP] execute group of test cases.

[Cyril H. <ch...@su...>]

Hi!
> How can I run only below test cases using "runltp" command. I now below
> command but do not know the argument to pass.
> ./runltp -p -l <log file name> -f <testcase name>
> 
> Is there any way to run ?
> 
> 
> netns_breakns_ns_exec_ipv4_
> netns_breakns_ns_exec_ipv6_
> netns_breakns_ns_exec_ipv4_
> netns_breakns_ns_exec_ipv6_
> netns_breakns_ip_ipv4_netli
> netns_breakns_ip_ipv6_netli
> netns_breakns_ip_ipv4_ioctl
> netns_breakns_ip_ipv6_ioctl
> netns_comm_ns_exec_ipv4_net
> netns_comm_ns_exec_ipv6_net
> netns_comm_ns_exec_ipv4_ioc
> netns_comm_ns_exec_ipv6_ioc
> netns_comm_ip_ipv4_netlink
> netns_comm_ip_ipv6_netlink
> netns_comm_ip_ipv4_ioctl
> netns_comm_ip_ipv6_ioctl

The easiest way is to create custom runtest file, i.e. copy
runtest/containers to new file and delete what you do not want to run.
Then you can pass the newly created file name via the -f argument.

-- 
Cyril Hrubis
ch...@su...

[LTP] updating message_queue_test_02_*

[fixed-term.Oleksij.Rempel <fix...@de...>]

Hallo all,

it is kind of a duplication of this case:
https://github.com/linux-test-project/ltp/issues/75

some of message_queue_test_02_* are fail on our configuration, it looks
like the reason is hardcoded tmp path, which is different in our test setup.

Looks like this tests should be updated to use current ltp bindings..
which should also fix this issue.  Do any one already working on it? If
not, me or some of us will try to do it.
-- 
Best regards,
Oleksij Rempel
CM-AI/ECO3
Tel.: +49(5121)49-2962

Re: [LTP] [PATCH 1/3] lib/test_net.sh: add tst_ping() to check icmp connectivity

[Alexey K. <ale...@or...>]

Hi,
On 03/07/2016 10:01 AM, Hangbin Liu wrote:
> Signed-off-by: Hangbin Liu <ha...@re...>
> ---
>   testcases/lib/test_net.sh | 37 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)
>
> diff --git a/testcases/lib/test_net.sh b/testcases/lib/test_net.sh
> index 418fed3..f75e78e 100644
> --- a/testcases/lib/test_net.sh
> +++ b/testcases/lib/test_net.sh
> @@ -314,3 +314,40 @@ tst_netload()
>   
>   	return $ret
>   }
> +
> +# tst_ping IFACE ADDR [SIZE]
> +# Check icmp connectivity
> +# IFACE: source interface name
> +# ADDR: destination IPv4 or IPv6 address
> +# SIZE: message size
> +tst_ping()
> +{
> +	# The max number of ICMP echo request
> +	PING_MAX=${PING_MAX:-"10"}
> +
> +	# Check the arguments
> +	if [ $# -lt 2 ]; then
> +		tst_resm TBROK "tst_ping src_iface dest_ipv4/6_addr [msg_size]"
> +		return 1
> +	fi
> +
> +	local src_iface=$1
> +	local dst_addr=$2

They could be defaulted to $(tst_iface) and $(tst_ipaddr rhost) accordingly.
Then, we don't have to check the number of arguments and it fits for the 
most cases.

> +	# ping cmd use 56 as default message size
> +	local msg_size=${3:-"56"}
> +
> +	if echo $dst_addr | grep ":"; then
> +		local PING="ping6"
> +		TST_IPV6=6
> +	else
> +		local PING="ping"
> +	fi
> +

if test runs with -6 option, TST_IPV6 will be defined as 6, otherwise is "".
We can use it inside test_net.sh and tests. So here, we could call ping 
command
as follows: "ping$TST_IPV6 ..."


> +	if [ "$dst_addr" == "$(tst_ipaddr)" ]; then
> +		tst_rhost_run -c "$PING -I $src_iface -c $PING_MAX $dst_addr \
> +			-s $msg_size > /dev/null 2>&1"
> +	else
> +		$PING -I $src_iface -c $PING_MAX $dst_addr -s $msg_size > \
> +			/dev/null 2>&1
> +	fi
> +}

Do we actually need to run this command from remote host?

Best regards,
Alexey

[LTP] LTP test coverage ?

[Verma, P. <pan...@in...>]

Hi,

Does LTP covers Ethernet and NAND components on Yocto Linux.

Thanks,
Pankaj Verma

[LTP] Some test cases are failed in LTP for Mips32 platform

[Raghavendra K. <Rag...@in...>]

Hi All,


I built the LTP for the yocto and ran it on the My board which has the Mips interaptive CPU.


After running all tests 42 test are getting failed.


I have examine the each failed test case and noted down the issue.


Following test cases are failed:


1.bind02 - unable to open the socket to testuser
2.chmod06 - Device busy error.
3.getrusage03 - memory allocation failed
4.Readahead02 - Page cache on our system is too small to hold whole testfile.
5.rt_sigaction01 - Gives the buss error.


Could you please help me to resolving this issues.


Thanks in Advance.


Regards,

Raghavendra K.

[LTP] [PATCH] mem/oom: remove non-existent case OVERCOMMIT from oom()

[Han P. <ha...@li...>]

Looks like there is no such a case "OVERCOMMIT" in oom(), so we can just
remove it.

Signed-off-by: Han Pingtian <ha...@li...>
---
 testcases/kernel/mem/include/mem.h | 7 +++----
 testcases/kernel/mem/lib/mem.c     | 2 +-
 testcases/kernel/mem/oom/oom01.c   | 4 ++--
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/testcases/kernel/mem/include/mem.h b/testcases/kernel/mem/include/mem.h
index 4a18799..041c437 100644
--- a/testcases/kernel/mem/include/mem.h
+++ b/testcases/kernel/mem/include/mem.h
@@ -32,10 +32,9 @@ static inline void clean_node(unsigned long *array)
 
 #define LENGTH			(3UL<<30)
 #define TESTMEM			(1UL<<30)
-#define OVERCOMMIT		1
-#define NORMAL			2
-#define MLOCK			3
-#define KSM			4
+#define NORMAL			1
+#define MLOCK			2
+#define KSM			3
 
 long overcommit;
 void oom(int testcase, int lite, int retcode, int allow_sigkill);
diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
index cee4e91..56104cb 100644
--- a/testcases/kernel/mem/lib/mem.c
+++ b/testcases/kernel/mem/lib/mem.c
@@ -110,7 +110,7 @@ out:
  * oom - allocates memory according to specified testcase and checks
  *       desired outcome (e.g. child killed, operation failed with ENOMEM)
  * @testcase: selects how child allocates memory
- *            valid choices are: OVERCOMMIT, NORMAL, MLOCK and KSM
+ *            valid choices are: NORMAL, MLOCK and KSM
  * @lite: if non-zero, child makes only single TESTMEM+MB allocation
  *        if zero, child keeps allocating memory until it gets killed
  *        or some operation fails
diff --git a/testcases/kernel/mem/oom/oom01.c b/testcases/kernel/mem/oom/oom01.c
index 712d7b5..e39394b 100644
--- a/testcases/kernel/mem/oom/oom01.c
+++ b/testcases/kernel/mem/oom/oom01.c
@@ -58,12 +58,12 @@ int main(int argc, char *argv[])
 
 		/* we expect mmap to fail before OOM is hit */
 		set_sys_tune("overcommit_memory", 2, 1);
-		oom(OVERCOMMIT, 0, ENOMEM, 0);
+		oom(NORMAL, 0, ENOMEM, 0);
 
 		/* with overcommit_memory set to 0 or 1 there's no
 		 * guarantee that mmap fails before OOM */
 		set_sys_tune("overcommit_memory", 0, 1);
-		oom(OVERCOMMIT, 0, ENOMEM, 1);
+		oom(NORMAL, 0, ENOMEM, 1);
 
 		set_sys_tune("overcommit_memory", 1, 1);
 		testoom(0, 0, ENOMEM, 1);
-- 
1.9.3

[LTP] [Query] Regarding broken_ip4_version testcase

[Manjeet P. <man...@sa...>]

HI,

I am running broken_ip testcases. I am using below env setting

export NETWORK_DELAY=30
export LTP_RSH="ssh -q  -o StrictHostKeyChecking=no -i /root/.ssh/id_rsa -l root"

Testcase:- "broken_ip4_version"
Logs: here (xxx.xxx.xxx.xxx is rhost address)
++ssh -n -q ro...@xx... 'sh -c    '\' ip link set eth0 down  || echo RTERR'\'''
<testcase stuck here>

I am not able to proceed after this command. I checked my remote machine, its network is already down when this command executed, but the testcase stuck at this moment and not returning anything.
Am I missing anything?
I checked with all my env settings, they are working for rest of the other testcases but not for this category "broken_ip_*).

Thanks
Manjeet 

Re: [LTP] [Query] Regarding network testcases

[Alexey K. <ale...@or...>]

Hi,
On 12/09/2015 11:59 AM, Manjeet Pawar wrote:
> Hi,
>
> I am facing issues while running some network testcases : e.g. if4-addr-change
> This testcase belongs to latest (ltp-full-20150903.tar.bz2)
> when I run this  if4-addr-change, I exported two new env variables a) IPV4_NETWORK = "107.109.223" and IPV6_NETWORK = "fd00::1:1:1:1", b) LHOST_IFACES = eth0 and RHOST_IFACES = eth0, which is not exported in "test_net.sh" .
> bacause "if4-addr-change " testcase invokes "est_net.sh".
>
...
> ++ echo fd00::1:1:1:1:
> + ip addr add fd00::1:1:1:1:/64 dev eth0
> ip: RTNETLINK answers: Numerical result out of range
> + return 2
> + ret=2
> + TST_IPV6=
> + return 2
> + exit 2
> <<<<<<<<<<<<<<<<<<<execution_status>>>>>>>>>>>>
> initiation_status="ok"
> duration=13 termination_type=exited termination_id=2 corefile=no
> cutime=49 cstime=627
> <<<<<<<<<<<<<<<<<<<test_end>>>>>>>>>>>>>>>>>>>>>
>
> Please check the IP addresses taken by the program, they are in wrong format.
> Is there anything that I am missing to run this testcase ? . Also I tried to do manually fix to get IP addresses in correct way but that should not be done, it need many changes to be done in "test_net.sh".
> This test scripts is invoked by  other testcases like  "network_stress.broken_ip". So all these testcases are failing.
> Please suggest more detail regarding "test_net.sh".

Defining IPv6 network as IPV6_NETWORK = "fd00::1:1:1:1" is not quite 
correct. Here you have specified the IPv6 address, not network.

There are other variables that should be defined as well: 
LHOST_IPV4_HOST, RHOST_IPV4_HOST, LHOST_IPV6_HOST, RHOST_IPV6_HOST, i.e. 
host specific parts.

In your case IPv6 network is "fd00::/64", and I would set vars as follows:
IPV6_NETWORK = "fd00"
LHOST_IPV6_HOST=":1:1:1:1"

After that you will get fd00::1:1:1:1/64 address in the tests 
(${IPV6_NETWORK}:${LHOST_IPV6_HOST}).

Best regards,
Alexey

>
> Thanks
>
>
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [Query] Regarding network testcases

[Manjeet P. <man...@sa...>]

Hi,

I am facing issues while running some network testcases : e.g. if4-addr-change
This testcase belongs to latest (ltp-full-20150903.tar.bz2)
when I run this  if4-addr-change, I exported two new env variables a) IPV4_NETWORK = "107.109.223" and IPV6_NETWORK = "fd00::1:1:1:1", b) LHOST_IFACES = eth0 and RHOST_IFACES = eth0, which is not exported in "test_net.sh" .
bacause "if4-addr-change " testcase invokes "est_net.sh".

testcase output:
<<<<<<<<<<<<<<<<<<<test_start>>>>>>>>>>>>>>>>>>>
tag(Testcase Name)=if4-addr-change stime=15540
cmdline="if4-addr-change"
contacts=""
analysis=exit
<<<<<<<<<<<<<<<<<<<test_output>>>>>>>>>>>>>>>>>>>
+ TST_TOTAL=1
+ TCID=if4-addr-change
+ TST_CLEANUP=tst_restore_ipaddr
+ . test_net.sh
++ '[' -z '' ']'
++ . test.sh
+++ export LTP_RET_VAL=0
+++ LTP_RET_VAL=0
+++ export TST_COUNT=1
+++ TST_COUNT=1
+++ export TST_LIB_LOADED=1
+++ TST_LIB_LOADED=1
+++ '[' -z if4-addr-change ']'
+++ '[' -z 1 ']'
+++ export TCID=if4-addr-change
+++ TCID=if4-addr-change
+++ export TST_TOTAL=1
+++ TST_TOTAL=1
+++ '[' -z /tmp/build_dir ']'
+++ export LTP_DATAROOT=/tmp/build_dir/testcases/data/if4-addr-change
+++ LTP_DATAROOT=/tmp/build_dir/testcases/data/if4-addr-change
++ TST_IPV6=
++ tst_read_opts
++ OPTIND=0
++ getopts :6 opt
++ OPTIND=0
+ CHECK_INTERVAL=0
+ LHOST_IPV4_HOST_MAX=254
+ trap 'tst_brkm TBROK '\''test interrupted'\''' INT
+ tst_check_cmds ifconfig
+ for cmd in '$*'
+ command -v ifconfig
+ tst_resm TINFO 'ifconfig changes IPv4 address 10 times'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=16
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : ifconfig changes IPv4 address 10 times'
if4-addr-change 1 TINFO : ifconfig changes IPv4 address 10 times
+ case "$ret" in
+ tst_restore_ipaddr
+ local type=lhost
+ local link_num=0
+ tst_init_iface lhost 0
+ local type=lhost
+ local link_num=0
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ tst_resm TINFO 'initialize '\''lhost'\'' '\''eth0'\'' interface'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=16
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : initialize '\''lhost'\'' '\''eth0'\'' interface'
if4-addr-change 1 TINFO : initialize 'lhost' 'eth0' interface
+ case "$ret" in
+ '[' lhost = lhost ']'
+ ip link set eth0 down
+ ip route flush dev eth0
+ ip addr flush dev eth0
+ ip link set eth0 up
+ return 0
+ local ret=0
+ local backup_tst_ipv6=
+ TST_IPV6=
+ tst_add_ipaddr lhost 0
+ local type=lhost
+ local link_num=0
+ local mask=24
+ '[' '' ']'
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ '[' lhost = lhost ']'
++ tst_ipaddr
++ local type=lhost
++ local ipv=4
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ tst_resm TINFO 'set local addr 107.109.223./24'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=16
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : set local addr 107.109.223./24'
if4-addr-change 1 TINFO : set local addr 107.109.223./24
+ case "$ret" in
++ tst_ipaddr
++ local type=lhost
++ local ipv=4
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ ip addr add 107.109.223./24 dev eth0
+ return 0
+ TST_IPV6=6
+ tst_add_ipaddr lhost 0
+ local type=lhost
+ local link_num=0
+ local mask=24
+ '[' 6 ']'
+ mask=64
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
++ awk '{ print $1 }'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ '[' lhost = lhost ']'
++ tst_ipaddr
++ local type=lhost
++ local ipv=6
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV6_HOST'
+++ tst_host=
++ '[' 6 ']'
++ echo fd00::1:1:1:1:
+ tst_resm TINFO 'set local addr fd00::1:1:1:1:/64'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=16
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : set local addr fd00::1:1:1:1:/64'
if4-addr-change 1 TINFO : set local addr fd00::1:1:1:1:/64
+ case "$ret" in
++ tst_ipaddr
++ local type=lhost
++ local ipv=6
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV6_HOST'
+++ tst_host=
++ '[' 6 ']'
++ echo fd00::1:1:1:1:
+ ip addr add fd00::1:1:1:1:/64 dev eth0
ip: RTNETLINK answers: Numerical result out of range
+ return 2
+ ret=2
+ TST_IPV6=
+ return 2
++ tst_iface
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
++ tst_ipaddr rhost
++ local type=rhost
++ local ipv=4
++ local tst_host=
++ '[' rhost = lhost ']'
++ eval 'tst_host=$RHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
++ tst_iface
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
++ tst_ipaddr rhost
++ local type=rhost
++ local ipv=4
++ local tst_host=
++ '[' rhost = lhost ']'
++ eval 'tst_host=$RHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ check_icmpv4_connectivity eth0 107.109.223.
++ tst_ipaddr rhost
++ local type=rhost
++ local ipv=4
++ local tst_host=
++ '[' rhost = lhost ']'
++ eval 'tst_host=$RHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ tst_brkm TBROK 'Failed to ping to 107.109.223.'
+ case "$1" in
+ local ret=TBROK
+ shift
+ tst_resm TBROK 'Failed to ping to 107.109.223.'
+ tst_flag2mask TBROK
+ case "$1" in
+ return 2
+ local mask=2
+ LTP_RET_VAL=18
+ local ret=TBROK
+ shift
+ echo 'if4-addr-change 1 TBROK : Failed to ping to 107.109.223.'
if4-addr-change 1 TBROK : Failed to ping to 107.109.223.
+ case "$ret" in
+ tst_exit
+ '[' -n tst_restore_ipaddr ']'
+ tst_restore_ipaddr
+ local type=lhost
+ local link_num=0
+ tst_init_iface lhost 0
+ local type=lhost
+ local link_num=0
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ tst_resm TINFO 'initialize '\''lhost'\'' '\''eth0'\'' interface'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=18
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : initialize '\''lhost'\'' '\''eth0'\'' interface'
if4-addr-change 1 TINFO : initialize 'lhost' 'eth0' interface
+ case "$ret" in
+ '[' lhost = lhost ']'
+ ip link set eth0 down
+ ip route flush dev eth0
+ ip addr flush dev eth0
+ ip link set eth0 up
+ return 0
+ local ret=0
+ local backup_tst_ipv6=
+ TST_IPV6=
+ tst_add_ipaddr lhost 0
+ local type=lhost
+ local link_num=0
+ local mask=24
+ '[' '' ']'
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ '[' lhost = lhost ']'
++ tst_ipaddr
++ local type=lhost
++ local ipv=4
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ tst_resm TINFO 'set local addr 107.109.223./24'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=18
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : set local addr 107.109.223./24'
if4-addr-change 1 TINFO : set local addr 107.109.223./24
+ case "$ret" in
++ tst_ipaddr
++ local type=lhost
++ local ipv=4
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV4_HOST'
+++ tst_host=
++ '[' '' ']'
++ echo 107.109.223.
+ ip addr add 107.109.223./24 dev eth0
+ return 0
+ TST_IPV6=6
+ tst_add_ipaddr lhost 0
+ local type=lhost
+ local link_num=0
+ local mask=24
+ '[' 6 ']'
+ mask=64
++ tst_iface lhost 0
++ local type=lhost
++ local link_num=0
++ link_num=1
++ awk '{ print $1 }'
+++ tst_get_ifaces lhost
+++ local type=lhost
+++ '[' lhost = lhost ']'
+++ echo eth0
++ echo eth0
+ local iface=eth0
+ '[' lhost = lhost ']'
++ tst_ipaddr
++ local type=lhost
++ local ipv=6
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV6_HOST'
+++ tst_host=
++ '[' 6 ']'
++ echo fd00::1:1:1:1:
+ tst_resm TINFO 'set local addr fd00::1:1:1:1:/64'
+ tst_flag2mask TINFO
+ case "$1" in
+ return 16
+ local mask=16
+ LTP_RET_VAL=18
+ local ret=TINFO
+ shift
+ echo 'if4-addr-change 1 TINFO : set local addr fd00::1:1:1:1:/64'
if4-addr-change 1 TINFO : set local addr fd00::1:1:1:1:/64
+ case "$ret" in
++ tst_ipaddr
++ local type=lhost
++ local ipv=6
++ local tst_host=
++ '[' lhost = lhost ']'
++ eval 'tst_host=$LHOST_IPV6_HOST'
+++ tst_host=
++ '[' 6 ']'
++ echo fd00::1:1:1:1:
+ ip addr add fd00::1:1:1:1:/64 dev eth0
ip: RTNETLINK answers: Numerical result out of range
+ return 2
+ ret=2
+ TST_IPV6=
+ return 2
+ exit 2
<<<<<<<<<<<<<<<<<<<execution_status>>>>>>>>>>>>
initiation_status="ok"
duration=13 termination_type=exited termination_id=2 corefile=no
cutime=49 cstime=627
<<<<<<<<<<<<<<<<<<<test_end>>>>>>>>>>>>>>>>>>>>>

Please check the IP addresses taken by the program, they are in wrong format. 
Is there anything that I am missing to run this testcase ? . Also I tried to do manually fix to get IP addresses in correct way but that should not be done, it need many changes to be done in "test_net.sh".
This test scripts is invoked by  other testcases like  "network_stress.broken_ip". So all these testcases are failing.
Please suggest more detail regarding "test_net.sh". 

Thanks

Re: [LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi Cyril

>
> The build system for Open Posix Testsuite is not integrated with the
> rest of the build system. But it shouldn't need anything more than
> setting up right compiler:
>
> $ export CC=arm-buildroot-linux-gnueabi-gcc
> $ make
>
it work, and many appreciate your kind help ^^

Re: [LTP] how to cross compile linux test project?

[Cyril H. <ch...@su...>]

Hi!
> I can successfully configure the LTP for arm cross-compiling.
> But I found even if I enable posix-testsuites with below configs:
> ./configure AR=arm-buildroot-linux-gnueabi-ar
> CC=arm-buildroot-linux-gnueabi-gcc
> RANLIB=arm-buildroot-linux-gnueabi-ranlib
> STRIP=arm-buildroot-linux-gnueabi-strip --host=arm-linux
> --target=arm-buildroot-linux LDFLAGS=-pthread
> --with-open-posix-testsuite
> 
> the test binary located in testcases/open_posix_testsuite/conformance/
> are sill for X86, Not for the host, arm, I configure.
> 
> Is there anything I need to take care for cross compiling
> --with-open-posix-testsuite?
> or --with-open-posix-testsuite so far not support cross compile ?
> 
> appreciate your kind help in advance,

The build system for Open Posix Testsuite is not integrated with the
rest of the build system. But it shouldn't need anything more than
setting up right compiler:

$ export CC=arm-buildroot-linux-gnueabi-gcc
$ make

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi all:

2015-10-22 20:13 GMT+08:00 Cyril Hrubis <ch...@su...>:
> Hi!
>> > Hi!
>> > FYI this list has been abandoned, all discussion now happens on
>> > lt...@li...
>> if so, would you mind to let me know how to register that mail list?
>> thanks a lot,
>
> It's a mailman at lists.linux.it: http://lists.linux.it/listinfo/ltp
>
> I've updated all LTP documentation to point to this list so if you, for
> instance look at README in the LTP git repo it will point you this
> page as well...
I can successfully configure the LTP for arm cross-compiling.
But I found even if I enable posix-testsuites with below configs:
./configure AR=arm-buildroot-linux-gnueabi-ar
CC=arm-buildroot-linux-gnueabi-gcc
RANLIB=arm-buildroot-linux-gnueabi-ranlib
STRIP=arm-buildroot-linux-gnueabi-strip --host=arm-linux
--target=arm-buildroot-linux LDFLAGS=-pthread
--with-open-posix-testsuite

the test binary located in testcases/open_posix_testsuite/conformance/
are sill for X86, Not for the host, arm, I configure.

Is there anything I need to take care for cross compiling
--with-open-posix-testsuite?
or --with-open-posix-testsuite so far not support cross compile ?

appreciate your kind help in advance,