ltp-list — General Discussions

Re: [LTP] error while compiling ltp statically

[Cyril H. <ch...@su...>]

Hi!
This list has been retired, please use lt...@li...
(http://lists.linux.it/listinfo/ltp) instead.

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] error while compiling ltp statically

[$<ri...@nt...>]

ltp-list is no more maintaining. Adding new list for communication.

This is because openlog is already defined in the libc and which you
can't redefine it again.

On Wed, Oct 28, 2015 at 4:43 PM, Yesuraj Abraham <yes...@gm...> wrote:
> Hi
> I tried compiling ltp statically using arm toolchain, as follows
> export
> CC=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-gcc
> export
> LD=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ld
> export
> AR=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ar
> export
> AS=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-as
> export
> RANLIB=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ranlib
> export
> STRIP=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-strip
>
> ./configure --host=arm-linux
> --prefix=/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/install
> --exec-prefix=/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/install
> LDFLAGS="-static -pthread"
>  make
>
> It throws the following error(s),
>
> /home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/../arm-none-linux-gnueabi/libc/usr/lib/libc.a(syslog.o):
> In function `openlog': syslog.c:(.text+0x814): multiple definition of
> `openlog'
> /tmp/ccusZ6dp.o:/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/testcases/kernel/fs/fs-bench/random-access.c:66:
> first defined here
>
> The same error is thrown for the file, random-access-del-create.c too.
>
> When i modified openlog to other name (openlog1) in both the files, then it
> compiles successfully.
>
> However when i build using x86 tool chain in the same manner (static flag
> enabled), it builds successfully without the above error(s).
>
> Regards,
> yesuraj
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>



-- 
Thanks & Regards,
M.Srikanth Kumar.

[LTP] error while compiling ltp statically

[Yesuraj A. <yes...@gm...>]

Hi
I tried compiling ltp statically using arm toolchain, as follows
export
CC=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-gcc
export
LD=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ld
export
AR=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ar
export
AS=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-as
export
RANLIB=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-ranlib
export
STRIP=/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/arm-none-linux-gnueabi-strip

./configure --host=arm-linux
--prefix=/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/install
--exec-prefix=/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/install
LDFLAGS="-static -pthread"
 make

It throws the following error(s),

/home/ltblr/CodeSourcery/Sourcery_CodeBench_Lite_for_ARM_GNU_Linux/bin/../arm-none-linux-gnueabi/libc/usr/lib/libc.a(syslog.o):
In function `openlog': syslog.c:(.text+0x814): multiple definition of
`openlog'
/tmp/ccusZ6dp.o:/home/ltblr/yesuraj/test_apps/ltp/arm-none-tool-chain/static_compilation/ltp-full-20150420/testcases/kernel/fs/fs-bench/random-access.c:66:
first defined here

The same error is thrown for the file, random-access-del-create.c too.

When i modified openlog to other name (openlog1) in both the files, then it
compiles successfully.

However when i build using x86 tool chain in the same manner (static flag
enabled), it builds successfully without the above error(s).

Regards,
yesuraj

Re: [LTP] how to cross compile linux test project?

[Cyril H. <ch...@su...>]

Hi!
> > Hi!
> > FYI this list has been abandoned, all discussion now happens on
> > lt...@li...
> if so, would you mind to let me know how to register that mail list?
> thanks a lot,

It's a mailman at lists.linux.it: http://lists.linux.it/listinfo/ltp

I've updated all LTP documentation to point to this list so if you, for
instance look at README in the LTP git repo it will point you this
page as well...

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi Cyril:


2015-10-22 18:55 GMT+08:00 Cyril Hrubis <ch...@su...>:
> Hi!
> FYI this list has been abandoned, all discussion now happens on
> lt...@li...
if so, would you mind to let me know how to register that mail list?
thanks a lot,

Re: [LTP] how to cross compile linux test project?

[Cyril H. <ch...@su...>]

Hi!
FYI this list has been abandoned, all discussion now happens on
lt...@li...

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] how to cross compile linux test project?

[Zeng L. <zen...@cn...>]

Hello,

On Thu, 2015-10-22 at 13:41 +0800, vichy wrote:
> hi Strik:
> 
> 2015-10-21 23:59 GMT+08:00 $rik@nth <sri...@gm...>:
> > you need to run autoconf program with no arguments and then autoconf
> > processes `configure.ac' to generate configure file.
> when i use autoconf I get below error message
> # autoconf
> configure.ac:4: error: possibly undefined macro: AM_INIT_AUTOMAKE
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> configure.ac:15: error: possibly undefined macro: AM_CONDITIONAL
> #

I think you should do like:
1. cd <ltp>
2. aclocal -I m4
3. autoconf
4. autoheader
5. automake -c -a

And you can do "make autotools" instead of "step 2, 3, 4, 5"

Thanks,
Zeng



> 
> I use ubuntu 14.04 64bit to cross compile linux test project.
> appreciate your kind help,
> 
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi all:

2015-10-22 13:41 GMT+08:00 vichy <vic...@gm...>:
> hi Strik:
>
> 2015-10-21 23:59 GMT+08:00 $rik@nth <sri...@gm...>:
>> you need to run autoconf program with no arguments and then autoconf
>> processes `configure.ac' to generate configure file.
> when i use autoconf I get below error message
> # autoconf
> configure.ac:4: error: possibly undefined macro: AM_INIT_AUTOMAKE
>       If this token and others are legitimate, please use m4_pattern_allow.
>       See the Autoconf documentation.
> configure.ac:15: error: possibly undefined macro: AM_CONDITIONAL
> #
>
> I use ubuntu 14.04 64bit to cross compile linux test project.
forget to mentioned
Below is my autoconf version

autoconf (GNU Autoconf) 2.65
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+/Autoconf: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by David J. MacKenzie and Akim Demaille.

Re: [LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi Strik:

2015-10-21 23:59 GMT+08:00 $rik@nth <sri...@gm...>:
> you need to run autoconf program with no arguments and then autoconf
> processes `configure.ac' to generate configure file.
when i use autoconf I get below error message
# autoconf
configure.ac:4: error: possibly undefined macro: AM_INIT_AUTOMAKE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:15: error: possibly undefined macro: AM_CONDITIONAL
#

I use ubuntu 14.04 64bit to cross compile linux test project.
appreciate your kind help,

Re: [LTP] how to cross compile linux test project?

[$<ri...@nt...>]

you need to run autoconf program with no arguments and then autoconf
processes `configure.ac' to generate configure file.

On Wed, Oct 21, 2015 at 9:05 PM, vichy <vic...@gm...> wrote:
> hi All:
> I try to compile linux test project for Arm platform.
> And below is the link suggest how to configure it.
> http://sourceforge.net/p/ltp/mailman/message/34480155/
>
> But when I git clone https://github.com/linux-test-project/ltp
> it seems no configure in the git repository.
> Should I run and bootstrap to get configure file?
>
> Appreciate your kind help,
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list



-- 
Thanks & Regards,
M.Srikanth Kumar.

[LTP] how to cross compile linux test project?

[vichy <vic...@gm...>]

hi All:
I try to compile linux test project for Arm platform.
And below is the link suggest how to configure it.
http://sourceforge.net/p/ltp/mailman/message/34480155/

But when I git clone https://github.com/linux-test-project/ltp
it seems no configure in the git repository.
Should I run and bootstrap to get configure file?

Appreciate your kind help,

Re: [LTP] [PATCH v2] sched_getattr/sched_getattr01: Add new testcase to test sched_getattr

[Cyril H. <ch...@su...>]

Hi!
> +/*
> + * Copyright (c) 2015 Cui Bixuan <cui...@hu...>
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write the Free Software Foundation,
> + * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> + */
> +
> +#ifndef __SCHED_H__
> +#define __SCHED_H__
> +
> +#include "linux_syscall_numbers.h"

You should include stdint.h here to get the int32_t and uint64_t types
defined.

> diff --git a/runtest/sched b/runtest/sched
> index 16877a3..10a1648 100644
> --- a/runtest/sched
> +++ b/runtest/sched
> @@ -9,6 +9,8 @@ trace_sched01		trace_sched -c 1
>  hackbench01 hackbench 50 process 1000
>  hackbench02 hackbench 20 thread 1000
> 
> +sched_getattr01 sched_getattr01

Given that this is simple sched_getattr syscall test we may as well
include the test in runtest/syscalls.

> diff --git a/testcases/kernel/syscalls/sched_getattr/Makefile b/testcases/kernel/syscalls/sched_getattr/Makefile
> new file mode 100644
> index 0000000..30d6cf3
> --- /dev/null
> +++ b/testcases/kernel/syscalls/sched_getattr/Makefile
> @@ -0,0 +1,25 @@
> +#
> +#  Copyright (c) International Business Machines  Corp., 2008
> +#
> +#  This program is free software;  you can redistribute it and/or modify
> +#  it under the terms of the GNU General Public License as published by
> +#  the Free Software Foundation; either version 2 of the License, or
> +#  (at your option) any later version.
> +#
> +#  This program is distributed in the hope that it will be useful,
> +#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
> +#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> +#  the GNU General Public License for more details.
> +#
> +#  You should have received a copy of the GNU General Public License
> +#  along with this program;  if not, write to the Free Software
> +#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#
> +
> +top_srcdir		?= ../../../..
> +
> +include $(top_srcdir)/include/mk/testcases.mk
> +
> +CFLAGS			+= -lpthread
                                    ^
				    This should be -pthread see for
				    example 'man pthread_create'

> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> new file mode 100644
> index 0000000..6570e86
> --- /dev/null
> +++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> @@ -0,0 +1,92 @@
> +#define _GNU_SOURCE
> +#include <unistd.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <time.h>
> +#include <linux/unistd.h>
> +#include <linux/kernel.h>
> +#include <linux/types.h>
> +#include <sys/syscall.h>
> +#include <pthread.h>
> +#include <sched.h>
> +#include <errno.h>
> +
> +#include "test.h"
> +#include "linux_syscall_numbers.h"
> +#include "lapi/sched.h"
> +
> +char *TCID = "edf_test01";
> +int TST_TOTAL = 1;
> +
> +#define SCHED_DEADLINE	6
> +#define RUNTIME_VAL 10000000
> +#define PERIOD_VAL 30000000
> +#define DEADLINE_VAL 30000000
> +
> +void *run_deadline(void *data)
> +{
> +	struct sched_attr attr, attr_copy;
> +	int ret;
> +	unsigned int flags = 0;
> +	unsigned int size;
> +
> +	attr.size = sizeof(attr);
> +	attr.sched_flags = 0;
> +	attr.sched_nice = 0;
> +	attr.sched_priority = 0;
> +
> +	/* This creates a 10ms/30ms reservation */
> +	attr.sched_policy = SCHED_DEADLINE;
> +	attr.sched_runtime = 10 * 1000 * 1000;
> +	attr.sched_period = 30 * 1000 * 1000;
> +	attr.sched_deadline = 30 * 1000 * 1000;
> +
> +	ret = sched_setattr(0, &attr, flags);
> +	if (ret < 0)
> +		tst_brkm(TFAIL | TERRNO, NULL, "sched_setattr error\n");
> +
> +	size = sizeof(attr_copy);
> +	ret = sched_getattr(0, &attr_copy, size, flags);
> +	if (ret < 0)
> +		tst_brkm(TFAIL | TERRNO, NULL, "sched_getattr error\n");
> +
> +	int fail = 0;
> +
> +	if (attr_copy.sched_runtime != RUNTIME_VAL) {
> +		tst_resm(TINFO, "sched_runtime is incorrect (%llu),expected"
> +				" %u", attr.sched_runtime, RUNTIME_VAL);
> +		fail++;
> +	}
> +	if (attr_copy.sched_period != PERIOD_VAL) {
> +		tst_resm(TINFO, "sched_period is incorrect (%llu),expected"
> +				" %u", attr.sched_period, PERIOD_VAL);
                                          ^
				Technically this is uint64_t so the
				clean way to print it is to use PRIu64
				or to cast the attribute to long long
				unsigned int.
> +		fail++;
> +	}
> +	if (attr_copy.sched_deadline != DEADLINE_VAL) {
> +		tst_resm(TINFO, "sched_deadline is incorrect (%llu),expected"
> +				" %u", attr.sched_deadline, DEADLINE_VAL);
> +		fail++;
> +	}
> +
> +	if (fail)
> +		tst_resm(TFAIL, "attributes were read back incorrectly");
> +	else
> +		tst_resm(TPASS, "attributes were read back correctly");
> +
> +	return NULL;
> +}
> +
> +int main(int argc, char **argv)
> +{
> +	pthread_t thread;
> +
> +	if ((tst_kvercmp(3, 14, 0)) < 0)
> +		tst_brkm(TCONF, NULL, "EDF needs kernel 3.14 or higher\n");
> +
> +	pthread_create(&thread, NULL, run_deadline, NULL);
> +
> +	pthread_join(thread, NULL);
> +
> +	tst_exit();
> +}

Otherwise it looks good.

-- 
Cyril Hrubis
ch...@su...

[LTP] How to run individual C testcase file like ltp/testcases/kernel/containers/pidns/pidns01.c

[Abhishek D. <a10...@li...>]

Hi,

     I am new to LTP and developing a testcase under pidns. I want to 
start with , if there is any way to run , suppose pidns01.c using only 
gcc command. Only using gcc command, it should be possible to run 
pidns01.c as the file contains main program. I am also interested in 
knowing the parameters used to call the file using gcc command.

   Regards,

   ---------------------------------------------------------------------------------------
   Abhishek Dasgupta
   Linux Software Developer - Linux Technology Centre
   IBM Systems Lab,
   IBM India Pvt. Ltd.
   Embassy Golf Link, D Block
   Koramongala - Off Indiranagar Ring Road
   Bangalore - 560 071
   Mobile: +91-8884107981
   ---------------------------------------------------------------------------------------

Re: [LTP] [PATCH] cgroup_fj: fixed exit codes in case of not supported tests

[Cyril H. <ch...@su...>]

Hi!
> @@ -125,8 +125,8 @@ esac
>  ret=$?
>  if [ $ret -eq 0 ]; then
>  	tst_resm TPASS "case$i($CASETYPE$CASECMD)    PASS"
> -elif [ $ret -ne 9 ]; then
> +elif [ $ret -ne 32 ]; then
>  	tst_resm TFAIL "case$i($CASETYPE $CASECMD)    FAIL"
>  fi
>  
> -exit $ret;
> +tst_exit

Unless the whole script is converted to the test.sh the exit $ret must
stay here, otherwise the return status from the test will be always 0.

The rest looks fine.

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] [PATCH] cgroup_fj: renamed arguments because the previous ones were not clear.

[Cyril H. <ch...@su...>]

Hi!
> +''|*[!0-9]*) 
> +	usage
> +	exit_parameter;;
> +    *) ;;
>  esac

I've removed the trailing whitespace at the end of the ''|*[!0-9]*) and
updated the commit message and pushed, thanks.

BTW: The canonical format for the git commit message is:

short commit description <= 50 characters
[empty line]
longer commit description that may span across multiple lines with lines
up to 72 chars long...
[empty line]
Signed-off-by: ...

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] About to cross compile LTP...

[$<ri...@nt...>]

You can cross compile LTP either in chroot environment or with ARM toolchain.

If it is with toolchain, then make sure you are setting them in the
environment before compiling.

configure AR=arm-linux-gnueabi-ar CC=arm-linux-gnueabi-gcc
RANLIB=arm-linux-gnueabi-gcc-ranlib-4.7 STRIP=arm-linux-gnueabi-strip
--host=arm-linux --target=arm-linux CFLAGS="-static" LDFLAGS="-static
-pthread"

On Tue, Sep 22, 2015 at 1:00 PM, kamal p <pka...@gm...> wrote:
> Hi,
>
>    I want to cross compile LTP test suite and test it on my target embedded
> linux system.can I compile like this?.If we can do please tell me the
> procedure ( i.e cross compilation tool & other components required) to
> accomplish these task.
>
> Regards,
> Kamal bhaskar.
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>



-- 
Thanks & Regards,
M.Srikanth Kumar.

[LTP] About to cross compile LTP...

[kamal p <pka...@gm...>]

Hi,

   I want to cross compile LTP test suite and test it on my target embedded
linux system.can I compile like this?.If we can do please tell me the
procedure ( i.e cross compilation tool & other components required) to
accomplish these task.

Regards,
Kamal bhaskar.

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

[Cyril H. <ch...@su...>]

Hi!
> Seems like it's a better and more concise solution. Need I to prepare and send a second version of the PATCH?

Ideally yes, if you send a patch I will apply it right away.

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] ltp: thp04.c test case

[Cyril H. <ch...@su...>]

Hi!
> There was no response for about three months. If nobody stands up and
> fixes the testcase I would go for dropping it since it does not work
> reliably as it is.

And the test has been removed in:

https://github.com/linux-test-project/ltp/commit/19cdd120b43aa6a6a4993b61e6ef675d1cdf04b4

-- 
Cyril Hrubis
ch...@su...

Re: [LTP] Query related to LTP test suite run

[Cyril H. <ch...@su...>]

Hi!
> As I known, inotify06 would make some system crash caused by a known
> kernel bug and the bug has been fixed, you can see this url:
> https://github.com/torvalds/linux/commit/8f2f3eb59dff4ec538de55f2e0592fec85966aab
> 
> If the issue is inotify06, I suggest that you should remove it before
> using runltp script.
> You can just do like:
> rm -rf <path_to_install_ltp>/testcases/bin/inotify06

Right, the inotify06 may crash the kernel if the kernel wasn't fixed.
Even better than removing the binary is to remove the line from the
/opt/ltp/runtest/syscalls file for your testing until you kernel
contains the fix.

-- 
Cyril Hrubis
ch...@su...

[LTP] This list has been moved

[Cyril H. <ch...@su...>]

Hi!
I've just set up auto reply for this list that we have moved to the new
list at lt...@li.... Please do not start a new conversations
here and if you have pending patches please resend them to the new
list.

-- 
Cyril Hrubis
ch...@su...

[LTP] How to enable USB test case while compiling

[Veerendra J. <Vee...@in...>]

Hi,

I am trying to compile LTP test suite by enabling USB in the kernel/device driver/Makefile.

I am getting error.


make[4]: Entering directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb'
make[5]: Entering directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb/tusb'
make[5]: Nothing to be done for `all'.
make[5]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb/tusb'
make[5]: Entering directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb/user_usb'
make -C "/home/veerendra/QA/ltp-full-20150420/testcases/kernel/include" -f "/home/veerendra/QA/ltp-full-20150420/testcases/kernel/include/Makefile" all
make[6]: Entering directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/include'
make[6]: Nothing to be done for `all'.
make[6]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/include'
/home/veerendra/Sourcery_CodeBench_Lite_for_MIPS_GNU_Linux/bin/mips-linux-gnu-gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -g -O2 -Wold-style-definition -D_FORTIFY_SOURCE=2 -I/home/veerendra/QA/ltp-full-20150420/testcases/kernel/include -I../../../../../include -I../../../../../include   -L../../../../../lib  user_tusb.c   -lltp -o user_tusb
user_tusb.c: In function 'tusbopen':
user_tusb.c:66:5: warning: old-style function definition [-Wold-style-definition]
 int tusbopen()
     ^
user_tusb.c:89:4: warning: implicit declaration of function 'unlink' [-Wimplicit-function-declaration]
    rc = unlink(DEVICE_NAME);
    ^
user_tusb.c: In function 'tusbclose':
user_tusb.c:145:5: warning: old-style function definition [-Wold-style-definition]
 int tusbclose()
     ^
user_tusb.c:151:3: warning: implicit declaration of function 'close' [-Wimplicit-function-declaration]
   close(tusb_fd);
   ^
user_tusb.c: In function 'main':
user_tusb.c:158:5: warning: old-style function definition [-Wold-style-definition]
 int main()
     ^
user_tusb.c:208:2: warning: implicit declaration of function 'tst_exit' [-Wimplicit-function-declaration]
  tst_exit();
  ^
user_tusb.c:209:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
user_tusb.c: In function 'tusbopen':
user_tusb.c:88:11: warning: 'st.st_mode' is used uninitialized in this function [-Wuninitialized]
   if (!(st.st_mode & S_IFDIR)) {
           ^
../../../../../lib/libltp.a(tst_res.o): In function `cat_file':
/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:786: undefined reference to `TCID'
/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:786: undefined reference to `TCID'
/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:796: undefined reference to `TCID'
/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:796: undefined reference to `TCID'
/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:804: undefined reference to `TCID'
../../../../../lib/libltp.a(tst_res.o):/home/veerendra/QA/ltp-full-20150420/lib/tst_res.c:804: more undefined references to `TCID' follow
collect2: error: ld returned 1 exit status
make[5]: *** [user_tusb] Error 1
make[5]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb/user_usb'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers/usb'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel/device-drivers'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases/kernel'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/veerendra/QA/ltp-full-20150420/testcases'
make: *** [testcases-all] Error 2


Any suggestions


Regards

Veerendra

[LTP] settimeofday01:TFAIL in Kernel 4.2.0

[Takeshi M. <jea...@ic...>]

This is a my first mail to LTP mailing list.

I'm testing Linux Kernel 4.2.0 by LTP. I saw a following Error.
-----
settimeofday01    1  TFAIL  :  settimeofday01.c:98: Error Setting Time, 
errno=22
settimeofday01    2  TFAIL  :  settimeofday01.c:120: Test condition 1 failed
settimeofday01    3  TPASS  :  Test condition 2 successful
-----

In commit of Linux Kernel:
e1d7ba8735551ed79c7a0463a042353574b96da3 "time: Always make sure 
wall_to_monotonic isn't positive"
add a new check to do_settimeofday64().

This commit said:
"As a result one can't set the CLOCK_REALTIME time prior to (1970 + 
system uptime)."

In settimeofday01 test case, parameter of first settimeofday() is 
100s100μs. A lot of cases, TEST_RETURN is -1.

I'd better to modify settimeofday01 test case.

To meet that requirement, I made following changes.(I have less 
confidence that it is correct...)
-----
diff --git a/testcases/kernel/syscalls/settimeofday/settimeofday01.c 
b/testcases/kernel/syscalls/settimeofday
index b598800..a6894fb 100644
--- a/testcases/kernel/syscalls/settimeofday/settimeofday01.c
+++ b/testcases/kernel/syscalls/settimeofday/settimeofday01.c
@@ -88,9 +88,10 @@ int main(int argc, char **argv)
               int condition_number = 1;
               /* reset tst_count in case we are looping */
               tst_count = 0;
-
-               tp.tv_sec = VAL_SEC;
-               tp.tv_usec = VAL_MSEC;
+
+               gettimeofday(&tp, NULL);
+               tp.tv_sec += VAL_SEC;
+               tp.tv_usec += VAL_MSEC;

               TEST(settimeofday(&tp, NULL));
               if (TEST_RETURN == -1) {
----

Result:
settimeofday01    1  TPASS  :  Test condition 1 successful
settimeofday01    2  TPASS  :  Test condition 2 successful

Thanks.

Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

[Yuriy K. <Yur...@sy...>]

Hi Cyril,

Seems like it's a better and more concise solution. Need I to prepare and send a second version of the PATCH?

Regards,
Yuriy Kolerov


-----Original Message-----
From: Cyril Hrubis [mailto:ch...@su...] 
Sent: Tuesday, September 08, 2015 2:58 PM
To: Yuriy Kolerov
Cc: ltp...@li...; Ant...@sy...; Fra...@sy...
Subject: Re: [LTP] [PATCH] Enable including config.mk and features.mk for *clean targets

Hi!
> It's necessary for correct cleaning. E.g. open_posix_testsuite is not 
> cleaned without including these .mk files. However it's not an error 
> if these files does not exist while cleaning.
> 
> Signed-off-by: Yuriy Kolerov <yur...@sy...>
> ---
>  include/mk/env_pre.mk | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

> diff --git a/include/mk/env_pre.mk b/include/mk/env_pre.mk index 
> f1584a8..a6beb5b 100644
> --- a/include/mk/env_pre.mk
> +++ b/include/mk/env_pre.mk
> @@ -94,11 +94,18 @@ ifeq ($(srcdir),)
>  srcdir				:= .
>  endif
>  
> -# autotools, *clean, and help don't require config.mk, features.mk, etc...
> -ifeq ($(filter autotools %clean .gitignore gitignore.% 
> help,$(MAKECMDGOALS)),)
> +# autotools and help don't require config.mk, features.mk, etc...
> +ifeq ($(filter autotools .gitignore gitignore.% 
> +help,$(MAKECMDGOALS)),)
>  
> +# If config.mk and features.mk does not exist it's not an error for 
> +*clean # targets.
> +ifeq ($(filter %clean,$(MAKECMDGOALS)),)
>  include $(abs_top_builddir)/include/mk/config.mk
>  include $(abs_top_builddir)/include/mk/features.mk
> +else
> +-include $(abs_top_builddir)/include/mk/config.mk
> +-include $(abs_top_builddir)/include/mk/features.mk
> +endif

Hmm, besides including the config.mk this also enables the out-of-tree build checks and make 3.80 compatibility targets. Not that it's apriory wrong but I would rather be more conservative and only include the config.mk and features.mk.

One option would be to add the:

-include $(abs_top_builddir)/include/mk/config.mk
-include $(abs_top_builddir)/include/mk/features.mk

before the ifeq that filters out the autotools, clean, etc. targets.
What do you think?

--
Cyril Hrubis
ch...@su...

[LTP] [PATCH] cgroup_fj: fixed exit codes in case of not supported tests

[Cedric H. <ch...@su...>]

Signed-off-by: Cedric Hnyda <ch...@su...>

Updated
---
 .../controllers/cgroup_fj/cgroup_fj_function.sh    |  12 +--
 .../controllers/cgroup_fj/cgroup_fj_function2.sh   |   2 +-
 .../controllers/cgroup_fj/cgroup_fj_stress.sh      |   2 +-
 .../controllers/cgroup_fj/cgroup_fj_utility.sh     | 103 +++++++++++----------
 .../controllers/cgroup_fj/run_cgroup_test_fj.sh    |   4 +-
 5 files changed, 62 insertions(+), 61 deletions(-)

diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function.sh
index 2202708..546cc87 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function.sh
@@ -38,7 +38,7 @@ release_agent_para_str="";
 notify_on_release_str="";
 release_agent_str="";
 
-expectted=1;
+expected=1;
 
 # Create some processes and move them to cgroups
 pid=0;
@@ -127,7 +127,7 @@ export TMPFILE=$TESTROOT/tmp_tasks
 
 ##########################  main   #######################
 if [ "$#" -ne "9" ]; then
-	echo "ERROR: Wrong inputed parameter..Exiting test";
+	echo "ERROR: Wrong input parameters... Exiting test";
 	usage;
 	exit -1;
 fi
@@ -210,17 +210,17 @@ esac
 # echo notify_on_release that analysed from parameter
 case $notify_on_release in
 "1"|"2"|"3")
-	expectted=1
+	expected=1
 	;;
 *)
-	expectted=0
+	expected=0
 	;;
 esac
 
 #if [ $notify_on_release -ne 0 ] && [ $notify_on_release -ne 1 ] && [ $notify_on_release -ne 2 ];then
-#	expectted=0
+#	expected=0
 #fi
-do_echo 1 $expectted $notify_on_release_str /dev/cgroup/subgroup_1/notify_on_release;
+do_echo 1 $expected $notify_on_release_str /dev/cgroup/subgroup_1/notify_on_release;
 
 # echo release_agent that analysed from parameter
 if [ $release_agent_echo -ne 1 ]; then
diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function2.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function2.sh
index 57d131d..aa81143 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function2.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_function2.sh
@@ -45,7 +45,7 @@ usage()
 
 exit_parameter()
 {
-	echo "ERROR: Wrong inputed parameter..Exiting test"
+	echo "ERROR: Wrong input parametes... Exiting test"
 	exit -1;
 }
 
diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
index fd9fa2a..b53f455 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_stress.sh
@@ -76,7 +76,7 @@ usage()
 
 exit_parameter()
 {
-	echo "ERROR: Wrong inputed parameter..Exiting test"
+	echo "ERROR: Wrong input parameters... Exiting test"
 	exit -1;
 }
 
diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_utility.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_utility.sh
index 75c0dcb..8f00b85 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_utility.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_utility.sh
@@ -45,7 +45,8 @@ exist_subsystem()
 
 	exist=`grep -w $checksubsystem /proc/cgroups | cut -f1`;
 	if [ "$exist" = "" ]; then
-		exit 9
+		tst_brkm TCONF NULL "Subsystem $subsystem not supported"
+		exit 32
 	fi
 }
 
@@ -220,7 +221,7 @@ get_release_agent()
 }
 
 # check the exit status, and exit or echo info.
-# exit status	expectted value	echo info	exit or not
+# exit status	expected value	echo info	exit or not
 # 0		0		no		no
 # 0		1		yes	yes
 # not 0	0		yes	yes
@@ -233,20 +234,20 @@ do_exit()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	exit_status=$3
 
 	if [ $exit_status -eq 0 ] ;then
-		if [ $expectted -lt 1 ]; then
-			echo "								against with expectted"
+		if [ $expected -lt 1 ]; then
+			echo "								against with expected"
 			if [ $exit_here -ge 1 ]; then
 				cleanup;
 				exit -1
 			fi
 		fi
 	else
-		if [ $expectted -ge 1 ]; then
-			echo "								against with expectted"
+		if [ $expected -ge 1 ]; then
+			echo "								against with expected"
 			if [ $exit_here -ge 1 ]; then
 				cleanup;
 				exit -1
@@ -268,20 +269,20 @@ do_echo()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	value=$3
 	target=$4
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"echo $value > $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"echo $value > $target\" (expected: success)"
 		else
-			echo "\"echo $value > $target\" (expectted: fail)"
+			echo "\"echo $value > $target\" (expected: fail)"
 		fi
 	fi
 
 	`echo $value > $target`
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_mkdir()
@@ -292,7 +293,7 @@ do_mkdir()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	target=$3
 	parents=0
 	if [ "$#" -eq "4" ] && [ "$4" -ne 0 ]; then
@@ -300,10 +301,10 @@ do_mkdir()
 	fi
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"mkdir $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"mkdir $target\" (expected: success)"
 		else
-			echo "\"mkdir $target\" (expectted: fail)"
+			echo "\"mkdir $target\" (expected: fail)"
 		fi
 	fi
 
@@ -316,7 +317,7 @@ do_mkdir()
 	else
 		mkdir -p $target
 	fi
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_rmdir()
@@ -327,7 +328,7 @@ do_rmdir()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	target=$3
 
 	if ! [ -e $target ]; then
@@ -336,15 +337,15 @@ do_rmdir()
 	fi
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"rmdir $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"rmdir $target\" (expected: success)"
 		else
-			echo "\"rmdir $target\" (expectted: fail)"
+			echo "\"rmdir $target\" (expected: fail)"
 		fi
 	fi
 
 	rmdir $3 $4 $5
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_mount()
@@ -355,7 +356,7 @@ do_mount()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	para_o=$3
 	target=$4
 	something="cgroup"
@@ -364,15 +365,15 @@ do_mount()
 	fi
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"mount -t cgroup $para_o $something $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"mount -t cgroup $para_o $something $target\" (expected: success)"
 		else
-			echo "\"mount -t cgroup $para_o $something $target\" (expectted: fail)"
+			echo "\"mount -t cgroup $para_o $something $target\" (expected: fail)"
 		fi
 	fi
 
 	mount -t cgroup $para_o $something $target
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_umount()
@@ -383,54 +384,54 @@ do_umount()
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	target=$3
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"umount $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"umount $target\" (expected: success)"
 		else
-			echo "\"umount $target\" (expectted: fail)"
+			echo "\"umount $target\" (expected: fail)"
 		fi
 	fi
 
 	umount $target
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_mv()
 {
 	if [ "$#" -ne "4" ]; then
-		echo "ERROR: mv failed,your parameter is wrong..Exiting test"
+		echo "ERROR: mv failed,your parameter is wrong... Exiting test"
 		exit -1
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	source=$3
 	target=$4
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"mv $source $target\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"mv $source $target\" (expected: success)"
 		else
-			echo "\"mv $source $target\" (expectted: fail)"
+			echo "\"mv $source $target\" (expected: fail)"
 		fi
 	fi
 
 	mv $source $target
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 do_kill()
 {
 	if [ "$#" -ne "4" ]; then
-		echo "ERROR: kill failed,your parameter is wrong..Exiting test"
+		echo "ERROR: kill failed,your parameter is wrong... Exiting test"
 		exit -1
 	fi
 
 	exit_here=$1
-	expectted=$2
+	expected=$2
 	signo=$3
 	pid=$4
 
@@ -439,15 +440,15 @@ do_kill()
 	fi
 
 	if [ $no_debug -ne 1 ]; then
-		if [ $expectted -ge 1 ]; then
-			echo "\"kill -$signo $pid\" (expectted: success)"
+		if [ $expected -ge 1 ]; then
+			echo "\"kill -$signo $pid\" (expected: success)"
 		else
-			echo "\"kill -$signo $pid\" (expectted: fail)"
+			echo "\"kill -$signo $pid\" (expected: fail)"
 		fi
 	fi
 
 	kill -s $signo $pid
-	do_exit $exit_here $expectted $?;
+	do_exit $exit_here $expected $?;
 }
 
 setup()
@@ -464,7 +465,7 @@ setup()
 		cp -f $TESTROOT/cgroup_fj_release_agent /root
 		chmod a+x /root/cgroup_fj_release_agent
 	else
-		echo "ERROR: $TESTROOT/cgroup_fj_release_agent isn't exist..Exiting test"
+		echo "ERROR: $TESTROOT/cgroup_fj_release_agent doesn't exist... Exiting test"
 		exit -1;
 	fi
 
@@ -476,7 +477,7 @@ setup()
 	then
 		chmod a+x $TESTROOT/cgroup_fj_proc
 	else
-		echo "ERROR: $TESTROOT/cgroup_fj_proc isn't exist..Exiting test"
+		echo "ERROR: $TESTROOT/cgroup_fj_proc doesn't exist... Exiting test"
 		exit -1;
 	fi
 }
@@ -547,7 +548,7 @@ reclaim_foundling()
 mkdir_subgroup()
 {
 	if ! [ -e /dev/cgroup ]; then
-		echo "ERROR: /dev/cgroup isn't exist..Exiting test"
+		echo "ERROR: /dev/cgroup doesn't exist... Exiting test"
 		exit -1;
 	fi
 
@@ -556,10 +557,10 @@ mkdir_subgroup()
 
 mount_cgroup ()
 {
-	expectted=1
+	expected=1
 	PARAMETER_O="";
 	if [ "$subsystem" == "abc" ]; then
-		expectted=0
+		expected=0
 	fi
 	if [ "$subsystem" != "" ]; then
 		PARAMETER_O="$subsystem"
@@ -593,7 +594,7 @@ mount_cgroup ()
 		PARAMETER_O="-o""$PARAMETER_O"
 	fi
 
-	do_mount 1 $expectted "$PARAMETER_O" /dev/cgroup
+	do_mount 1 $expected "$PARAMETER_O" /dev/cgroup
 }
 
 check_para()
@@ -613,7 +614,7 @@ check_para()
 
 	if [ $ret1 -ne 0 ] || [ $ret2 -ne 0 ] || [ $ret3 -ne 0 ] || [ $ret4 -ne 0 ] || [ $ret5 -ne 0 ] || [ $ret6 -ne 0 ]
 	then
-		echo "ERROR: Wrong inputed parameter..Exiting test"
+		echo "ERROR: Wrong input parameters..Exiting test"
 		return -1
 	fi
 
diff --git a/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh b/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
index c8e698b..1d1598e 100755
--- a/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
+++ b/testcases/kernel/controllers/cgroup_fj/run_cgroup_test_fj.sh
@@ -125,8 +125,8 @@ esac
 ret=$?
 if [ $ret -eq 0 ]; then
 	tst_resm TPASS "case$i($CASETYPE$CASECMD)    PASS"
-elif [ $ret -ne 9 ]; then
+elif [ $ret -ne 32 ]; then
 	tst_resm TFAIL "case$i($CASETYPE $CASECMD)    FAIL"
 fi
 
-exit $ret;
+tst_exit
-- 
2.1.4