#129 acct01 test flawed, some test case bugs

System Calls
closed-fixed
nobody
Testcases (113)
5
2007-09-03
2007-08-29
No

The acct01 test failed on an embedded target board because the board has no /dev/tty/1, and as such, the test got ENOENT rather than EACCES.

I propose that the test case be amended to use /dev/null, eliminating the S390 #ifdefs.

Also, while debugging this, I noticed that the format strings for some of the error cases appeared to be invalid, and the test logic seemed, at best, gratuitously complicated. I believe the revised code to be correct, and I have had two other people review it just to be sure. :)

Discussion

  • Peter Seebach

    Peter Seebach - 2007-08-29

    proposed patch

     
  • Subrata Modak

    Subrata Modak - 2007-08-30

    Logged In: YES
    user_id=1737361
    Originator: NO

    Will verify and let you know soon.
    --Subrata

     
  • Subrata Modak

    Subrata Modak - 2007-08-30
    • status: open --> open-accepted
     
  • Subrata Modak

    Subrata Modak - 2007-09-03

    Logged In: YES
    user_id=1737361
    Originator: NO

    This is applied to.
    --Subrata

     
  • Subrata Modak

    Subrata Modak - 2007-09-03
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks