From: Keith O. <ka...@sg...> - 2006-01-12 07:50:57
|
"Paul E. McKenney" (on Wed, 11 Jan 2006 22:51:15 -0800) wrote: >On Thu, Jan 12, 2006 at 05:19:01PM +1100, Keith Owens wrote: >> OK, I have thought about it and ... >> >> notifier_call_chain_lockfree() must be called with preempt disabled. >> >Fair enough! A comment, perhaps? In a former life I would have also >demanded debug code to verify that preemption/interrupts/whatever were >actually disabled, given the very subtle nature of any resulting bugs... Comment - OK. Debug code is not required, the reference to smp_processor_id() already does all the debug checks that notifier_call_chain_lockfree() needs. CONFIG_PREEMPT_DEBUG is your friend. |