From: Martin J. B. <mb...@ar...> - 2004-02-27 00:04:54
|
> On Thu, 2004-02-26 at 14:21, Martin J. Bligh wrote: >> Also, I seem to recall those build_zonelists functions are used for both >> NUMA and UMA ... now they're getting complex enough that it's probably >> worth making a specific non-NUMA version, if only for the sanity of >> 99% of the poor souls trying to work out how a UMA machine lays it out ;-) >> >> It looks like it won't change ordering for existing boxes with single >> layer flat NUMA topologies (round-robin), but we probably ought to check >> that carefully ;-) > > More ifdefs just make the code messier. How about adding a nice comment > explaining that UMA will fall right through the loop, and giving the > poor souls a temporary reprieve? In this case, I disagree - it's better to just have the ifdef. M. |