[Lse-tech] Re: Fw: Re: Linux 2.6.3-mm1 compilation problem on AMD64

[Matthew D. <col...@us...>]

On Wed, 2004-02-18 at 11:55, Andrew Morton wrote:
> Andi Kleen <ak...@mu...> wrote:
> >
> > > > Andi, I can't see your definition of pfn_to_nid anywhere in the source
> > > > right now ... do you really get away without it completely?
> > > > 
> > > 
> > > Guys, I'll just drop the patch.
> > 
> > If there's a good reason I can add pfn_to_nid. It's easy with phys_to_nid() 
> 
> I'm currently fairly bored with fixing other people's stuff.  Please resend
> when it's fixed up, thanks.

Andrew, I didn't notice that you pushed my nodezone patch into
mainline.  That patch makes this whole issue much easier to resolve.

If you notice in the comments for the page_to_nid() function in the
broken patch I mention there's got to be an easier way to turn a struct
page into a node number.  There is, and it's now in mainline.  Now, all
we have to do is bitshift the page->flags field to get the number of the
node the page belongs to.  Super simple *and* arch independent.  This
patch works for me, and is nothing more than s/page_to_nid/page_nodenum.

Would x86-64 & ia64 folks take the patch for a quick spin.  It should
work, as there's no more arch dependent ugliness, but never say never,
right?

-Matt