#9 lsdvd -Ox produces invalid xml

v1.0 (example)
accepted
nobody
None
5
2014-09-30
2012-08-28
No

When lsdvd is used in XML mode, it does not escape XML characters.

For example, the contents of <lsdvd><track><df> may be "P&S + Letter", but should be "P&amp;S + Letter".

Due to this bug, most XML parsers refuse to read the produced XML.

Discussion

  • Steve Dibb

    Steve Dibb - 2014-09-25

    I'm wondering if we want to change the string to "Pan and Scan" to make parsing easier for everyone involved (regardless of language).

    What do you think, Petter?

     
  • Steve Dibb

    Steve Dibb - 2014-09-25
    • status: open --> accepted
    • Group: --> v1.0 (example)
     
    • Petter Reinholdtsen

      [Steve Dibb]

      I'm wondering if we want to change the string to "Pan and Scan" to
      make parsing easier for everyone involved (regardless of language).

      What do you think, Petter?

      I am not sure. Will have to think about it a bit more.

      Happy hacking
      Petter Reinholdtsen

       
  • Richard Körber

    Richard Körber - 2014-09-26

    You should still consider proper escaping of XML output, as e.g. the DVD title may also contain "&" and other characters that need escaping.

     
  • Steve Dibb

    Steve Dibb - 2014-09-30

    It occurs to me that either way, we're going to break backwards compat by now properly escaping XML ... might as well fix the display format string while we're at it.

     

Log in to post a comment.