Re: [Lprof-devel] Lprof QT4 Mac build

[Hal V. E. <hv...@as...>]

On Monday 21 January 2008 11:26:58 Hal V. Engel wrote:
> On Monday 21 January 2008 01:10:42 Mark Munte wrote:
snip
> >
> > > The OUTPUT_PROFILE value in the user configuration is set to whatever
> > > the "Input Profile" combo box is set to when LProf is closed if you
> > > have used
> > > the Proof function.  If this is set to SPR200 Super... and this is
> > > removed it
> > > could cause a problem.  This is something that I don't think I have
> > > tested
> > > for so this could be an "undiscovered" bug in the code.  I just
> > > tested this
> > > on Linux (IE. renamed the file I had used in the Proof function) and
> > > then
> > > restarted LProf and it failed.  So this is a bug and I will get a
> > > fix in soon
> > > probably later today..
>
> I got side tracked and have not located where this is happing yet.  I will
> try to get this fixed today.

This is now fixed.  

snip
> > I was able to "produce" another Lprof crash: under Camera/Scanner
> > Profiler click the Select Directory button, then hit Cancel on the
> > dialog displaying folders, then try do do something else like loading
> > an image or selecting the reference file from the drop down: Lprof
> > crashes.
>
> This does not happen on Linux.  But I remember fixing something like this
> before and it is in the bug tracker so I will track down the bug report and
> see if I can find what I did to see if it might be related.  I will also
> test this on Windows when I get around to doing Windows testing.
>
> > Some other minor things I noted quickly going through the Lprof screens:
> > 1) under Camera/Scanner Profile Parameters dialog -> general: the
> > contents of the CLUT Resolution panel are very tightly spaced
>
> I don't see this on Linux.

Might be fixed in CVS but I can't be sure because this does not happen on 
Linux.  But I made some adjustments and it could be better.

>
> > 2) under Camera/Scanner Profile Parameters dialog -> White point
> > handling: the Location panel is not rescaling with the screen and the
> > contents are a bit mis-aligned
>
> Yes I know.  This is a layout issue and I was not able to get this working
> the way I wanted it to and I had other things that were more critical so I
> moved on.  But it does need to be fixed.

This is now fixed in CVS.
>
> > 3) under Camera/Scanner Profiler main screen: the Select Directory and
> > Load Image buttons have a different look as all the other buttons:
> > they are squared, all other buttons are rounded (the OS X default look)
>
> I can see a slight difference on linux but it is mostly that these two are
> slightly lighter in color (so much so that it was easy to miss).  I will
> have a look at this.

This might have been caused by these buttons being different types.  Most of 
the buttons were QPushButton and the ones that looked different were 
QToolButton.  I have now changed these to QPushButton and these may now look 
the same.

>
> > 4) under Monitor Profiler main screen: perhaps "Monitor" should be
> > renamed to "Display" as some other screens use the word Display.... or
> > the other way around...
>
> Yes I agree.

This has been fixed.  But I have not updated the help files to match.

>
> > 5) under Display Profile Parameters dialog: the CLUT Resolution and
> > Profile verbosity panels are very tightly spaced (as with point 1)
>
> Again I am not seeing this on Linux.

Like #1 I made some adjustments but I don't know if this will fix it.  Please 
test.

>
> > 6) under Monitor Profiler main screen -> build coarse profile -
> > Monitor values dialog: the "OK", "Help" and "Set Gamma and Black
> > Point" buttons are squared (as with 3)
>
> Again on Linux this does not show up.  But the forms do need at least some
> work so I will have a look to see if I can figure out why these are
> different since it appears that some setting is likely different and this
> is affecting OS/X but not X11.

I can't explain this.  These buttons are exactly like the QPushButtons in the 
main dialog.  But the Cancel button had one setting that was different so I 
changed it to match.  So at least all of the buttons on this dialog should 
look the same.

>
> > 7) under Monitor Profiler main screen-> build accurate profile from
> > measurements: both "Select Directory" buttons are squared (as with 3, 6)
>
> These are created as part of the custom widgets in qtlcmswidgets.cpp.  I
> will look at the code to see if perhaps I need to change how these buttons
> are setup to make them more consistant with the rest of the interface.  
> This also applies to the "Select Directory" button issue in #3.

Changed the widgets from QToolButton to QPushButton so this may be better now.

>
> > 8) under Monitor Profiler main screen-> build accurate profile from
> > measurements -> Calibrate and Measure: the dialog that opens has no
> > title

This is now fixed.  Another issue with this wizard is the in Qt4 each page of 
the wizard says "Page" right below the window title.  I have not figured out 
how to change this at least in deigner.  But I suspect that this can be 
changed in the code.  So I will look into it.   

>
> The forms needed a lot of work after conversion from Qt3 to Qt4.  Things
> like layouts and the look of things was very messed up on some of the forms
> and I needed to touch almost everything.  But other forms did not need as
> much work and it appears that many of the above are for widgets that I did
> not touch as part of cleaning up the conversion since they looked OK on
> Linux.  So this will likely need more work to get everything looking good
> on all of our platforms.  For this stage of the conversion these are really
> minor issues since they don't affect actual functionality.  But I should
> have these fixed in the next few days.
>
> This is the kind of detailed feedback I was hoping for.  I should be able
> to have these sorted out fairly quickly and as these are fixed it will make
> the app look better.  So thanks.

Hal