#41 Filters invoked with -h and -H set same

[Paul Szabo]

I noticed that filters are invoked with options -h and -H set same:
-H ($H) is the host as set in the control file, while -h ($h) should
be the connecting host.

My proposed patch (against 3.8.B-6 in Debian sources) below.

This seems a minor bug, certainly un-important in my use of LPRng.

Cheers, Paul

Paul Szabo psz@maths.usyd.edu.au www.maths.usyd.edu.au/u/psz
School of Mathematics and Statistics University of Sydney Australia

[Peter Radisson]

Hello,
thanks for the patch, seems ok. The only problem i can imagine for now
is that this bug was there for a long time, so some people may depend on
this (aka never noticed), so i will think out it over the weekend.

NTL: how did you notice, what was your usecase ?

Am 15.03.24 um 03:34 schrieb Paul Szabo:

---

[bugs:#41] Filters invoked with -h and -H set same

Status: open
Group: v1.0 (example)
Created: Fri Mar 15, 2024 02:34 AM UTC by Paul Szabo
Last Updated: Fri Mar 15, 2024 02:34 AM UTC
Owner: nobody
Attachments:

• psz.patch (sourceforge.net) (680 Bytes; text/x-patch)

I noticed that filters are invoked with options -h and -H set same:
-H ($H) is the host as set in the control file, while -h ($h) should
be the connecting host.

My proposed patch (against 3.8.B-6 in Debian sources) below.

This seems a minor bug, certainly un-important in my use of LPRng.

Cheers, Paul

Paul Szabo psz@maths.usyd.edu.au www.maths.usyd.edu.au/u/psz
School of Mathematics and Statistics University of Sydney Australia

---

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/lprng/bugs/41/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/

[Paul Szabo]

Dear Peter,

How did I notice. Have been merrily using LPRng for many years (my last
patches seem to have been in 1998). Mostly my users print single copies,
in fact printing multiple was discouraged, in a desire to save paper,
with copies ignored in my LPR front-end wrapper script. But then, a user
asked about printing multiple, that did not work though my LPR wrapper
was not involved. The essence of the bug was in the way CUPS sends to
LPD, see
https://bugs.debian.org/1065157
While looking into those copies, looking at some debug output from my
:if=ifilter: script, I noticed the oddity with the hostnames. Again,
CUPS (also) was wrong, see
https://bugs.debian.org/1067122

Cheers, Paul

On 22/03/2024 04.54, Peter Radisson wrote:

Hello,
thanks for the patch, seems ok. The only problem i can imagine for now
is that this bug was there for a long time, so some people may depend on
this (aka never noticed), so i will think out it over the weekend.

NTL: how did you notice, what was your usecase ?

Paul Szabo wrote:

[bugs:#41] https://sourceforge.net/p/lprng/bugs/41/ Filters invoked with -h and -H set same

psz.patch https://sourceforge.net/p/lprng/bugs/41/attachment/psz.patch

I noticed that filters are invoked with options -h and -H set same:
-H ($H) is the host as set in the control file, while -h ($h) should
be the connecting host.

My proposed patch (against 3.8.B-6 in Debian sources) below.

This seems a minor bug, certainly un-important in my use of LPRng.

Cheers, Paul

--
Paul Szabo psz@maths.usyd.edu.au www.maths.usyd.edu.au/u/psz
School of Mathematics and Statistics University of Sydney Australia

[Paul Szabo]

Dear Peter,

How did I notice. Have been merrily using LPRng for many years (my last
patches seem to have been in 1998). Mostly my users print single copies,
in fact printing multiple was discouraged, in a desire to save paper,
with copies ignored in my LPR front-end wrapper script. But then, a user
asked about printing multiple, that did not work though my LPR wrapper
was not involved. The essence of the bug was in the way CUPS sends to
LPD, see
https://bugs.debian.org/1065157
While looking into those copies, looking at some debug output from my
:if=ifilter: script, I noticed the oddity with the hostnames. Again,
CUPS (also) was wrong, see
https://bugs.debian.org/1067122

Cheers, Paul