Re: [Log4sh-users] rollingfileappender maxfilesize unit bug

[Kate W. <kat...@fo...>]

Steve -

Thanks for pointing the bug out. It is fixed in the following revisions:
1.4 - r529
1.5 - r530

Regarding the space in the unit, I am expecting that if a space needs to be
between the value and the unit, that the value+unit together are passed in
with surrounding quotes, e.g. "1 KiB". The only time I expect spaces to be
used is when log4sh is configured from a properties file, and the value is
properly passed to this function with surrounding quotes (see line# 3247 in
1.4).

- kate

On 4/16/07, Steve Etchelecu <set...@gm...> wrote:
>
> Version 1.4.0
>
> Line 1987 requires that the units indicator be either 2 or 3 chars long.
> This precludes the 'B' (byte) unit.
>
> Also line 1987 seems to imply support for whitespace between the value and
> the units but lines 1976 and 1982 don't allow this.
>
>   1974  appender_file_setMaxFileSize()
>   1975  {
>   1976    if [ $# -ne 2 ]; then
>   1977      _log4sh_error "appender_file_setMaxFileSize(): invalid number
> of parameters ($#)"
>   1978      return ${__LOG4SH_FALSE}
>   1979    fi
>   1980
>   1981    afsmfs_appender=$1
>   1982    afsmfs_size=$2
>   1983    __log4sh_return=${__LOG4SH_TRUE}
>   1984
>   1985    # split the file size into parts
>   1986    afsmfs_value=`expr ${afsmfs_size} : '\([0-9]*\)'`
>   1987    afsmfs_unit=`expr ${afsmfs_size} : '[0-9]*
> *\([A-Za-z]\{2,3\}\)'`
>
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> log4sh-users mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4sh-users
>
>


-- 
Kate Ward <kat...@fo...>