Re: [log4perl-devel] Re: logdie / logcroak

[<msc...@ao...>]

In a message dated Wed, 28 Aug 2002 1:47:59 AM Eastern Standard Time, er...@se... writes:

>Here ya go.

Applied! It's checked into CVS now and will be part of the 0.23 release. Nice work, thanks Erik!

>An interesting question is, assuming that OFF does turn even FATAL off, 
>is what the behavior of logdie / logcroak / logconfess should be.
>
>Should they still die, just not log anything? Or should logging OFF 
>suppress the death as well?
>
>My own $0.02 would be that the default behaviour would be that they 
>still die, as the behavior is really log->fatal && die.

Good question. I don't think we've made up our minds yet on what log->fatal should actually return -- one solution might be to have it return true if it logs something and false if it doesn't. In any case, until this is resolved,

    log->fatal && die

would die randomly, depending on what log->fatal returns. But in this case, if "OFF" does indeed turn of fatal(), die() wouldn't be executed. Tough one.

I think logdie($msg) should actually be more like

    log->fatal($msg); die $msg;

because in most cases this will be called in desperate situations when all you want to do is get out, no matter what the log settings are.

So, if it turns out indeed that OFF overrules FATAL, we need to make sure your logdie/warn functions still do the right thing.

-- 
-- Mike
Mike Schilli
log...@pe...