log4perl-devel — Ongoing log4perl development

Re: [log4perl-devel] Rotating log files

[<Msc...@ao...>]

In a message dated 9/25/02 4:21:35 PM Pacific Daylight Time, 
mar...@ed... writes:


> I'll have a little look at Log::Dispatch and some of its sub-classes to
> see how it works.
> 

Also, the Java implementation shows some interesting ideas:

    
http://jakarta.apache.org/log4j/docs/api/org/apache/log4j/RollingFileAppender.

html

Not that I'm implying you should provide the same interface, though :)

-- Mike

Mike Schilli
log...@pe...
http://perlmeister.com
http://log4perl.sourceforge.net

Re: [log4perl-devel] Rotating log files

[Dave R. <au...@ur...>]

On Thu, 26 Sep 2002, Pfeiffer, Mark (EDS) wrote:

>   > Nope, there isn't.  But of course some could write one and put it on CPAN
>   > ;)
>   >
> I'm not adverse to writing some Perl... If that is what your implying. I
> havn't had a good look at the code yet but I am sure I could help out.

That was what I was getting at.

> I'll have a little look at Log::Dispatch and some of its sub-classes to
> see how it works.

Writing a new Log::Dispatch output object is trivially simple.  Most of
the outputs are about 100 lines of code or less (not including docs).


-dave

/*==================
www.urth.org
we await the New Sun
==================*/

Re: [log4perl-devel] Rotating log files

[Pfeiffer, M. (EDS) <mar...@ed...>]

On Wed, 25 Sep 2002 11:11:50 EST Dave Rolsky's good news was:
  > On Wed, 25 Sep 2002 Msc...@ao... wrote:
  > 
  > > Actually, the Log::Dispatch appender should take care of that. There should
  > > be something like Log::Dispatch::FileRotate, but -- just checked -- there
  > > isn't.
  > > Dave, is there an appender that rotates logfiles similar to the rotating file
  > > appenders of the Java world?
  > 
  > Nope, there isn't.  But of course some could write one and put it on CPAN
  > ;)
  > 
I'm not adverse to writing some Perl... If that is what your implying. I
havn't had a good look at the code yet but I am sure I could help out.

I'll have a little look at Log::Dispatch and some of its sub-classes to
see how it works.

cheers
mark
__
Mark Pfeiffer <ma...@ml...>

[Fwd: Re: Fwd: [log4perl-devel] log4perl bug when using Log::Dispatch::ApacheLog appender]

[Kevin G. <ke...@go...>]

(forwarding to davis mcpherson this time)

 > i dont think setting to 'debug' will work properly as the apache logging
 > code really needs to know the correct level of the log message and this
 > is indicated by the method called...

I didn't see the original post so forgive me if I'm missing the point,
but if the only thing ApacheLog needs to know the log level for is to
decide whether or not to log the statement (and from reading the docs I
think that's right) then you should be able to turn the Apache logging
level all the way up, open that valve completely as it were, because the
decision whether or not to log is now being made by log4perl.  We've put
another valve on the pipe before the ApacheLog valve.

Basically you're not controlling the logging from the apache config
anymore, you're controlling it from the log4perl config.

However, if ApacheLog is doing something else with the level, like
making it part of the error message or doing different routing for
different levels, then that's a horse of a different color.  For
instance, the current problem with using Log::Dispatch::DBI is that it
does something like
	INSERT INTO logtable (level, msg) values (?,?)
but the level that Log::Dispatch::DBI gets from Log4perl is always
'debug', so it's less than  helpful.


 > i'm certainly not at expert in this area but it seems logging with the
 > Log::Dispatch::ApacheLog is a unique case (certainly more complex than
 > SCREEN, FILE, EMAIL, etc....do

Pardon my dumb question, but how is ApacheLog different?  To log or not
to log, that is the question, but it's decided by Log4perl before
ApacheLog ever even hears about it.


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: Fwd: [log4perl-devel] log4perl bug when using Log::Dispatch::ApacheLog appender

[Kevin G. <ke...@go...>]

> i dont think setting to 'debug' will work properly as the apache logging
> code really needs to know the correct level of the log message and this
> is indicated by the method called...

I didn't see the original post so forgive me if I'm missing the point, 
but if the only thing ApacheLog needs to know the log level for is to 
decide whether or not to log the statement (and from reading the docs I 
think that's right) then you should be able to turn the Apache logging 
level all the way up, open that valve completely as it were, because the 
decision whether or not to log is now being made by log4perl.  We've put 
another valve on the pipe before the ApacheLog valve.

Basically you're not controlling the logging from the apache config 
anymore, you're controlling it from the log4perl config.

However, if ApacheLog is doing something else with the level, like 
making it part of the error message or doing different routing for 
different levels, then that's a horse of a different color.  For 
instance, the current problem with using Log::Dispatch::DBI is that it 
does something like
	INSERT INTO logtable (level, msg) values (?,?)
but the level that Log::Dispatch::DBI gets from Log4perl is always 
'debug', so it's less than  helpful.


> i'm certainly not at expert in this area but it seems logging with the
> Log::Dispatch::ApacheLog is a unique case (certainly more complex than
> SCREEN, FILE, EMAIL, etc....do

Pardon my dumb question, but how is ApacheLog different?  To log or not 
to log, that is the question, but it's decided by Log4perl before 
ApacheLog ever even hears about it.


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] Rotating log files

[Dave R. <au...@ur...>]

On Wed, 25 Sep 2002 Msc...@ao... wrote:

> Actually, the Log::Dispatch appender should take care of that. There should
> be something like Log::Dispatch::FileRotate, but -- just checked -- there
> isn't.
> Dave, is there an appender that rotates logfiles similar to the rotating file
> appenders of the Java world?

Nope, there isn't.  But of course some could write one and put it on CPAN
;)


-dave

/*==================
www.urth.org
we await the New Sun
==================*/

Re: [log4perl-devel] Rotating log files

[Kevin G. <ke...@go...>]

Msc...@ao... wrote:
> In a message dated 9/24/02 9:34:20 PM Pacific Daylight Time, 
> mar...@ed... writes:
> 
>> I have a long running process and I want to rotate my logs files without
>> having to stop and start my app. How do I close logfiles? Or is there
>> some way of log4perl rotating for me? Or can I have a logfile
>> open->written->closed for each message?

If it's any comfort, our to-do list has plans to implement stuff 
corresponding to the java RollingFileAppender and DailyRolllingFileAppender.



-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[Kevin G. <ke...@go...>]

I do not think I have any open issues left.


msc...@ao... wrote:
> In a message dated Wed, 25 Sep 2002 12:10:12 AM Eastern Standard Time, ke...@go... writes:
> 
> 
>>Mike, your fix to PatternLayout.pm took care of the win32 failure for
>>022Wrap.t, but it necessitated me backing out my regexing fix to the
>>other four test scripts
> 
> 
> Oh, sorry, good catch, thanks! Do you have any open issues left or are we OK to move towards the 0.24beta release?
> 


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] =?GB2312?B?u7bTrb34yOvOwtbdyczStc34?=

[<web...@wz...>]

请进入 http://www.wzbm.com  
这里将给您提供无限商机

Re: [log4perl-devel] Rotating log files

[<Msc...@ao...>]

In a message dated 9/24/02 9:34:20 PM Pacific Daylight Time, 
mar...@ed... writes:


> I have a long running process and I want to rotate my logs files without
> having to stop and start my app. How do I close logfiles? Or is there
> some way of log4perl rotating for me? Or can I have a logfile
> open->written->closed for each message?
> 

Actually, the Log::Dispatch appender should take care of that. There should 
be something like Log::Dispatch::FileRotate, but -- just checked -- there 
isn't. 
Dave, is there an appender that rotates logfiles similar to the rotating file 
appenders of the Java world?

-- Mike

Mike Schilli
log...@pe...
http://perlmeister.com

Re: [log4perl-devel] log4perl bug when using Log::Dispatch::ApacheLog appender

[<Msc...@ao...>]

In a message dated 9/24/02 9:59:37 AM Pacific Daylight Time, 
da...@ep... writes:


> first thanks the great work developing the log4perl module

Thanks :)

> integrating into our web applications and discovered a problem
> while using Log::Dispatch::ApacheLog as an appender
> 

Hmm. In Log::Log4perl, we're passing along a dummy value as a level to 
Log::Dispatch objects, because we want them to log unconditionally when 
Log::Log4perl determines the priority for logging has been met. 

I'm not sure your solution is going to work, because the log4perl levels 
aren't compatible with the Log::Dispatch ones. 

Could we just set it to "debug" every time? Or is this going to end up in the 
log somehow?

-- Mike

Mike Schilli
log...@pe...
http://perlmeister.com

[log4perl-devel] Re: Perl Version Requirement in Log4perl

[<Msc...@ao...>]

In a message dated 9/24/02 9:49:15 AM Pacific Daylight Time, 
er...@op... writes:

> What are your thoughts on a Log4perl which works with 5.005, which seems to 
> be
> a bit more widespread at the moment?  Is there other code being used 
> internally
> that makes moving to 5.005 tricky?  And lastly, if you'd be willing to 
> consider
> 

That's a dilemma. I mean, it's a tragedy that people still use 5.005_03, but 
it's a fact -- not too long ago I was furious when my hosting service told me 
5.005_03 was good enough, but after some prodding they finally upgraded to 
5.6.1.

There's a lot of handy stuff that came with 5.6: "our" variables, qr() 
constructs, look-aheads (if I remember right), to name only a few. Many 
standard modules use this new stuff, and new CPAN modules are happily using 
the new standard modules (Test::Simple, Test::More, File::Spec etc.). And as 
a consequence, these new modules don't run with older versions of perl.

Now, you could certainly argue that we don't really *need* this new stuff. 
But, on the other hand, if everybody thought like that we'd still be 
programming Fortran 77, that was a pretty good language and would be good 
enough even by today's standards.

So, sorry to say, I don't really like the idea of back-porting Log::Log4perl 
to perl 5.005 -- we depend on too many modules (e.g. Log::Dispatch::*), which 
also require 5.6.1. Maybe someone should write a module (source filter etc.) 
for 5.005 to understand 5.6.1 syntax :) ?

-- Mike

log...@pe...
http://perlmeister.com

[log4perl-devel] Fwd: Perl Version Requirement in Log4perl

[<Msc...@ao...>]

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[<msc...@ao...>]

In a message dated Wed, 25 Sep 2002 12:10:12 AM Eastern Standard Time, ke...@go... writes:

>Mike, your fix to PatternLayout.pm took care of the win32 failure for
>022Wrap.t, but it necessitated me backing out my regexing fix to the
>other four test scripts

Oh, sorry, good catch, thanks! Do you have any open issues left or are we OK to move towards the 0.24beta release?

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[Kevin G. <ke...@go...>]

Mike, your fix to PatternLayout.pm took care of the win32 failure for
022Wrap.t, but it necessitated me backing out my regexing fix to the
other four test scripts, since the presence of the backslash in the
regex in the ok() calls fubared them.

So all the win32 issues seem to be ok, at least on my activestate 5.6.1.


> 4) These guys were looking for '/' as a directory separator in their
> test results, I changed the ok() comparisons to use regexes with a '.'
> instead, that'll match unix '/' and dos '\', but I think a mac is '::'.
> There doesn't seem to be an easy way to get the directory separator on
> the current machine, anybody know one?
> 003Layout.t
> 005Config-Perl.t
> 006Config-Java.t
> 007LogPrio.t
> (changes checking in now)
> 
> 6) 022Wrap.t I think is showing the %F{1} doesn't work with the windows
> '\', but I don't have time to take it further right now.
> # Test 1 got: 'File: t\022Wrap.t Line number: 60 package: main'
> (t\022Wrap.t at
> line 62)
> #   Expected: 'File: 022Wrap.t Line number: 60 package: main'
> FAILED test 1


-- 
Happy Trails . . .

Kevin M. Goess 
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[Kevin G. <ke...@go...>]

> Regarding the STDERR fix, I still need to look into it, not quite sure why re-opening STDERR is unix-ish.

I utterly apologize, it's not, I just hadn't seen the idiom before.  All
it needed was a 
	select STDERR; $| = 1;	
after the open.  Is now in cvs.

-- 
Happy Trails . . .

Kevin M. Goess 
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] Rotating log files

[Pfeiffer, M. (EDS) <mar...@ed...>]

Hi, I am assuming this issue has been already handled and would like to
know how it is done usually with log4perl.

I have a long running process and I want to rotate my logs files without
having to stop and start my app. How do I close logfiles? Or is there
some way of log4perl rotating for me? Or can I have a logfile
open->written->closed for each message?

My explaination above wasn't that good, but I think you'll understand
what I'm after.

cheers
mark

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[<msc...@ao...>]

Hi Kevin,

thanks for all these fixes, that's wonderful! I've also added a fix via File::Spec->catfile() to work around os-dependent file separators. Regarding the STDERR fix, I still need to look into it, not quite sure why re-opening STDERR is unix-ish. 

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[Mark B. <md...@ji...>]

>> On Tue, 24 Sep 2002 07:46:28 -0700,
>> Kevin Goess(KG) wrote:

KG> 4) These guys were looking for '/' as a directory separator in their
KG> test results, I changed the ok() comparisons to use regexes with a '.'
KG> instead, that'll match unix '/' and dos '\', but I think a mac is '::'. 
KG> There doesn't seem to be an easy way to get the directory separator on
KG> the current machine, anybody know one?
 
I'm not sure of the context, but wouldn't File::Spec work? I believe
it is part of the baseline,

     File::Spec - portably perform operations on file names

-- 
 -mb-

[log4perl-devel] log4perl bug when using Log::Dispatch::ApacheLog appender

[davis m. <da...@ep...>]

first thanks the great work developing the log4perl module, i am
integrating into our web applications and discovered a problem
while using Log::Dispatch::ApacheLog as an appender

in Logger.pm the generate_coderef function creates the subroutine
to call the log function of the appender...the call is coded as:

          \$appender->log(
              #these get passed through to Log::Dispatch
              { name    => \$appender_name,
                level   => 0,
                message => \$message,
              },
              #these we need
              \$logger->{category},
              \$level,
          );

with the ApacheLog module the value of the 'level' key in the hash is
used as the method name on the Apache Log API...since this was hardcoded
to 0 the method call failed...

i changed this code to

          \$appender->log(
              #these get passed through to Log::Dispatch
              { name    => \$appender_name,
                level   => lc(\$level),    <------MODIFIED LINE
                message => \$message,
              },
              #these we need
              \$logger->{category},
              \$level,
          );

and it worked like a champ as far as logging to Apache was concerned...

But I have not studied the Log4perl code enough to know if this is the
proper way to fix this...

So if you guys have already fixed this or can comment on this patch 
i would greatly appreciate any information...

again...thanks for the great job i'm looking forward to using this
package extensively in our future development


davis


-- 
davis mcpherson <da...@ep...>

Re: [log4perl-devel] easier interface

[Kevin G. <ke...@go...>]

> I like the philosophy of the package, but calling
> get_logger in every single functions that logs is just a
> waste.

This is an emulation of a Java api--you were expecting terse and 
concise? ;-)

But seriously, if you don't want to call get_logger in every function, 
then don't--you could, for instance, make the logger a class variable:

use strict;
package Groceries::Food;

our $logger = Log::Log4perl::get_logger('Groceries::Food');

sub eat {
	$logger->debug("eating");
}
sub drink {
	$logger->debug("drinking");
}





-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[Kevin G. <ke...@go...>]

1) First, nice work Mike on making Time::HiRes optional, I just noticed
that.

2) I fired up Log4perl on Win32 perl 5.6.1 (Activestate).  Here are all
the modules I had to add, if anyone's curious what our base dependencies
are:
Attribute-Handlers
Params-Validate
Log-Dispatch
Test-Simple
Test-Harness

3) t/010JConsole.t used a call to `touch`, which wasn't causing an error
but I fixed anyway.

4) These guys were looking for '/' as a directory separator in their
test results, I changed the ok() comparisons to use regexes with a '.'
instead, that'll match unix '/' and dos '\', but I think a mac is '::'. 
There doesn't seem to be an easy way to get the directory separator on
the current machine, anybody know one?
003Layout.t
005Config-Perl.t
006Config-Java.t
007LogPrio.t
(changes checking in now)

5) 020Easy.t is using a unixism to capture STDERR, we need a different
way to test that, but I'm out of time right now
# Test 3 got: '' (t\020Easy.t at line 37)
#   Expected: 'm#this we want#'
not ok 4
# Test 4 got: '' (t\020Easy.t at line 38)
#   Expected: 'm#this also#'
FAILED tests 3-4
        Failed 2/4 tests, 50.00% okay

6) 022Wrap.t I think is showing the %F{1} doesn't work with the windows
'\', but I don't have time to take it further right now.
# Test 1 got: 'File: t\022Wrap.t Line number: 60 package: main'
(t\022Wrap.t at
line 62)
#   Expected: 'File: 022Wrap.t Line number: 60 package: main'
FAILED test 1


msc...@ao... wrote:
> 
> In a message dated Mon, 23 Sep 2002 7:10:44 PM Eastern Standard Time, ke...@go... writes:
> 
> >I just built a 5.8 (not 5.6.1) with threads and Log4perl tested fine,
> >I'll do more investigation and let you know.
> 
> That's good to know -- my suspicion is, though, that it's more Windows- than thread-related.
> 
> -- Mike
> 
> ############################
> # Mike Schilli             #
> # log...@pe... #
> # http://perlmeister.com   #
> # log4perl.sourceforge.net #
> ############################
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> log4perl-devel mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4perl-devel

-- 
Happy Trails . . .

Kevin M. Goess 
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

Re: [log4perl-devel] easier interface

[Erik W. S. <er...@se...>]

Well, what I actually did in my code is something that looks a lot like 
this. :)

I basically created a faux package that exports $logger into the current 
namespace. So yeah, it's basically a
global variable. But sometimes, that's what you want. :)

Anyway, I then just call $logger->whatever() whenever and whereever I 
want, and never really worry about it.

Oh and I don't use categories, as mostly what I'm doing is outputting to 
a given file or syslog. Just me.

If I'm good I'll rip out all the Real-specific things and post it.
-e


msc...@ao... wrote:

>In a message dated Mon, 23 Sep 2002 11:05:31 PM Eastern Standard Time, mrd...@ya... writes:
>
>  
>
>>A quick glance at the code, and me think one could cache
>>the logger objects without trouble (unless they are much
>>bigger than I think). So get_logger would become:
>>    
>>
>
>Well, this is already done of course by the current implementation -- Log4perl uses a singleton mechanism.
>
>The overhead arises because of multiple get_logger() calls (which are admittedly quite cheap, but it adds up).
>
>  
>

Re: [log4perl-devel] Some Log::Log4perl tests failing under Windows

[<msc...@ao...>]

In a message dated Mon, 23 Sep 2002 7:10:44 PM Eastern Standard Time, ke...@go... writes:

>I just built a 5.8 (not 5.6.1) with threads and Log4perl tested fine, 
>I'll do more investigation and let you know.

That's good to know -- my suspicion is, though, that it's more Windows- than thread-related.

-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] easier interface

[<msc...@ao...>]

In a message dated Mon, 23 Sep 2002 11:05:31 PM Eastern Standard Time, mrd...@ya... writes:

>A quick glance at the code, and me think one could cache
>the logger objects without trouble (unless they are much
>bigger than I think). So get_logger would become:

Well, this is already done of course by the current implementation -- Log4perl uses a singleton mechanism.

The overhead arises because of multiple get_logger() calls (which are admittedly quite cheap, but it adds up).

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################