log4perl-devel — Ongoing log4perl development

Re: [log4perl-devel] Log4perl::Appender - delaying appender instantiation

[Aaron S. C. <as...@vi...>]

On Wed, 2 Oct 2002, Kevin Goess wrote:

> Interesting idea, but I have a possible objection to it.  If I set up my
> config to log somewhere I don't have permission to write to, I would
> like it to tell me right now, not two days from now when fails to log
> that intermittent error I've been trying to catch.  The principle of
> least surprise would seem to be on the side of an immediate failure.

Yes, that's reasonable. Part of my problem with the current setup is that
the config mechanism will try to instantiate appenders that have nothing
to do with the call to &get_logger(AppenderFoo);

There is the issue of memory/processor usage but also of an appender for
sending email notices causing a completely unrelated appender for logfiles
to blast the last logfile, even though the logging process itself
isn't being run, because the file-mode is set to 'write'.

If I have a whole whack of appenders in my config shouldn't they atleast
be created on an as-needed basis?

I haven't had a chance to look at the code yet, but if I had to go back to
the drawing board I would look at atleast *not* instantiating appenders
not explictly set in the config file for :

 log4perl.logger.FooBar=MIN_LEVEL, A1, A2, etc.

FWIW, though, the Log::Dispatch::Jabber spills its guts to
Log::Dispatch::Screen (stderr) whenever it runs into a problem :-)

> I understand your situation, but I wonder if there might be inherent
> problems in the way you're setting it up.  If some other guy comes along
> to maintain your program, he might not know your appender is "root-only"
> and try to use it where he shouldn't, and be in the same boat I
> described above.  Wouldn't it be safer having your root-only appender in
> some other place?

Well, one of the attractions to log4perl is that all your logging data can
be centralized. We are already subclass the main package so that the
config path or data structure can be automagically specified.

I can imagine adding additional checks $EUID and plugging in relevant
information but I'm not wild about the idea.

Anyway, we are generally pretty strict about doing things like :

  die "You must be root to run this program" unless ($EUID == 0);

And if someone doesn't know what that means by the time they are
working on root-only scripts then we probably get what we deserve. ;-)

> > I ask because I came across a problem when Log4perl is used in a context
> > where there is a single config file slurped and parsed by multiple
> > processes with different permissions sets.
> >
> > Specifically, if my program is running as "joeuser" and the config file
> > contains an appender for use by "root"-only processes to log stuff to
> > /super/secret/logfiles via Log::Dispatch::File, the first process will
> > always die as soon as it calls &get_logger.

Re: [log4perl-devel] Log4perl::Appender - delaying appender instantiation

[Kevin G. <cp...@go...>]

Interesting idea, but I have a possible objection to it.  If I set up my 
config to log somewhere I don't have permission to write to, I would 
like it to tell me right now, not two days from now when fails to log 
that intermittent error I've been trying to catch.  The principle of 
least surprise would seem to be on the side of an immediate failure.

I understand your situation, but I wonder if there might be inherent 
problems in the way you're setting it up.  If some other guy comes along 
to maintain your program, he might not know your appender is "root-only" 
and try to use it where he shouldn't, and be in the same boat I 
described above.  Wouldn't it be safer having your root-only appender in 
some other place?


Aaron Straup Cope wrote:
> [ Apologies if anyone is getting this twice; I think I sent this to the
> admin address by accident. ]
> 
> Howdy,
> 
> I'm new to these parts and still doing my homework so it's possible that
> I've missed something but:
> 
> Is there a reason that all the appenders listed in the config data are
> instantiated at start-up?
> 
> I ask because I came across a problem when Log4perl is used in a context
> where there is a single config file slurped and parsed by multiple
> processes with different permissions sets.
> 
> Specifically, if my program is running as "joeuser" and the config file
> contains an appender for use by "root"-only processes to log stuff to
> /super/secret/logfiles via Log::Dispatch::File, the first process will
> always die as soon as it calls &get_logger.
> 
> "joeuser" doesn't have write permissions on the logfiles directory but the
> File widget will try to open a handle as soon as it is created and when it
> fails -- I find this sort of thing a bit annoying on principle but it's
> not a log4perl thing -- bring the whole program down with it.
> 
> This didn't seem right so I poked around a bit and tickled ::Appender.pm
> (see below) such that instantiation of handlers doesn't happen until the
> first time they are actually called. This prevents stuff like what I've
> described above from happening and has the added benefit of not creating a
> bunch of objects your program is never going to use.
> 
> Left to me own devices, I might do the same thing for the actual
> "require"-ing of the appender classes but I'm not really sure about that
> one.
> 
> Thoughts, comments?
> 
> 60,66d59
> <     my $appender = $appenderclass->new(
> <             # Set min_level to default, *we* are controlling this now
> <         min_level => 'debug',
> <             # Set 'name' and other parameters
> <         map { $_ => $params{$_} } keys %params,
> <     );
> <
> 68,71c61,66
> <                  appender => $appender,
> <                  name     => $params{name},
> <                  layout   => undef,
> <                  level    => $DEBUG,
> ---
> 
>>              appender       => undef,
>>              appenderclass  => $appenderclass,
>>              appenderparams => \%params,
>>              name           => $params{name},
>>              layout         => undef,
>>              level          => $DEBUG,
> 
> 116c111
> <     return $self->{appender}->log(%$p);
> ---
> 
>>    return $self->_appender()->log(%$p);
> 
> 151a147,157
> 
>>sub _appender {
>>  my $self = shift;
>>
>>  if (ref($self->{appender}) ne $self->{appenderclass}) {
>>    my $class = $self->{appenderclass};
>>    $self->{appender} =
> 
> $class->new(min_level=>"debug",%{$self->{appenderparams}});
> 
>>  }
>>
>>  return $self->{appender};
>>}
>>
> 
> 161c167
> <     return $self->{appender}->$AUTOLOAD(@_);
> ---
> 
>>    return $self->_appender()->$AUTOLOAD(@_);
> 
> 
> 
> 
> 
> 
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> log4perl-devel mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4perl-devel


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] Log::Dispatch::Jabber

[Kevin G. <ke...@go...>]

OK, Log-Dispatch-Jabber-0.21 is now supported, config like this:
   log4j.category.animal.dog   = INFO, jabbender

   log4j.appender.jabbender          = Log::Log4perl::AppenderTester
   log4j.appender.jabbender.layout   =   \
   Log::Log4perl::Layout::SimpleLayout
   log4j.appender.jabbender.login.hostname = a.jabber.server
   log4j.appender.jabbender.login.port = 5222
   log4j.appender.jabbender.login.username =  bugs
   log4j.appender.jabbender.login.password = bunny
   log4j.appender.jabbender.login.resource = logger
   log4j.appender.jabbender.to = elmer@a.jabber.server
   log4j.appender.jabbender.to = sa...@an...rver

will send params to the dispatch object that look like this:
#{
#    login => {
#          hostname => "a.jabber.server",
#          password => "bunny",
#          port     => 5222,
#          resource => "logger",
#          username => "bugs",
#        },
#    to => ["elmer\@a.jabber.server", "sam\@another.jabber.server"],
#  },


Tests are in 004Config.t.



-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] Log4perl::Appender - delaying appender instantiation

[Aaron S. C. <as...@vi...>]

[ Apologies if anyone is getting this twice; I think I sent this to the
admin address by accident. ]

Howdy,

I'm new to these parts and still doing my homework so it's possible that
I've missed something but:

Is there a reason that all the appenders listed in the config data are
instantiated at start-up?

I ask because I came across a problem when Log4perl is used in a context
where there is a single config file slurped and parsed by multiple
processes with different permissions sets.

Specifically, if my program is running as "joeuser" and the config file
contains an appender for use by "root"-only processes to log stuff to
/super/secret/logfiles via Log::Dispatch::File, the first process will
always die as soon as it calls &get_logger.

"joeuser" doesn't have write permissions on the logfiles directory but the
File widget will try to open a handle as soon as it is created and when it
fails -- I find this sort of thing a bit annoying on principle but it's
not a log4perl thing -- bring the whole program down with it.

This didn't seem right so I poked around a bit and tickled ::Appender.pm
(see below) such that instantiation of handlers doesn't happen until the
first time they are actually called. This prevents stuff like what I've
described above from happening and has the added benefit of not creating a
bunch of objects your program is never going to use.

Left to me own devices, I might do the same thing for the actual
"require"-ing of the appender classes but I'm not really sure about that
one.

Thoughts, comments?

60,66d59
<     my $appender = $appenderclass->new(
<             # Set min_level to default, *we* are controlling this now
<         min_level => 'debug',
<             # Set 'name' and other parameters
<         map { $_ => $params{$_} } keys %params,
<     );
<
68,71c61,66
<                  appender => $appender,
<                  name     => $params{name},
<                  layout   => undef,
<                  level    => $DEBUG,
---
>               appender       => undef,
>               appenderclass  => $appenderclass,
>               appenderparams => \%params,
>               name           => $params{name},
>               layout         => undef,
>               level          => $DEBUG,
116c111
<     return $self->{appender}->log(%$p);
---
>     return $self->_appender()->log(%$p);
151a147,157
> sub _appender {
>   my $self = shift;
>
>   if (ref($self->{appender}) ne $self->{appenderclass}) {
>     my $class = $self->{appenderclass};
>     $self->{appender} =
$class->new(min_level=>"debug",%{$self->{appenderparams}});
>   }
>
>   return $self->{appender};
> }
>
161c167
<     return $self->{appender}->$AUTOLOAD(@_);
---
>     return $self->_appender()->$AUTOLOAD(@_);

Re: [log4perl-devel] (no subject)

[<msc...@ao...>]

In a message dated Tue, 1 Oct 2002 8:28:02 AM Eastern Standard Time, Bri...@DF... writes:

> Shouldn't the log reflect the line that called 
> $logger->logdie rather than
> where the method is located in the Log::Log4perl module?

Hi Brian,

you're certainly right - that was a bug in the logdie/logwarn methods, I've just fixed it and checked it into CVS. It'll be part of the upcoming 0.25 release. Thanks much!


-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

[log4perl-devel] Re: Log::Log4perl::Appender : Log::Dispatch::File mode

[<msc...@ao...>]

In a message dated Mon, 30 Sep 2002 4:32:35 PM Eastern Standard Time, as...@vi... writes:

>I noticed the following disconnect between your 
>O'Reillynet article and the actual code in Log4perl :
>If we had left out the mode =>
>"append" pair, then it would just overwrite the file 
>each time at system startup.

Funny, we cheated on this a bit since 0.23. After I ran into the "if you don't say 'append' explicitely, your apps will clobber the log file every time" a couple of times and we saw that the Java file appender appends (sic!) by default, we taught Appender.pm to modify Log::Dispatch::File's default setting to "mode => 'append'" -- and lived happily ever after. Of course, the article was based on 0.22. If you need to overwrite, you can of course still do that by saying "mode => 'write'" explicitely. 

>[ps] - please ignore the bit about calling ::Levels::to_priority(). It would be cool, but I also finally noticed :levels. Sorry about that.

Actually, I liked it and included it, more DWIM'ness is always a good idea.

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Fwd: Log::Log4perl Patch for perl 5.005_03 [3]

[<msc...@ao...>]

>In the config file, is it possible to assign mulitple values to an appender? 

Think Kevin's taking care of this one ...

>In ::Log4perl::Appender::threshold(), would you consider modifying the mutator such that the method will take care of assigning the numeric value for a named level?

Applied your patch and checked it in, thanks! It's gonna be part of 0.25.

-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

[log4perl-devel] Re: Log4perl and Log::Dispatch::Jabber

[Kevin G. <ke...@go...>]

Aaron Straup Cope wrote:
 > Your wish is my command. Accepts a string or an array ref. It's on its
 > way to the CPAN :-)

Well, cool! If nobody objects to these changes to Config I'll check them 
and and Log::Dispatch::Jabber will be good to go.  I have an example 
config file in /eg/, but didn't write a unit test.


===================================================================
RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Config.pm,v
retrieving revision 1.25
diff -u -r1.25 Config.pm
--- modules/Config.pm   30 Sep 2002 08:21:47 -0000      1.25
+++ modules/Config.pm   2 Oct 2002 00:13:50 -0000
@@ -169,11 +169,40 @@
         $_ ne "value"
       } keys %{$data->{appender}->{$appname}};

+     my %param = ();
+     foreach my $pname (@params){
+         #this could be simple value like
+         #{appender}{myAppender}{file}{value} => 'log.txt'
+         #or a structure like
+         #{appender}{myAppender}{login} =>
+         #                         { name => {value => 'bob'},
+         #                           pwd  => {value => 'xxx'},
+         #                         }
+         #in the latter case we send a hashref to the appender
+         if (exists $data->{appender}{$appname}
+                           {$pname}{value}      ) {
+             $param{$pname} = $data->{appender}{$appname}
+                                     {$pname}{value};
+         }else{
+             $param{$pname} = {map {$_ => $data->{appender}
+                                                 {$appname}
+                                                 {$pname}
+                                                 {$_}
+                                                 {value}}
+                              keys %{$data->{appender}
+                                            {$appname}
+                                            {$pname}}
+                              };
+         }
+
+     }
+
       $appender = Log::Log4perl::Appender->new(
           $appenderclass,
           name => $appname,
-         map { $_ => $data->{appender}->{$appname}->{$_}->{value}
-             } @params,
+         %param,
+         #map { $_ => $data->{appender}->{$appname}->{$_}->{value}
+         #    } @params,
       );
       add_layout_by_name($data, $appender, $appname);

@@ -322,12 +351,32 @@
          if(my($key, $val) = /(\S+?)\s*=\s*(.*)/) {
              $val =~ s/\s+$//;
              $key = unlog4j($key);
+            my $how_deep = 0;
              my $ptr = $data;
              for my $part (split /\.|::/, $key) {
                  $ptr->{$part} = {} unless exists $ptr->{$part};
                  $ptr = $ptr->{$part};
+                ++$how_deep;
+            }
+
+            #here's where we deal with turning multiple values like this:
+            # log4j.appender.jabbender.to = him@a.jabber.server
+            # log4j.appender.jabbender.to = her@a.jabber.server
+            #into an arrayref like this:
+            #to => { value =>
+            #       ["him\@a.jabber.server", "her\@a.jabber.server"] },
+            if (exists $ptr->{value} && $how_deep > 2) {
+                if (ref ($ptr->{value}) ne 'ARRAY') {
+                    my $temp = $ptr->{value};
+                    $ptr->{value} = [];
+                    push (@{$ptr->{value}}, $temp);
+                }
+                print ref $ptr->{value},"\n";
+                push (@{$ptr->{value}}, $val);
+            }else{
+                $ptr->{value} = $val;
              }
-            $ptr->{value} = $val;
+
          }
      }


Aaron Straup Cope wrote:
> Your wish is my command. Accepts a string or an array ref. It's on its
> way to the CPAN :-)
> 
> http://perl.aaronland.info/log-dispatch/jabber/Log-Dispatch-Jabber-0.21.tar.gz
> 
> <quote>
> to make the required nested hash, which we could do, but we should ask
>  him to accept a string like this instead of an array ref
> 
>  	to=>'someone@a.jabber.server'
> 
>  if there's only one of them.  We could make an array ref if there's
>  multiple things, but I don't see an easy way to trigger it if there's
>  only one, and it sounds easier to ask him to change his dispatcher.  So
>  this could make an arrayref:
> 
>     log4j.appender.jabbender.to = someone@a.jabber.server
>     log4j.appender.jabbender.to = someoneelse@an...
> </quote>
> 


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] (no subject)

[Duffy, B. J <Bri...@DF...>]

Hello list-

I think that I have found a bug in Logger::Log4perl::Logger::logdie .

If I use logdie like this:

open(FILE, "/tmp/file.txt") or $logger->logdie("Test");

the following appears in the log:

2002/10/01 09:03:34 FATAL Logger.pm:696 Log::Log4perl::Logger::logdie - Test

Shouldn't the log reflect the line that called $logger->logdie rather than
where the method is located in the Log::Log4perl module?

Brian Duffy
NYS Office for Technology

[log4perl-devel] log4perl and variable logfiles

[Bernd G. <bg...@th...>]

hy there,

depends on my e-mail log4perl and variable logfiles.
oh sorry, it really works

thanks
bernd

[log4perl-devel] log4perl and variable logfiles

[Bernd G. <bg...@th...>]

hy there,

we use log4j in our java projects (great functions) and now we want to
use log4perl in our perl projects. i think we can use the same =
configuration
logfiles and so on.

and now here is my question. in log4j i can do something like this to =
use
different configuration files:

propertiesPath =3D "/_init/cb2/is/log4jProperties." + produkt;
PropertyConfigurator.configure (csBasePath + properiesPath);=20

...

i think in log4perl i only can say:

Log::Log4perl -> init ("configurationfile");

but i need somthink like

my $completepath =3D $path1 . $path2;
Log::Log4perl -> init ($completepath);

how can i do this? i hope you can help me.

thanks
bernd

-------------------------------------------------------
thinking information software gmbh
we make information work for you
-------------------------------------------------------
Bernd Greimel     direct tel: +49 (0) 8081 / 9571 - 10
Siemensstrasse 4  fax:  +49 (0) 8081 / 9571 - 29
D-84405 Dorfen    email: bg...@th...
-------------------------------------------------------

Re: [log4perl-devel] Log-Dispatch-Jabber

[Kevin G. <ke...@go...>]

Neat.  It works fine by itself, but it'll take some tweaking to make it 
work with Log4perl.  It's new() expects nested parameters like this:

     name=>"jabber",
     min_level=>"debug",
     login=>{
             hostname => "some.jabber.server",
             port     => 5222,
             username => "logger",
             password => "*****",
             resource => "logger",
            },
     to=>["someone\@a.jabber.server"],

It sounds me like we'd want to implement handling a config file like this:
   log4j.appender.jabbender          = Log::Dispatch::Jabber
   log4j.appender.jabbender.layout   = \
		Log::Log4perl::Layout::SimpleLayout
   log4j.appender.jabbender.login.hostname = a.jabber.server
   log4j.appender.jabbender.login.port = 5222
   log4j.appender.jabbender.login.username = someone
   log4j.appender.jabbender.login.password = ******
   log4j.appender.jabbender.login.resource = logger
   log4j.appender.jabbender.to = someone@a.jabber.server

to make the required nested hash, which we could do, but we should ask 
him to accept a string like this instead of an array ref

	to=>'someone@a.jabber.server'

if there's only one of them.  We could make an array ref if there's 
multiple things, but I don't see an easy way to trigger it if there's 
only one, and it sounds easier to ask him to change his dispatcher.  So 
this could make an arrayref:

   log4j.appender.jabbender.to = someone@a.jabber.server
   log4j.appender.jabbender.to = som...@an...rver
	




Msc...@ao... wrote:
> This sounds interesting, has anybody tried it yet?
> 
> [28.] Log-Dispatch-Jabber - Log messages via Jabber
> Uploaded: Sep 27, 2002
> CPAN id: A/AS/ASCOPE (Aaron Straup Cope)
>           http://kobesearch.cpan.org/search?cpanid=ASCOPE
> Package: Log-Dispatch-Jabber-0.1.tar.gz
>           http://kobesearch.cpan.org/search?dist=Log-Dispatch-Jabber-0.1
> 
>  -- Mike
> 
> Mike Schilli
> log...@pe...
> http://perlmeister.com
> http://log4perl.sourceforge.net


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] Log-Dispatch-Jabber

[<Msc...@ao...>]

This sounds interesting, has anybody tried it yet?

[28.] Log-Dispatch-Jabber - Log messages via Jabber
Uploaded: Sep 27, 2002
CPAN id: A/AS/ASCOPE (Aaron Straup Cope)
=A0 =A0 =A0 =A0 =A0 http://kobesearch.cpan.org/search?cpanid=3DASCOPE
Package: Log-Dispatch-Jabber-0.1.tar.gz
=A0 =A0 =A0 =A0 =A0 http://kobesearch.cpan.org/search?dist=3DLog-Dispatch-Ja=
bber-0.1

  -- Mike

Mike Schilli
log...@pe...
http://perlmeister.com
http://log4perl.sourceforge.net

Re: [log4perl-devel] log4perl bug when usingLog::Dispatch::ApacheLog appender

[<msc...@ao...>]

In a message dated Wed, 25 Sep 2002 8:30:13 AM Eastern Standard Time, da...@ep... writes:

>if you want i may have time to look into this further 
> over the next couple of weeks and submit a patch for 
> you guys to review...

That'd be definitely apprechiated. Basically, the Log4perl philosophy is: Have the logging system determine if the message is being logged or not. The appender just logs, no questions asked.

Reason for this is that Log4perl offers a much more granular system to steer the logging behaviour of an application than typical logging systems. You're allowed to say "turn logging off in this system component only", "turn on DEBUG in this class and ERROR in that other class" and many more. For a more detailed description on what's possible, please check

 http://www.perl.com/pub/a/2002/09/11/log4perl.html

The only way I see this far to have the Apache Appender participate in the Log4perl game is that it needs to log unconditionally. If it makes its own decision, based on yet another configuration file, that's like two people sitting in front of a TV, each holding a remote control :).

But, you're more familiar with the Apache code, I'm looking forward to your patches ...

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Log::Log4perl Patch for perl 5.005_03

[<msc...@ao...>]

In a message dated Mon, 30 Sep 2002 12:21:11 AM Eastern Standard Time, er...@se... writes:

>As a related question... does it make sense for us to support 5.005? 

Not necessarily. But there's been two requests by different people and I put it in (almost) without messing with the existing code (see the latest checkin/mail, it's an additional helper script for Makefile.PL). And, we can keep doing what we're doing.

>use warnings; vs -w

That's taken care of. Also "our" variables are taken care of.

>$self->{$which}($self, ...) as function calls which make sense (I never liked the -> for func calls)

That one's not taken care of. But I don't see it as a big deal -- or is it?

I don't see 5.005_03-compatibility as a big issue -- if it gets in the way, we'll just drop it. 

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Log::Log4perl Patch for perl 5.005_03

[Erik W. S. <er...@se...>]

Don't know if we have any boxes with 5.x at work, but I'll look. Tend to 
be a fair number of slackware boxes with old stuff.

As a related question... does it make sense for us to support 5.005? 
It's what, 5 years old and 5.8 is out? Just wondering as it allows for 
things that I think are nicer:

use warnings; vs -w
$self->{$which}($self, ...) as function calls which make sense (I never 
liked the -> for func calls)
and other nicetieis.

Just curious.

-e

Mike Schilli wrote:

>Hi all,
>
>I can't believe I'm doing this -- but I today I thought: Why not do something totally crazy? 
>
>So, I sat down and changed a couple of files in Log::Log4perl to run with 5.005_03. It was easier
>than I thought at first.
>
>Eric pointed out correctly that the modules we're using are indeed supported for perl 5.005_03
>(Log::Dispatch, Test::Simple, etc.). All that I needed to change is replace "our" by "use vars", get
>rid of "use warnings" and change calls like 
>
>    $self->{$which}($self, ...)
>
>to 
>
>    $self->{$which}->($self, ...)
>
>(which is probably the right thing to do anyway) and, boom, test suite passes.
>
>Can you two 5.005_03 enthusiasts (Eric and asc) please try out the patch attached to this email?
>Should be as easy as grabbing the latest Log::Log4perl 0.24 and do
>
>    cd Log-Log4perl-0.24
>    patch -p0 <../patch.500503.txt
>
>Please let me know if it works for you ... and then we'll have to decide if we can work against our
>beliefs and make Log::Log4perl compatible with 5.005_03 :).
>
>-- Mike
>
>############################
># Mike Schilli             #
># log...@pe... #
># http://perlmeister.com   #
># log4perl.sourceforge.net #
>############################
>  
>
>------------------------------------------------------------------------
>
>Index: lib/Log/Log4perl.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl.pm,v
>retrieving revision 1.68
>diff -a -u -r1.68 Log4perl.pm
>--- lib/Log/Log4perl.pm	27 Sep 2002 17:56:09 -0000	1.68
>+++ lib/Log/Log4perl.pm	29 Sep 2002 04:33:49 -0000
>@@ -2,9 +2,8 @@
> package Log::Log4perl;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> 
> use Log::Log4perl::Logger;
> use Log::Log4perl::Level;
>@@ -12,11 +11,13 @@
> use Log::Dispatch::Screen;
> use Log::Log4perl::Appender;
> 
>-our $VERSION = '0.24';
>+use vars qw($VERSION $caller_depth);
>+
>+$VERSION = '0.24';
> 
>    # set this to '1' if you're using a wrapper
>    # around Log::Log4perl
>-our $caller_depth = 0;
>+$caller_depth = 0;
> 
> ##################################################
> sub import {
>Index: lib/Log/Log4perl/Appender.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Appender.pm,v
>retrieving revision 1.11
>diff -a -u -r1.11 Appender.pm
>--- lib/Log/Log4perl/Appender.pm	20 Sep 2002 07:31:46 -0000	1.11
>+++ lib/Log/Log4perl/Appender.pm	29 Sep 2002 04:33:50 -0000
>@@ -2,14 +2,15 @@
> package Log::Log4perl::Appender;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> 
> use Log::Log4perl::Level;
> use constant DEBUG => 0;
> 
>-our $unique_counter = 0;
>+use vars qw($unique_counter);
>+
>+$unique_counter = 0;
> 
> ##################################################
> sub reset {
>Index: lib/Log/Log4perl/Config.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Config.pm,v
>retrieving revision 1.24
>diff -a -u -r1.24 Config.pm
>--- lib/Log/Log4perl/Config.pm	22 Sep 2002 18:16:56 -0000	1.24
>+++ lib/Log/Log4perl/Config.pm	29 Sep 2002 04:33:51 -0000
>@@ -2,9 +2,8 @@
> package Log::Log4perl::Config;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> 
> use Log::Log4perl::Logger;
> use Log::Log4perl::Level;
>@@ -25,7 +24,9 @@
>  FATAL  emergency
> );
> 
>-our $DEFAULT_WATCH_DELAY = 60; #seconds
>+use vars qw($DEFAULT_WATCH_DELAY);
>+
>+$DEFAULT_WATCH_DELAY = 60; #seconds
> 
> ###########################################
> sub init {
>Index: lib/Log/Log4perl/DateFormat.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/DateFormat.pm,v
>retrieving revision 1.5
>diff -a -u -r1.5 DateFormat.pm
>--- lib/Log/Log4perl/DateFormat.pm	8 Sep 2002 20:30:29 -0000	1.5
>+++ lib/Log/Log4perl/DateFormat.pm	29 Sep 2002 04:33:52 -0000
>@@ -1,10 +1,11 @@
> ###########################################
> package Log::Log4perl::DateFormat;
> ###########################################
>-use warnings;
> use strict;
> 
>-our $GMTIME = 0;
>+use vars qw($GMTIME);
>+
>+$GMTIME = 0;
> 
> my @MONTH_NAMES = qw(
> January February March April May June July
>Index: lib/Log/Log4perl/JavaMap.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/JavaMap.pm,v
>retrieving revision 1.8
>diff -a -u -r1.8 JavaMap.pm
>--- lib/Log/Log4perl/JavaMap.pm	6 Sep 2002 21:40:58 -0000	1.8
>+++ lib/Log/Log4perl/JavaMap.pm	29 Sep 2002 04:33:52 -0000
>@@ -3,7 +3,9 @@
> use Carp;
> use strict;
> 
>-our %translate = (
>+use vars qw(%translate);
>+
>+%translate = (
>     'org.apache.log4j.ConsoleAppender' => 
>         'Log::Log4perl::JavaMap::ConsoleAppender',
>     'org.apache.log4j.FileAppender'    => 
>Index: lib/Log/Log4perl/Level.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Level.pm,v
>retrieving revision 1.10
>diff -a -u -r1.10 Level.pm
>--- lib/Log/Log4perl/Level.pm	18 Sep 2002 04:33:28 -0000	1.10
>+++ lib/Log/Log4perl/Level.pm	29 Sep 2002 04:33:52 -0000
>@@ -2,10 +2,10 @@
> package Log::Log4perl::Level;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> use Carp;
>+use vars qw(%PRIORITY %LEVELS %SYSLOG);
> 
> # log4j, for whatever reason, puts 0 as all and MAXINT as OFF.
> # this seems less optimal, as more logging would imply a higher
>@@ -21,9 +21,9 @@
> no strict qw(refs);
> use vars qw(%PRIORITY %LEVELS);
> 
>-our %PRIORITY = (); # unless (%PRIORITY);
>-our %LEVELS = () unless (%LEVELS);
>-our %SYSLOG = () unless (%SYSLOG);
>+%PRIORITY = (); # unless (%PRIORITY);
>+%LEVELS = () unless (%LEVELS);
>+%SYSLOG = () unless (%SYSLOG);
> 
> sub add_priority {
>   my ($prio, $intval, $syslog) = @_;
>Index: lib/Log/Log4perl/Logger.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Logger.pm,v
>retrieving revision 1.32
>diff -a -u -r1.32 Logger.pm
>--- lib/Log/Log4perl/Logger.pm	19 Sep 2002 19:12:22 -0000	1.32
>+++ lib/Log/Log4perl/Logger.pm	29 Sep 2002 04:33:54 -0000
>@@ -2,31 +2,33 @@
> package Log::Log4perl::Logger;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> 
> use Log::Log4perl::Level;
> use Log::Log4perl::Layout;
> use Log::Log4perl::Appender;
> use Log::Dispatch;
> use Carp;
>-use Carp::Heavy;
> 
> use constant DEBUG => 0;
>+use vars qw($ROOT_LOGGER $LOGGERS_BY_NAME %APPENDER_BY_NAME $INITIALIZED
>+            $DISPATCHER $WATCH_DELAY $FILE_TO_WATCH $LAST_CHECKED_AT
>+            $LAST_CHANGED_AT
>+           );
> 
>     # Initialization
>-our $ROOT_LOGGER;
>-our $LOGGERS_BY_NAME = {};
>-our %APPENDER_BY_NAME = ();
>-our $INITIALIZED;
>-
>-our $DISPATCHER = Log::Dispatch->new();
>-
>-our $WATCH_DELAY;
>-our $FILE_TO_WATCH;
>-our $LAST_CHECKED_AT;
>-our $LAST_CHANGED_AT;
>+$ROOT_LOGGER;
>+$LOGGERS_BY_NAME = {};
>+%APPENDER_BY_NAME = ();
>+$INITIALIZED;
>+
>+$DISPATCHER = Log::Dispatch->new();
>+
>+$WATCH_DELAY;
>+$FILE_TO_WATCH;
>+$LAST_CHECKED_AT;
>+$LAST_CHANGED_AT;
> 
> __PACKAGE__->reset();
> 
>@@ -488,7 +490,7 @@
> 
>     my $which = Log::Log4perl::Level::to_level($priority);
> 
>-    $self->{$which}($self, @messages, 
>+    $self->{$which}->($self, @messages, 
>                     Log::Log4perl::Level::to_level($priority));
> }
> 
>@@ -578,7 +580,7 @@
>   *{__PACKAGE__ . "::$lclevel"} = sub {
>         print "$lclevel: ($_[0]->{category}/$_[0]->{level}) [@_]\n" if DEBUG;
>         init_warn() unless $INITIALIZED;
>-        $_[0]->{$level}(@_, $level);
>+        $_[0]->{$level}->(@_, $level);
>      };
> 
>   *{__PACKAGE__ . "::is_$lclevel"} = sub { 
>Index: lib/Log/Log4perl/TestBuffer.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/TestBuffer.pm,v
>retrieving revision 1.5
>diff -a -u -r1.5 TestBuffer.pm
>--- lib/Log/Log4perl/TestBuffer.pm	23 Sep 2002 16:45:43 -0000	1.5
>+++ lib/Log/Log4perl/TestBuffer.pm	29 Sep 2002 04:33:54 -0000
>@@ -10,7 +10,9 @@
> use base qw( Log::Dispatch::Output );
> use fields qw( stderr );
> 
>-our %POPULATION = ();
>+use vars qw(%POPULATION);
>+
>+%POPULATION = ();
> 
> ##################################################
> sub new {
>Index: lib/Log/Log4perl/Layout/PatternLayout.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Layout/PatternLayout.pm,v
>retrieving revision 1.15
>diff -a -u -r1.15 PatternLayout.pm
>--- lib/Log/Log4perl/Layout/PatternLayout.pm	25 Sep 2002 03:11:06 -0000	1.15
>+++ lib/Log/Log4perl/Layout/PatternLayout.pm	29 Sep 2002 04:33:55 -0000
>@@ -2,16 +2,17 @@
> package Log::Log4perl::Layout::PatternLayout;
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> use Log::Log4perl::Level;
> use Log::Log4perl::DateFormat;
> use File::Spec;
>+use vars qw($TIME_HIRES_AVAILABLE $TIME_HIRES_AVAILABLE_WARNED 
>+            $PROGRAM_START_TIME);
> 
>-our $TIME_HIRES_AVAILABLE;
>-our $TIME_HIRES_AVAILABLE_WARNED = 0;
>-our $PROGRAM_START_TIME;
>+$TIME_HIRES_AVAILABLE;
>+$TIME_HIRES_AVAILABLE_WARNED = 0;
>+$PROGRAM_START_TIME;
> 
> BEGIN {
>     # Check if we've got Time::HiRes. If not, don't make a big fuss,
>Index: lib/Log/Log4perl/Layout/SimpleLayout.pm
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/lib/Log/Log4perl/Layout/SimpleLayout.pm,v
>retrieving revision 1.4
>diff -a -u -r1.4 SimpleLayout.pm
>--- lib/Log/Log4perl/Layout/SimpleLayout.pm	19 Jul 2002 19:05:31 -0000	1.4
>+++ lib/Log/Log4perl/Layout/SimpleLayout.pm	29 Sep 2002 04:33:56 -0000
>@@ -5,9 +5,8 @@
> # http://jakarta.apache.org/log4j/docs/api/org/apache/log4j/SimpleLayout.html
> ##################################################
> 
>-use 5.006;
>+use 5.00503;
> use strict;
>-use warnings;
> use Log::Log4perl::Level;
> 
> no strict qw(refs);
>Index: t/002Logger.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/002Logger.t,v
>retrieving revision 1.15
>diff -a -u -r1.15 002Logger.t
>--- t/002Logger.t	10 Sep 2002 07:57:34 -0000	1.15
>+++ t/002Logger.t	29 Sep 2002 04:33:56 -0000
>@@ -5,7 +5,6 @@
> 
> #use Data::Dump qw(dump);
> 
>-use warnings;
> use strict;
> 
> #########################
>Index: t/003Layout.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/003Layout.t,v
>retrieving revision 1.19
>diff -a -u -r1.19 003Layout.t
>--- t/003Layout.t	25 Sep 2002 05:06:23 -0000	1.19
>+++ t/003Layout.t	29 Sep 2002 04:33:57 -0000
>@@ -3,7 +3,6 @@
> # Mike Schilli, 2002 (m...@pe...)
> ###########################################
> 
>-use warnings;
> use strict;
> 
> #########################
>@@ -33,7 +32,7 @@
> 
> ok($app->buffer(), "bugo % def.ghi " . 
>                    File::Spec->catfile(qw(t 003Layout.t)) .
>-                   "     32 hugo"); 
>+                   "     31 hugo"); 
> 
> ############################################################
> # Log the message
>@@ -111,7 +110,7 @@
> $logger->debug("That's the message");
> 
> ok($app->buffer(), File::Spec->catfile(qw(t 003Layout.t)) .
>-                   "-111 That's the message"); 
>+                   "-110 That's the message"); 
> 
> ############################################################
> # Don't append a newline if the message already contains one
>Index: t/010JConsole.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/010JConsole.t,v
>retrieving revision 1.5
>diff -a -u -r1.5 010JConsole.t
>--- t/010JConsole.t	24 Sep 2002 14:52:48 -0000	1.5
>+++ t/010JConsole.t	29 Sep 2002 04:33:57 -0000
>@@ -4,9 +4,9 @@
> use Test;
> 
> my $WORK_DIR = 't/tmp';
>-our @outfiles = ("$WORK_DIR/test1.log",);
>+my @outfiles = ("$WORK_DIR/test1.log",);
> unless (-e "$WORK_DIR"){
>-    mkdir "$WORK_DIR" || die "can't create $WORK_DIR $!";
>+    mkdir("$WORK_DIR", 0755) || die "can't create $WORK_DIR $!";
> }
> foreach my $f (@outfiles){
>     unlink $f if (-e $f);
>Index: t/011JFile.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/011JFile.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 011JFile.t
>--- t/011JFile.t	9 Jul 2002 07:45:39 -0000	1.3
>+++ t/011JFile.t	29 Sep 2002 04:33:57 -0000
>@@ -2,9 +2,9 @@
> use Test;
> 
> my $WORK_DIR = 't/tmp';
>-our @outfiles = ("$WORK_DIR/test2.log",);
>+my @outfiles = ("$WORK_DIR/test2.log",);
> unless (-e "$WORK_DIR"){
>-    mkdir "$WORK_DIR" || die "can't create $WORK_DIR $!";
>+    mkdir("$WORK_DIR", 0755) || die "can't create $WORK_DIR $!";
> }
> foreach my $f (@outfiles){
>     unlink $f if (-e $f);
>Index: t/012Deeper.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/012Deeper.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 012Deeper.t
>--- t/012Deeper.t	10 Jul 2002 19:58:22 -0000	1.3
>+++ t/012Deeper.t	29 Sep 2002 04:33:57 -0000
>@@ -9,7 +9,7 @@
> 
> my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
> my $today = sprintf("%4.4d%2.2d%2.2d",$year+1900, $mon+1, $mday);
>-our @outfiles = ("t/tmp/deeper1.log",
>+my @outfiles = ("t/tmp/deeper1.log",
>              "t/tmp/deeper6.log",
>              "t/tmp/deeper7.log",
>              );
>Index: t/016Export.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/016Export.t,v
>retrieving revision 1.6
>diff -a -u -r1.6 016Export.t
>--- t/016Export.t	10 Sep 2002 07:57:34 -0000	1.6
>+++ t/016Export.t	29 Sep 2002 04:33:57 -0000
>@@ -5,7 +5,6 @@
> # Mike Schilli, 2002 (m...@pe...)
> ###########################################
> 
>-use warnings;
> use strict;
> 
> #########################
>Index: t/017Watch.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/017Watch.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 017Watch.t
>--- t/017Watch.t	20 Sep 2002 18:45:14 -0000	1.3
>+++ t/017Watch.t	29 Sep 2002 04:33:57 -0000
>@@ -2,7 +2,6 @@
> 
> use Test;
> 
>-use warnings;
> use strict;
> 
> use Log::Log4perl;
>Index: t/018Init.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/018Init.t,v
>retrieving revision 1.1
>diff -a -u -r1.1 018Init.t
>--- t/018Init.t	3 Aug 2002 19:22:30 -0000	1.1
>+++ t/018Init.t	29 Sep 2002 04:33:58 -0000
>@@ -2,7 +2,6 @@
> 
> use Test;
> 
>-use warnings;
> use strict;
> 
> use Log::Log4perl;
>Index: t/019Warn.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/019Warn.t,v
>retrieving revision 1.2
>diff -a -u -r1.2 019Warn.t
>--- t/019Warn.t	4 Aug 2002 20:01:40 -0000	1.2
>+++ t/019Warn.t	29 Sep 2002 04:33:58 -0000
>@@ -1,6 +1,5 @@
> # Check if warnings are issued for weirdo configurations
> 
>-use warnings;
> use strict;
> 
> use Test;
>Index: t/020Easy.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/020Easy.t,v
>retrieving revision 1.2
>diff -a -u -r1.2 020Easy.t
>--- t/020Easy.t	25 Sep 2002 04:54:01 -0000	1.2
>+++ t/020Easy.t	29 Sep 2002 04:33:58 -0000
>@@ -1,6 +1,5 @@
> # Tests for the lazy man's logger with easy_init()
> 
>-use warnings;
> use strict;
> 
> use Test;
>Index: t/021AppThres.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/021AppThres.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 021AppThres.t
>--- t/021AppThres.t	22 Sep 2002 18:37:17 -0000	1.3
>+++ t/021AppThres.t	29 Sep 2002 04:33:58 -0000
>@@ -3,7 +3,6 @@
> # Mike Schilli, 2002 (m...@pe...)
> ###########################################
> 
>-use warnings;
> use strict;
> 
> use Test;
>Index: t/022Wrap.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/022Wrap.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 022Wrap.t
>--- t/022Wrap.t	11 Aug 2002 00:08:06 -0000	1.3
>+++ t/022Wrap.t	29 Sep 2002 04:33:58 -0000
>@@ -2,7 +2,6 @@
> # Tests for Log4perl used by a wrapper class
> # Mike Schilli, 2002 (m...@pe...)
> ###########################################
>-use warnings;
> use strict;
> 
> use Test;
>@@ -14,8 +13,9 @@
> 
> use Log::Log4perl;
> use Log::Log4perl::Level;
>+use vars qw(@ISA);
> 
>-our @ISA = qw(Log::Log4perl);
>+@ISA = qw(Log::Log4perl);
> 
> sub get_logger {
>     # This is highly stupid (object duplication) and definitely not what we 
>Index: t/023Date.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/023Date.t,v
>retrieving revision 1.7
>diff -a -u -r1.7 023Date.t
>--- t/023Date.t	22 Sep 2002 18:37:17 -0000	1.7
>+++ t/023Date.t	29 Sep 2002 04:33:58 -0000
>@@ -3,7 +3,6 @@
> # Mike Schilli, 2002 (m...@pe...)
> ###########################################
> 
>-use warnings;
> use strict;
> 
> use Test;
>Index: t/024WarnDieCarp.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/024WarnDieCarp.t,v
>retrieving revision 1.2
>diff -a -u -r1.2 024WarnDieCarp.t
>--- t/024WarnDieCarp.t	10 Sep 2002 07:57:34 -0000	1.2
>+++ t/024WarnDieCarp.t	29 Sep 2002 04:33:59 -0000
>@@ -14,7 +14,6 @@
> #
> ######################################################################
> 
>-use warnings;
> use strict;
> 
> use Test::Simple tests => 49;
>Index: t/026FileApp.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/026FileApp.t,v
>retrieving revision 1.1
>diff -a -u -r1.1 026FileApp.t
>--- t/026FileApp.t	14 Sep 2002 18:45:19 -0000	1.1
>+++ t/026FileApp.t	29 Sep 2002 04:33:59 -0000
>@@ -2,7 +2,6 @@
> 
> use Test;
> 
>-use warnings;
> use strict;
> 
> use Log::Log4perl;
>Index: t/027Watch2.t
>===================================================================
>RCS file: /cvsroot/log4perl/Log-Log4perl/t/027Watch2.t,v
>retrieving revision 1.3
>diff -a -u -r1.3 027Watch2.t
>--- t/027Watch2.t	23 Sep 2002 16:49:29 -0000	1.3
>+++ t/027Watch2.t	29 Sep 2002 04:33:59 -0000
>@@ -4,7 +4,6 @@
> 
> use Test;
> 
>-use warnings;
> use strict;
> 
> use Log::Log4perl;
>  
>

[log4perl-devel] 5005 handling

[<msc...@ao...>]

Hi all,

just modified Makefile.PL to detect perl 5.005 -- in this case it'll call a script (eg/5005it) which will go through the distribution and will take care of the compatibility issues (replace 'our' by 'use vars' etc.). For 5.6.0 and above, we can still use "our" and friends ...

-- 
-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

[log4perl-devel] Log::Log4perl Patch for perl 5.005_03

[Mike S. <m...@pe...>]

Hi all,

I can't believe I'm doing this -- but I today I thought: Why not do something totally crazy? 

So, I sat down and changed a couple of files in Log::Log4perl to run with 5.005_03. It was easier
than I thought at first.

Eric pointed out correctly that the modules we're using are indeed supported for perl 5.005_03
(Log::Dispatch, Test::Simple, etc.). All that I needed to change is replace "our" by "use vars", get
rid of "use warnings" and change calls like 

    $self->{$which}($self, ...)

to 

    $self->{$which}->($self, ...)

(which is probably the right thing to do anyway) and, boom, test suite passes.

Can you two 5.005_03 enthusiasts (Eric and asc) please try out the patch attached to this email?
Should be as easy as grabbing the latest Log::Log4perl 0.24 and do

    cd Log-Log4perl-0.24
    patch -p0 <../patch.500503.txt

Please let me know if it works for you ... and then we'll have to decide if we can work against our
beliefs and make Log::Log4perl compatible with 5.005_03 :).

-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

[log4perl-devel] Log::Log4perl 0.24 uploaded to CPAN

[Mike S. <m...@pe...>]

Hi all,

just uploaded Log::Log4perl 0.24 to CPAN. Features in this release:

0.24 09/26/2002
    * (kg) Fix for init_and_watch and test cases
    * (ms) Added documentation for Log::Log4perl::Config
    * (ms) Added log4perl.additivity.loggerName conf file syntax
    * (ms) Assume Log::Log4perl::Layout prefix of 'relative'
           layout class names in conf file (say 'SimpleLayout'
           instead of 'Log::Log4perl::Layout::SimpleLayout').
    * (ms) accidently appending a ';' at the end of an appender
      class in a conf file now spits out a reasonable error message
    * (ms) added a by_name() method to TestBuffer to retrieve an
           instance of the TestBuffer population by name instead of
           relying on the order of creation via POPULATION[x]
           (for testing only).
    * (kg) Win32 compatibility fixes

-- Mike

Mike Schilli
log...@pe...
http://log4perl.sourceforge.net

[log4perl-devel] =?GB2312?B?u7bTrbniwdnOwtbdyczStc34?=

[<web...@wz...>]

<html>
<head>
<title>0</title>
<meta http-equiv="Content-Type" content="text/html; charset=gb2312">
<script language="JavaScript">
<!--
function MM_goToURL() { //v3.0
  var i, args=MM_goToURL.arguments; document.MM_returnValue = false;
  for (i=0; i<(args.length-1); i+=2) eval(args[i]+".location='"+args[i+1]+"'");
}
//-->
</script>
</head>

<body bgcolor="#FFFFFF" text="#000000" onLoad="MM_goToURL('parent','http://www.wzbm.com');return document.MM_returnValue" leftmargin="0" topmargin="0">
<table width="100%" border="0">
  <tr>
    <td height="634" onMouseOver="MM_goToURL('parent','http://www.wzbm.com');return document.MM_returnValue">&nbsp;</td>
  </tr>
</table>
</body>
</html>

Re: [log4perl-devel] Log::Log4perl 0.24beta released

[Kevin G. <ke...@go...>]

With the outstanding bug in the init_and_watch() code, can we release it 
sooner rather than later?


msc...@ao... wrote:
> Hi all,
> 
> just released 0.24beta on the log4perl.sourceforge.net site. Please download it, try it out and report any bugs -- if all goes well, we can release it to CPAN in a couple of days.
> 
> -- Mike
> 
> ############################
> # Mike Schilli             #
> # log...@pe... #
> # http://perlmeister.com   #
> # log4perl.sourceforge.net #
> ############################
> 
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> log4perl-devel mailing list
> log...@li...
> https://lists.sourceforge.net/lists/listinfo/log4perl-devel


-- 
Happy Trails . . .

Kevin M. Goess
(and Anne and Frank)
904 Carmel Ave.
Albany, CA  94706
(510) 525-5217

[log4perl-devel] =?GB2312?B?u7bTrbniwdnOwtbdyczStc34?=

[<web...@wz...>]

温州商业网能让你抓住稍微纵既逝的商机
URL:http://www.wzbm.com
URL:http://www.wzbm.net

Re: [log4perl-devel] Rotating log files

[Pfeiffer, M. (EDS) <mar...@ed...>]

Ok, I have some code to put up that looks like it works reasonably well.
I'm not saying it is good code only the bits I stole from Dave Rolsky :-)
It still needs some more doco and some fancy bits but it is ready for you
guys to look at and comment.

I don't have a Makefile yet and I don't have a CPAN account. I'll try and
get that done early next week and put the code up.

If you're interested in commenting before that time drop me an email in the
next little while (as I'm going away over the weekend) and I'll email the
code to you. It isn't large 250 lines including Dave's pod.

This was a joy to do I must say. The architecure is very flexibile and
understandable. Great job people!

cheers
mark

[log4perl-devel] Log::Log4perl 0.24beta released

[<msc...@ao...>]

Hi all,

just released 0.24beta on the log4perl.sourceforge.net site. Please download it, try it out and report any bugs -- if all goes well, we can release it to CPAN in a couple of days.

-- Mike

############################
# Mike Schilli             #
# log...@pe... #
# http://perlmeister.com   #
# log4perl.sourceforge.net #
############################

Re: [log4perl-devel] Rotating log files

[Pfeiffer, M. (EDS) <mar...@ed...>]

On Wed, 25 Sep 2002 19:54:02 EDT Msc...@ao...'s good news was:
  > 
  > In a message dated 9/25/02 4:21:35 PM Pacific Daylight Time,
  > mar...@ed... writes: 
  > 
  > I'll have a little look at Log::Dispatch and some of its sub-classes to 
  > see how it works. 
  > 
  > 
  > Also, the Java implementation shows some interesting ideas: 
  > 
  >  
  > http://jakarta.apache.org/log4j/docs/api/org/apache/log4j/RollingFileApp
  > ender.html 
  > 
  > Not that I'm implying you should provide the same interface, though :) 
  > 
Ok I'll look at that as well ;-)

cheers
mark