Re: [Log4cpp-devel] CategoryStream::ENDLINE enum

[Gary G. <gr...@uc...>]

Konstantin Litvinenko wrote:
> Hello All!
> 
>     Scott Cantor has pointed out problem with CategoryStream::eol enum 
> member and free function eol on Solaris. Looking on the code I can see FOUR 
> enumeration members for end of line 'separators'. In the same time we have 
> std-like manipulators for CategoryStream. I don't see reasons why we need 
> two different way to do one thing. Can we just remove this enum in favour of 
> std-like manipulators?

I think it's ok to remove the enum, or at least the 'eol' enum, if
that's really what is causing the problem.  It's at the very least
confusing that CategoryStream right now has two eol symbols.  Would
CategoryStream::eol refer to the manipulator or the enum?  If the
Separator enum is removed, we will need to fix some of our code.  That's
ok, though, because I agree that using the manipulators exclusively
would be more consistent and more standard, plus they would be more
extensible later on.

gary