Re: [Log4cpp-devel] A note regarding Shibboleth use of log4cpp

[Scott C. <can...@os...>]

> I have commited localtime_r fix and pthread support. I check build on
> Fedora 7. Please check on non Linux to be sure that everything is OK. I am
> as blind with all this autotools, configure and others so mistakes are
> assumed.

Well, there are a couple of issues:

Not all of my changes are there, and all of them were done for a reason. For
example, the language isn't correctly set to C or C++ in the right places to
ensure the tests run correctly. The existing script uses C++ prematurely,
which fails on most platforms, rather that starting with C and then
switching for the C++ tests.

Lastly, and more importantly, I don't believe my use of the thread macros is
compatible with the existing macros that are still being called:

BB_CHECK_OMNITHREADS
BB_CHECK_PTHREADS

The second one probably overlaps and the first one would probably break. I
commented them out in my version because I don't know what OMNITHREADS is
and my code can't allow it anyway, so I didn't need to support it.

If you're trying to support that and pthreads properly, there's more work
required, and some testing that I couldn't do. If not, you just comment them
out and it requires pthreads be used. The current script with part of my
changes is already blocking use of any option other than pthreads, in fact,
which is not necessarily what you want.

For reference, the diff I ran is below with the changes that matter left in.

-- Scott

# diff configure.in ~/src/log4cpp-0.3.5rc1/configure.in 
49a50,54
> if test "$GCC" = "yes" ; then
>     CFLAGS="$GCC_CFLAGS"
>     CXXFLAGS="$GCC_CXXFLAGS"
> fi
> 
51c56
< AC_LANG(C++)
---
> AC_LANG(C)
61d65
< AC_CXX_HAVE_SSTREAM
89a89,92
> AC_LANG(C++)
> 
> AC_CXX_HAVE_SSTREAM
> 
103,104c106,107
< BB_CHECK_OMNITHREADS
< BB_CHECK_PTHREADS
---
> #BB_CHECK_OMNITHREADS
> #BB_CHECK_PTHREADS