Re: [Log4cpp-devel] 0.3.3 released

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi Mohamad,

Thanks for the reports:

A) I've committed your suggestions. I don't know whether old code was
standard C++ compliant, but having both trim() methods return the same 
type is cleaner anyway.

B) I don't know. If MSVC gives warning, that should signify something,
right? :-) Since it doesn't break the build, I'll let it be, unless
you're really sure that the #pragma is OK.

C) That's a fix, not a workaround! I noticed it just before receiving
your mail, so it has already been commited.

Thanks,

Bastiaan

PS. To make the MSVC6 users happy I'll release 0.3.4 immediately.

On Mon, 2002-10-28 at 22:44, Daniar, Mohamad wrote:
> A. 
> 
> c:\CVS\0.3.3\log4cpp\src\StringUtil.hh(78) : error
> C2785: 'unsigned int log4cpp::StringUtil::split(T
> &,const std::string &,char,unsigned int)' and 'void
> log4cpp::StringUtil::split(std::vector<_Ty,_Ax>
> &,const std::string &,char,unsigned int)' have
> different return types
>         with
>         [
>             _Ty=std::string,
>             _Ax=std::allocator<std::string>
>         ]
> c:\CVS\0.3.3\log4cpp\src\StringUtil.hh(62) : see
> declaration of 'log4cpp::StringUtil::split'
> c:\CVS\0.3.3\log4cpp\src\StringUtil.hh(49) : see
> declaration of 'log4cpp::StringUtil::split'
> c:\CVS\0.3.3\log4cpp\src\StringUtil.cpp(45) : warning
> C4018: '<' : signed/unsigned mismatch
> 
> [mdaniar] Possible workaround : Should both of them
> return unsigned int ?
> 
> 
> B. 
> 
> c:\CVS\0.3.3\log4cpp\include\log4cpp\Configurator.hh(21)
> : warning C4275: non dll-interface class
> 'std::runtime_error' used as base for dll-interface
> class 'log4cpp::ConfigureFailure'
> c:\Program Files\Microsoft Visual Studio
> .NET\Vc7\include\stdexcept(137) : see declaration of
> 'std::runtime_error'
> c:\CVS\0.3.3\log4cpp\include\log4cpp\Configurator.hh(21)
> : see declaration of 'log4cpp::ConfigureFailure'
> 
> [mdaniar] Possible workaround :  #pragma
> warning(disable : 4275)
> 
> C. 
> 
> testPattern.cpp
> c:\CVS\0.3.3\log4cpp\tests\testPattern.cpp(16) : error
> C2039: 'cerr' : is not a member of 'std'
> c:\CVS\0.3.3\log4cpp\tests\testPattern.cpp(16) : error
> C2065: 'cerr' : undeclared identifier
> c:\CVS\0.3.3\log4cpp\tests\testPattern.cpp(16) : error
> C2296: '<<' : illegal, left operand has type
> ''unknown-type''
> c:\CVS\0.3.3\log4cpp\tests\testPattern.cpp(16) : error
> C2297: '<<' : illegal, right operand has type 'char
> [20]'
> 
> [mdaniar] Possible workaround :  include #iostream in
> testPattern.cpp
> 
> 
> thanks,
> 
> Mohamad
> 
> --- Bastiaan Bakker <bas...@li...>
> wrote:
> > Hi Mohamad,
> > 
> > Thanks for the quick report.
> > * The compile errors in PatternLayout.cpp are caused
> > by initializing
> > static constant strings at declaration point, which
> > GCC accepts, but is
> > not standards compliant C++. I think I should switch
> > to GCC 3.2 as
> > primary development compiler, as it gives a proper
> > warning for it when
> > compiling with '-pedantic'. 
> > I've moved the definition of these strings outside
> > the class declaration
> > to fix the comile problem.
> > 
> > * PortabilityImpl.cpp was not committed to CVS yet,
> > but it is not part
> > of 0.3.3: I added it after the 0.3.3 release. I
> > guess you checked out
> > CVS HEAD, rather than REL_0_3_3. I've added it now.
> > 
> > * BasicConfigurator was misssing from both the MSVC
> > and BCB5 project
> > files. I've added it now. In the long term I like to
> > have a mechanism to
> > update them automatically if a file is added to the
> > automake files.
> > Having to update 6(!) project files for the addition
> > of one source file
> > is no fun. Suggestions or code to alleviate this
> > problem are very
> > welcome....
> > 
> > * MSVC7 compile problems: please mail them....
> > 
> > Thanks,
> > 
> > Bastiaan
> > 
> >  
> > On Sun, 2002-10-27 at 13:22, Daniar, Mohamad wrote:
> > > Hi :
> > > Downloaded 0.3.3 through CVS,
> > > 
> > > Got this error for log4cpp.lib,
> > > d:\log4cpp\src\patternlayout.cpp(127) : error
> > C2258:
> > > illegal pure syntax, must be '= 0'
> > > d:\log4cpp\src\patternlayout.cpp(127) : error
> > C2252:
> > > 'FORMAT_ISO8601' : pure specifier can only be
> > > specified for functions
> > > d:\log4cpp\src\patternlayout.cpp(128) : error
> > C2258:
> > > illegal pure syntax, must be '= 0'
> > > d:\log4cpp\src\patternlayout.cpp(128) : error
> > C2252:
> > > 'FORMAT_ABSOLUTE' : pure specifier can only be
> > > specified for functions
> > > d:\log4cpp\src\patternlayout.cpp(129) : error
> > C2258:
> > > illegal pure syntax, must be '= 0'
> > > d:\log4cpp\src\patternlayout.cpp(129) : error
> > C2252:
> > > 'FORMAT_DATE' : pure specifier can only be
> > specified
> > > for functions
> > > PortabilityImpl.cpp
> > > fatal error C1083: Cannot open source file:
> > > 'D:\log4cpp\src\PortabilityImpl.cpp': No such file
> > or
> > > directory 
> > > 
> > > Had to add BasicConfigurator.cpp / .hh in
> > log4cpp.dsp
> > > 
> > > btw:
> > > Tried to compile it using Visual C++ 7,
> > > Seems like MS fix the std:: problem (no need to
> > > workaround)
> > > but there's some new warnings and error, will mail
> > > them if interested. 
> > > 
> > > 
> > > thanks,
> > > 
> > > 
> > > Mohamad
> > > 
> > > --- Bastiaan Bakker <bas...@li...>
> > > wrote:
> > > > Hi,
> > > > 
> > > > I've put 0.3.3 on SourceForge. It's a relatively
> > > > small update to 0.3.2,
> > > > the two most important changes are:
> > > > * build fixes for MSVC. 0.3.3 introduces
> > > > PortabilityImpl.hh, an internal
> > > > header file for portibality stuff that should
> > not be
> > > > part of the API. It
> > > > contains aliases in namespace 'std' for the
> > > > functions in <cstlib> and
> > > > <cstring> we use but MSVC mistakenly puts in the
> > > > global namespace. 
> > > > * a new PatternLayout implementation. It
> > preparses
> > > > the conversionpattern
> > > > into a vector of PatternComponents. This should
> > make
> > > > it speedier and
> > > > more flexible. PatternLayout now also support
> > > > formatting specifiers like
> > > > '%-5.5p'.
> > > > 
> > > > Please report any bugs/problems through the
> > normal
> > > > channels (bug tracker
> > > > or mailing list).
> > > > 
> > > > Cheers,
> > > > 
> > > > Bastiaan
> > > >  
> > > > 
> > > > 
> > > > 
> > > > 
> > > > 
> > > >
> > >
> >
> -------------------------------------------------------
> > > > This SF.net email is sponsored by: ApacheCon,
> > > > November 18-21 in
> > > > Las Vegas (supported by COMDEX), the only Apache
> > > > event to be
> > > > fully supported by the ASF.
> > http://www.apachecon.com
> > > > _______________________________________________
> > > > Log4cpp-devel mailing list
> > > > Log...@li...
> > > >
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/log4cpp-devel
> > > 
> > > 
> > > __________________________________________________
> > > Do you Yahoo!?
> > > Y! Web Hosting - Let the expert host your web site
> > > http://webhosting.yahoo.com/
> > > 
> > > 
> > >
> >
> -------------------------------------------------------
> > > This SF.net email is sponsored by: ApacheCon,
> > November 18-21 in
> > > Las Vegas (supported by COMDEX), the only Apache
> > event to be
> > > fully supported by the ASF.
> > http://www.apachecon.com
> > > _______________________________________________
> > > Log4cpp-devel mailing list
> > > Log...@li...
> > >
> >
> https://lists.sourceforge.net/lists/listinfo/log4cpp-devel
> > 
> > 
> > 
> > 
> >
> -------------------------------------------------------
> > This SF.net email is sponsored by: ApacheCon,
> > November 18-21 in
> > Las Vegas (supported by COMDEX), the only Apache
> > event to be
> > fully supported by the ASF. http://www.apachecon.com
> > _______________________________________________
> > Log4cpp-devel mailing list
> > Log...@li...
> >
> https://lists.sourceforge.net/lists/listinfo/log4cpp-devel
> 
> 
> __________________________________________________
> Do you Yahoo!?
> Y! Web Hosting - Let the expert host your web site
> http://webhosting.yahoo.com/