These are replaced on master branch only, because master is C++11 based. Existing branches have to stay compatible with C++03 and thus it cannot be replaced.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Nope. unique_ptr<> is not part of that standard. There is one in Boost but log4cplus' philosophy is not to depend on such huge dependency for core functionality.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Maybe one way would be to use a #define to redefine auto_ptr as unique_ptr if the version of C++ in use is high enough. I don't like macros, but this was just a though.
I tried to do something similar but IIRC there was a subtle issue in semantics. It is not 1:1 replacement. The master branch already uses only unique_ptr<>.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
--- old+++ new@@ -1,4 +1,3 @@-
warning: ‘auto_ptr’ is deprecated (declared at /usr/include/c++/4.7/backward/auto_ptr.h:87) [-Wdeprecated-declarations]
Are you planning to replace auto_ptr entries?
status: open --> wont-fix
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
These are replaced on master branch only, because master is C++11 based. Existing branches have to stay compatible with C++03 and thus it cannot be replaced.
Don't we have unique_ptr<> in C++03?
Nope.
unique_ptr<>
is not part of that standard. There is one in Boost but log4cplus' philosophy is not to depend on such huge dependency for core functionality.Maybe one way would be to use a #define to redefine auto_ptr as unique_ptr if the version of C++ in use is high enough. I don't like macros, but this was just a though.
I tried to do something similar but IIRC there was a subtle issue in semantics. It is not 1:1 replacement. The master branch already uses only
unique_ptr<>
.Diff: