Re: [Lmuse-developer] [VERIFIED] 2 bugs in drum editor

[termtech <ter...@ro...>]

On Wednesday, January 4, 2017 5:30:13 PM EST Michael Oswald wrote:
> Hi Tim,
> 
> > Also, in your first message I'm unable to reproduce the
> > 
> >  importing bug thing. I'll keep trying though.
> > 
> > I hate to ask, but... video?
> > Seems impossible that moving a part onto a drum track would
> > 
> >  suddenly 'GM-ify' the track's drum map permanently.
> > 
> > Check that the track's patch (program) number really does
> > 
> >  correspond to a patch that the drum map is for.
> > 
> > If all else fails, try 'reset track's drum list'.
> 
> I did some more research and what looks weird to me is that the drummap
> file is different and lacks information.
> 
> E.g. old drummap from 2.2.1:
>    <entry>
>        <name>Kick Emad Head</name>
>       <vol>100</vol>
>        <quant>16</quant>
>        <len>32</len>
>        <channel>-1</channel>
>        <port>-1</port>
>        <lv1>70</lv1>
>        <lv2>90</lv2>
>        <lv3>110</lv3>
>        <lv4>127</lv4>
>        <enote>36</enote>
>        <anote>36</anote>
>        </entry>
>      <entry>
>        <name>PantherSnareCentre</name>
>        <vol>100</vol>
>        <quant>16</quant>
>        <len>32</len>
>        <channel>-1</channel>
>        <port>-1</port>
>        <lv1>70</lv1>
>        <lv2>90</lv2>
>        <lv3>110</lv3>
>        <lv4>127</lv4>
>        <enote>38</enote>
>        <anote>38</anote>
>        </entry>
> 
> The problematic drummap:
> 
> 
>   <entry idx="36">
>        <name>Kick Emad</name>
>      </entry>
>      <entry idx="37">
>        <name>PSnare Sidestick</name>
>      </entry>
>      <entry idx="38">
>        <name>PSnare Centre</name>
>      </entry>
> 
> So the whole information didn't get stored somehow.

I made it that way. If you save a drum map it only stores
 what you /changed/ in the map. Default instrument entries
 will 'peer through' the unaltered entries.

Before you throw up a yellow card, yes it would have been nice 
 to store the 'whole complete' drum map even with unaltered entries.
But... When I sat down to do that (I tried it), I realized it would 
 have meant storing /all/ entries for /all/ patches everywhere, 
 ie. the 'complete' drum map ie. when you reload it, all entries
 on all patches are bold text. 
What to do: If you really want all the entries and all information
 stored for one or more patches...
 try ...
 
Oops, sorry, I meant to add some menu entries:  "Set whole patch", 
 "Set field", and "Set row", to compliment the "Set column" and
 "Promote to default patch".
You'll select "Set whole patch" to set the whole map for /this/ patch 
 (bold text), while "Promote to default patch" sets it for any patch.
Then you'll save it. Sound good?

Give me some time to complete some unfinished business there.
I'll try to make it better ;-)


> I have now played around a bit and it seems that if I store it from the
> track view with right click on track and save drumlist, it hasn't the
> full information inside and cannot be loaded, hence the default (GM) is
> kept.
> 
> Weird is that sometimes it does load the new map and sometimes it
> doesn't and just keeps GM (I had both cases today).

As per above, it's because it is loading only what was changed and 
 the rest are the GM map entries 'peering out from behind'
 (or the map from whatever instrument is chosen - GM2, XG etc). 
That's why I say I should allow to set the whole map bold text.

> Not a bug, but a question:
> As you can see also in the videos I connected the drumgizmo outputs to
> different wave tracks, that works fine.
> Just I need to have the record button armed on the tracks to hear the
> actual drums (input monitoring). This is not a problem for only drum
> editing, but could be a problem when I want to record another track as
> the drums would also be recorded.
> Ardour has the "In" button for this prupose, for directly monitoring the
> input of a track, but I haven't found anything similar in MusE. Is there
> a possibility to just monitor the input to wave tracks?
> 
> Alternative is to use outs but then the routing gets a bit more
> complicated because of mono/stereo outputs and also when finished with
> MIDI editing for recording the result to audio this needs to be changed
> back to wave tracks somehow.

Good call. I'm surprised no one has ever mentioned this.

If I read that correctly, we have a similar problem with our Midi Tracks.
We need something to monitor the input /without/ record arming !

I have some recent, disabled code in MusE which does that !
For audio and midi tracks, but it's not quite right.
I just could not find a way to make it work without adding another
 button, likely called "monitor", with yet another Track class member. 
Without that, monitoring was on all the time. Not good.

My struggle was where to put it on each mixer strip. 
(Just /one/ odd new button in a symmetrical strip with a cluster
 of four big square mute, solo, rec, and off buttons... ugh...)
Also it needs a new column in the Arranger track list.

++ Fully agree. We do need it :-)
Gimme some time, maybe I can squeeze it in for 3.0 ?

Now, where on the strips do we put this new 'monitor' button...
Any suggestions?

Cheers.
Tim.