From: G. B. <ge...@la...> - 2012-01-27 12:00:01
|
Yeah, go ahead... You know you want to ;) Sent from my HTC ----- Reply message ----- From: "Robert Jonsson" <spa...@gm...> To: "Florian Jung" <flo...@we...> Cc: <lmu...@li...> Subject: [Lmuse-developer] Song Length. again. Date: Fri, Jan 27, 2012 9:13 pm Hi Florian, 2012/1/27 Florian Jung <flo...@we...>: > Hi > > why again do we have that song length spinbox? I think it's an artefact from way way way way back. For me it has no use. I've grown used to that it automatically stops playback when the song is "over". But I can definitely live without this, the drawbacks are bigger than the benefits. > > i looked through the code; the song length is only used for clipping > (that is, e.g. ignoring parts which are outside the song when selecting > with the arrow buttons), and for setting up scrollbars. > > i think we really can remove this: the only changes need to be: > when scrolling to the end of a scrollbar, the end-of-song should not be > at the RIGHT window border but at the LEFT (that is, only very few > pixels of the song should be actually visible). this allows you to add > stuff after the end of the song which is usually what we use that > spinbox for. > and: there will be no parts "outside" the song. everything which is > there /is there/. so include it in the song, or let the user delete it. > you really don't want to "hide" parts by shrinking the song oO. rather > mute or delete it. > > then, we of course remove the song spinbox, and instead let > song->update() update the song length to the end of the last part. > (iterate through all parts and find the maximum of part->endTick()). Ah, yes, that might be a solution to still make it stop. > agreed? > or is there any real use for that spinbox i've missed? it's so annoying -_- Can't think of anything else... I suggest giving it a shot :) Regards, Robert ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Lmuse-developer mailing list Lmu...@li... https://lists.sourceforge.net/lists/listinfo/lmuse-developer |