[Lmuse-developer] Song Length. again.

[Florian J. <flo...@we...>]

Hi

why again do we have that song length spinbox?

i looked through the code; the song length is only used for clipping 
(that is, e.g. ignoring parts which are outside the song when selecting 
with the arrow buttons), and for setting up scrollbars.

i think we really can remove this: the only changes need to be:
when scrolling to the end of a scrollbar, the end-of-song should not be 
at the RIGHT window border but at the LEFT (that is, only very few 
pixels of the song should be actually visible). this allows you to add 
stuff after the end of the song which is usually what we use that 
spinbox for.
and: there will be no parts "outside" the song. everything which is 
there /is there/. so include it in the song, or let the user delete it. 
you really don't want to "hide" parts by shrinking the song oO. rather 
mute or delete it.

then, we of course remove the song spinbox, and instead let 
song->update() update the song length to the end of the last part. 
(iterate through all parts and find the maximum of part->endTick()).

agreed?
or is there any real use for that spinbox i've missed? it's so annoying -_-

greetings
flo