Re: [Lmuse-developer] Bugs

[Tim E. R. <ter...@ro...>]

> On Thu, Sep 29, 2011 at 6:11 PM, Tim E. Real wrote:
> >> >> And, what is a configuration file doing in the templates folder?
> >> >> I remember some brief discussion about this but it went by
> >> >>   quickly so I missed it.
> >> >> There should be no such files in templates!
> >> >>
> >> well, i thought of it as a "configuration template", so i put it into
> >> templates.
> > OK. But try to move it into its own folder.
> > Template folder is reserved for song templates only.
> >
> 
> While I was playing with the colors the other week, I noticed
> something strange. We have the defaults (e.g. for colors) defined in
> gconfig.cpp. But replacing the color codes in gconfig.cpp,
> recompiling/reinstalling muse, removing the config file from
> ~/.config/MusE/MusE.cfg and running muse did not seemed to make the
> new colors to take effect.
> 
> What actually was happening was the color codes in the "configuration
> template" were taken into effect. Indeed when I browse our very "int
> main()" function in main.cpp, I see that the template file MusE.cfg is
> being copied into ~/.config/MusE/ (commit 1112). This renders the
> defaults in gconfig.cpp invalid.
> 
> Flo, what is the motivation in copying the  "configuration template"
> over? 
> Should we get rid of the defaults in gconfig.cpp?

[Scratches chin] Hm, you can't, really.
One cannot gaurantee that 
a) Such a template file will be found, loadable, and fully intact.
b) That whoever adds new members to the config struct will
 remember to put defaults into the config template file. (OK, weak point.)

Some kind of sane initial defaults are helpful in the struct definition.
OTOH Having two sets of defaults like that and remembering to sync them...
I suppose we'll just have to do it. Don't see a problem.

Was thinking: Maybe Flo's on to something.
What about multiple configs, and multiple default configs?
Was thinking mostly of colours. User can choose some default
 colour schemes from config templates. User can save configs 
 with different filenames and load them later. 
I know, that's heading into style, theme, and stylesheet ugly territory... 
Still, these are the absolute colours used ATM, and only one config set!


Tim.

> 
> Cheers,
> Orcan
>