Re: [Lmuse-developer] [Bulk] Re: features my score editor needs in muse and questions

[Tim E. R. <ter...@ro...>]

On March 31, 2011 01:20:38 pm Florian Jung wrote:
> thanks tim, that was a really comprehensible explanation
>
> the only thing i don't fully understand is the "doClones". Is there any
> case where doCtrls=true, but doClones=false, or vice versa? because,
> either you modify controllers, then both should be true, or you don't,
> then both should be false. or did i get that wrong?

Good question. I reviewed the usage to see if I can re-simplify.

I didn't find any msgChangeEvent where the two flags were different.
But I did find ONE differing msgAddEvent and ONE msgDeleteEvent in 
 DrumCanvas::mapChanged, and several differing msgChangePart.

That covers all usages of my two flags in those FOUR methods.

I guess those are the pesky usages that made me add two flags!

Likely by adding two flags to msgChangeEvent, I was anticipating usage
 which never happened.
 
Also, I should have mentioned I *think* the flags also are meant to be used
 similar to the 'doUndo', in that they're OK for single, but groups of
 changes should use the mechanisms similar to what I mentioned for doUndo.   
i.e. Kind of like for groups of changes, do whatever those two flags usually 
 cause  to be done - except outside of the loop of that group of calls. 
Some of this is about speed opts, preventing redundant downstream calls 
 when they could be done outside of some loop...
My example of the controller canvas might not be so good, I forgot to check 
 this!

Tim.

>
> greetings
> flo
>