Re: [LMMS-devel] CSS & palette...

[Vesa <di...@nb...>]

On 04/11/2014 04:02 PM, Tres Finocchiaro wrote:
>
>     so that palette colours can now be defined with proper CSS syntax,
>     instead of the string-regexp-hack we had earlier.
>
>
> You mean this syntax?   rgb(0, 0, 0);
>

Any CSS syntax. CSS has multiple ways of defining colours:

#000
#000000
black
rgb( 0,0,0 )

The current implementation in 1.0 is error-prone and hacky: it only
allows hex triplets, because it reads the palette by doing string
matching with regexp and looking for the string "palette:", then looking
for a # symbol on the same line and reading the six character next to
it. It doesn't actually use CSS, it's simply a CSS-looking thing
embedded in a CSS file. Like I said, a quick and dirty hack to get the
palette modifiable...

The new implementation uses qproperties and a special palette class
LmmsPalette, so the palette can be more easily defined in CSS, with
real, actual CSS syntax.

See the "style.css" in this pull request to see the difference in the
old and new methods: https://github.com/LMMS/lmms/pull/592/files