[Lmappletserver-developers] IMPORTANT - Re: getLatest boolean bug

[Peter S. <co...@pe...>]

Hi Roberto,

This reference to MetaDataLogViewerApplet:

*
((JCheckBoxMenuItem)((MetaDataLogViewerApplet)this.applet).getSettingsMenu().getMenuComponent(0)).setSelected(showLatestEntries);
*

gives me a problem - since I don't use the MetaDataLogViewerApplet. I have
my own applet where I insert a MetaDataLogViewerPanel, and in some cases I
don't even have a applet, but rather a JFrame.

I have changed in the MetaDataLogViewerPanel, so that this now holds the
reference to the settingsmenu, and also provides a direct getter for the
checkbox menu item (in case we want to add other menu items in between in
the future, we will not be fooled by the 0 index in getMenuComponent)..

We should consider removing the MetaDataLogViewerApplet class, so that we
avoid the "temptation" of referencing to it directly. It should really only
serve as an example of how to put together an applet - nothing more. Maybe
we could replace it and rather paste it in as a code example in the
MetaDataLogViewerPanel javadoc?

regards,

Peter

On Jan 14, 2008 6:22 AM, Roberto MIlev <rob...@gm...> wrote:

> Hi Peter,
>
> I had a look at the bug. The reason this happened is because this applet
> (metalog) does not have a checkbox from which the functionality can be
> controlled. I fixed the bug and I have also committed the changes. I
> tested it with hardcoded values (true and false), which I just set for
> the value of the showLatestEntries variable. I assume that you will wire
> the value to a checkbox that you have in you extended version of the
> applet.
>
> Regards,
> Roberto
>
> Peter Salomonsen wrote:
> >
> >
> > On Jan 11, 2008 6:42 AM, Roberto MIlev <rob...@gm...
> > <mailto:rob...@gm...>> wrote:
> >
> >     Hi Peter,
> >
> >     I have implemented that changes in order to perform the color
> matching
> >     on the server side. I have not committed these changes yet, since
> >     I got
> >     no feedback from you on the existing code where color conditions are
> >     configured in the database columns and not change the java code.
> >
> >
> > We haven't started using the color code yet - and I'd rather want to
> > use this new version - read my answer to your question below - and
> > then you can commit it.
> >
> >
> >     For the new implementation, if I got you right, you like a method
> >     like:
> >     getColourStringForValue(String value) that you will override in
> other
> >     applications and generate color using scale with Java Code? I will
> >     provide an implementation of this interface for these concrete
> >     case. Is
> >     this ok?
> >
> >
> > The getColourStringForValue method is only for the AirportWatch use
> > case for coloring rows based on a temperature scale - and should not
> > be part of the api. So this is up to you if you want to use such a
> > method or concat the color value directly for the AirportWatch example
> > use case.
> >
> > In our use case, we will use a formula api for creating the color
> > strings - so the point is: the lmappletserver-addons apis should not
> > bother about logic for matching values and calculating color values -
> > it should only be able to color a row if such a value is set. see?
> >
> > ------------------
> >
> > Another bug:
> >
> > I just modified MetaDataSearchExecutor, so that it uses the getLatest
> > boolean from MetaDataSearchDTO. But I also see still that you're not
> > able to save searches with latest = false, neither does the applet
> > unhook the latest checkbox if I load a search that I've saved with
> > latest=false.
> >
> > I've verified that the SearchManager.saveSearch() is correct, since I
> > managed to save a search with latest=false using this method, but this
> > doesn't work from the applet. Please have a look at this when done
> > with the colors.
> >
> > -----------------
> >
> > Your status?
> >
> > And, just for curiosity - what is your current working status right
> > now? I know we're not filling your time 100% nowadays, so are you into
> > other assignments? How do you find the current working scheme with us
> > (is working hour by hour ok?)
> >
> > regards,
> >
> > Peter
> > regards,
> >
> > Peter
> >
> >
>