Re: [lkcd-devel] 4.1-pre2 available for testing/qualification

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Hey, Michael.  I'll update the lkcdutils-qlcrash RPM now and
check it in.  In addition, I approve of the changes in your
patch, however, please find one other individual to approve
of the modifications (I'm trying to stick to two reviewers,
even in the easy cases). :)

Thanks for everything,

--Matt

On Wed, 17 Apr 2002, Michael Holzheu wrote:
|>Hi Matt,
|>
|>I tested your source rpms on s390x (64bit) with gcc-3.1 and qt-2.3
|>The qlcrash rpm was built correctly.
|>
|>An rpm --rebuild of the lkcdutils srpm failed because in the spec file
|>lc_dis.h is
|>listed to be installed, but this file is only available for i386:
|>
|>error: File not found: /usr/include/lkcd/asm/lc_dis.h
|>RPM build errors:
|>    File not found: /usr/include/lkcd/asm/lc_dis.h
|>
|>After adding:
|>
|>%ifarch i386
|>/usr/include/lkcd/asm/lc_dis.h
|>%endif
|>
|>to the specfile the rpm built correctly on s390x.
|>By the way: The source rpm is quite big (16MB)...
|>
|>
|>
|>I also found some last tiny bug fixes we would like to checkin:
|>- Sanity check for s390dbf
|>- fix for s390dis (address is now written correctly)
|>- check if fd 0 is a tty in main.c
|>
|>Could you please review the following patch ?
|>
|>diff -urN lkcdutils.head.org/lcrash/arch/s390/cmds/cmd_s390dbf.c
|>lkcdutils.head/lcrash/arch/s390/cmds/cmd_s390dbf.c
|>--- lkcdutils.head.org/lcrash/arch/s390/cmds/cmd_s390dbf.c  Tue Apr 16
|>19:20:14 2002
|>+++ lkcdutils.head/lcrash/arch/s390/cmds/cmd_s390dbf.c      Wed Apr 17
|>14:04:39 2002
|>@@ -106,7 +106,7 @@
|> static void EBCASC(char *inout, size_t len)
|> {
|>         char *in = inout;
|>-        iconv(ebcdic_ascii_conv, (const char **) &in, &len, &inout, &len);
|>+        iconv(ebcdic_ascii_conv, (char **) &in, &len, &inout, &len);
|> }
|>
|> /*
|>@@ -473,6 +473,10 @@
|>      /* print debug records */
|>      if (!(view->format_proc) && !(view->header_proc))
|>            goto out;
|>+     if(debug_area->entry_size <= 0){
|>+           fprintf(ofp, "Invalid entry_size:
|>%i\n",debug_area->entry_size);
|>+           goto out;
|>+     }
|>      nr_of_entries = PAGE_SIZE / debug_area->entry_size
|>          << debug_area->page_order;
|>      for (i = 0; i < debug_area->nr_areas; i++) {
|>diff -urN lkcdutils.head.org/lcrash/arch/s390/lib/dis.c
|>lkcdutils.head/lcrash/arch/s390/lib/dis.c
|>--- lkcdutils.head.org/lcrash/arch/s390/lib/dis.c     Tue Apr 16 19:20:14
|>2002
|>+++ lkcdutils.head/lcrash/arch/s390/lib/dis.c   Wed Apr 17 14:06:19 2002
|>@@ -57,7 +57,7 @@
|>
|>      /* Print out address
|>       */
|>-     dip->fprintf_func(dip->stream, "0x%x", addr);
|>+     dip->fprintf_func(dip->stream, "0x%llx", (uint64_t)addr);
|>
|>      /* Print out symbol name
|>       */
|>diff -urN lkcdutils.head.org/lcrash/arch/s390x/cmds/cmd_s390dbf.c
|>lkcdutils.head/lcrash/arch/s390x/cmds/cmd_s390dbf.c
|>--- lkcdutils.head.org/lcrash/arch/s390x/cmds/cmd_s390dbf.c Tue Apr 16
|>19:20:14 2002
|>+++ lkcdutils.head/lcrash/arch/s390x/cmds/cmd_s390dbf.c     Wed Apr 17
|>14:04:57 2002
|>@@ -106,7 +106,7 @@
|> static void EBCASC(char *inout, size_t len)
|> {
|>         char *in = inout;
|>-        iconv(ebcdic_ascii_conv, &in, &len, &inout, &len);
|>+        iconv(ebcdic_ascii_conv, (char **) &in, &len, &inout, &len);
|> }
|>
|> /*
|>@@ -473,6 +473,10 @@
|>      /* print debug records */
|>      if (!(view->format_proc) && !(view->header_proc))
|>            goto out;
|>+     if(debug_area->entry_size <= 0){
|>+           fprintf(ofp, "Invalid entry_size:
|>%i\n",debug_area->entry_size);
|>+           goto out;
|>+     }
|>      nr_of_entries = PAGE_SIZE / debug_area->entry_size
|>          << debug_area->page_order;
|>      for (i = 0; i < debug_area->nr_areas; i++) {
|>diff -urN lkcdutils.head.org/lcrash/arch/s390x/lib/dis.c
|>lkcdutils.head/lcrash/arch/s390x/lib/dis.c
|>--- lkcdutils.head.org/lcrash/arch/s390x/lib/dis.c    Tue Apr 16 19:20:14
|>2002
|>+++ lkcdutils.head/lcrash/arch/s390x/lib/dis.c  Wed Apr 17 14:06:24 2002
|>@@ -57,7 +57,7 @@
|>
|>      /* Print out address
|>       */
|>-     dip->fprintf_func(dip->stream, "0x%x", addr);
|>+     dip->fprintf_func(dip->stream, "0x%llx", (uint64_t)addr);
|>
|>      /* Print out symbol name
|>       */
|>@@ -150,17 +150,17 @@
|>         disinfo.arch               = bfd_arch_s390;
|> #if defined(_ARCH_S390X)
|>  #if defined(bfd_mach_s390_esame)
|>-        disinfo.mach                    = bfd_mach_s390_esame;
|>+     disinfo.mach                  = bfd_mach_s390_esame;
|>  #elif defined(bfd_mach_s390_64)
|>-        disinfo.mach                    = bfd_mach_s390_64;
|>+     disinfo.mach                  = bfd_mach_s390_64;
|>  #else
|>         #error "Invalid binutils version"
|>  #endif
|> #else
|>  #if defined(bfd_mach_s390_esa) || defined(bfd_mach_s390_31)
|>-        disinfo.mach                    = 0 /* bfd_mach_s390_esa */;
|>+     disinfo.mach                    = 0 /* bfd_mach_s390_esa */;
|>  #else
|>-        #error "Invalid binutils version"
|>+     #error "Invalid binutils version"
|>  #endif
|> #endif
|>         disinfo.endian                  = BFD_ENDIAN_BIG;
|>diff -urN lkcdutils.head.org/lcrash/main.c lkcdutils.head/lcrash/main.c
|>--- lkcdutils.head.org/lcrash/main.c      Tue Apr 16 19:20:14 2002
|>+++ lkcdutils.head/lcrash/main.c    Wed Apr 17 14:19:56 2002
|>@@ -287,7 +287,7 @@
|>      }
|>
|>      /* check if we are connected to a terminal */
|>-     if (isatty(1) == 0) {
|>+     if ((isatty(1) == 0) || (isatty(0) == 0)) {
|>            ql_have_terminal = 0;
|>      }
|>      else {
|>
|>
|>Regards
|>
|>       Michael
|>
|>------------------------------------------------------------------------
|>Linux for E-Server Development
|>Phone: +49-7031-16-2360,  Bld 71032-03-U09
|>Email: ho...@de...
|>
|>
|>
|>|---------+-------------------------------------->
|>|         |           "Matt D. Robinson"         |
|>|         |           <ya...@ap...>       |
|>|         |           Sent by:                   |
|>|         |           lkc...@li...ur|
|>|         |           ceforge.net                |
|>|         |                                      |
|>|         |                                      |
|>|         |           04/17/02 09:37 AM          |
|>|         |           Please respond to "Matt D. |
|>|         |           Robinson"                  |
|>|         |                                      |
|>|---------+-------------------------------------->
|>  >-----------------------------------------------------------------------------------------------------------------|
|>  |                                                                                                                 |
|>  |       To:       lkc...@li...                                                                |
|>  |       cc:       "Matt D. Robinson" <ya...@ap...>                                                         |
|>  |       Subject:  [lkcd-devel] 4.1-pre2 available for testing/qualification                                       |
|>  |                                                                                                                 |
|>  |                                                                                                                 |
|>  >-----------------------------------------------------------------------------------------------------------------|
|>
|>
|>
|>I've just uploaded it, and starting testing now.  I've built
|>the lkcdutils RPM, along with a new lkcdutils-qlcrash RPM
|>for initial test to see if people prefer that packaging
|>mechanism (Fritz?)  Also, the LKCD patch is available, with
|>the only change from the tree snapshot being Tony's fix for
|>module builds.
|>
|>The files are in the download/experimental/4.1-pre2 directory
|>at http://lkcd.sourceforge.net/.
|>
|>Please test, debug, and discuss (and for those other platforms,
|>please --rebuild for your architecture if you'd like).
|>
|>Thanks, all.
|>
|>--Matt
|>
|>
|>_______________________________________________
|>lkcd-devel mailing list
|>lkc...@li...
|>https://lists.sourceforge.net/lists/listinfo/lkcd-devel
|>
|>
|>
|>
|>
|>_______________________________________________
|>lkcd-devel mailing list
|>lkc...@li...
|>https://lists.sourceforge.net/lists/listinfo/lkcd-devel
|>