Menu

#66 manpage installation fails if subdirectories exist under mandir.

1.0
closed
nobody
None
fixed,
2014-11-30
2014-11-20
Joel Ebel
No

Installing man pages fails if subdirectories exist in man dir.
install-data-hook in doc/Makefile has the following line:

$(SED) -i "s/@version@/$(VERSION)/" $(DESTDIR)$(mandir)//

If $mandir contains subdirectories, then this will match those, and sed fails trying to edit a directory. In my case, some programs had installed language specific subdirectories until $mandir, such as es/ and fr/, and the / matched es/man1, es/man5, etc, which were directories, not files. I changed the sed to match /.? which worked, but still seems risky, running sed against all files under $mandir, not just the ones you just installed.

Discussion

  • Alec Leamas

    Alec Leamas - 2014-11-20

    Thanks again for a good catch! Fix in [40e0da]

     

    Related

    Commit: [40e0da]

  • Alec Leamas

    Alec Leamas - 2014-11-30
    • status: open --> closed
    • Resolution: na, --> fixed,
     
  • Alec Leamas

    Alec Leamas - 2014-11-30

    Released, at least in 0.9.1pre2 (pre1?). Closing.

     

Log in to post a comment.

Auth0 Logo