I'd like to add the long keypress detection
functionality into lirc. There are some work-arounds: http://forum.xbmc.org/showthread.php?tid=115023
but they look clumsy.
I wanted to code up something clean and simple.
Patch attached.
Looking into drivers/ I see that there already is a README explaining the situation. Given that it takes some time to sort out all references to this, I'll keep it as-is for now.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I can see you calling "ignore_first_events" as
"ignore_first_event" and write
If set to 1 (true) the first event is suppressed
which makes it is possible to define the reaction to long key-presses.
Initially I thought this may make sense and even
wanted to provide a patch. It will seemingly not
conflict with "delay" and will actually be something
new. But thinking more, it seems there will still
be an inconsistency. Namely, if you disable "delay"
and "repeat" while enable "ignore_first_event",
you'll get no events at all, which is fatal.
The workaround can be to force "delay" to 1 if it
was disabled while "ignore_first_event" is enabled,
but then this is not much better than what we
currently have. So after all I think "ignore_first_events"
should stay.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
You should as well remove drivers/*
as it seems to be the dead, non-functional code.
No, it's example code referenced in the docs. But we should git mv drivers -> examples or so.
Last edit: Alec Leamas 2014-10-07
new message: [1492e8]
Related
Commit: [1492e8]
Looking into drivers/ I see that there already is a README explaining the situation. Given that it takes some time to sort out all references to this, I'll keep it as-is for now.
I can see you calling "ignore_first_events" as
"ignore_first_event" and write
If set to 1 (true) the first event is suppressed
which makes it is possible to define the reaction to long key-presses.
Initially I thought this may make sense and even
wanted to provide a patch. It will seemingly not
conflict with "delay" and will actually be something
new. But thinking more, it seems there will still
be an inconsistency. Namely, if you disable "delay"
and "repeat" while enable "ignore_first_event",
you'll get no events at all, which is fatal.
The workaround can be to force "delay" to 1 if it
was disabled while "ignore_first_event" is enabled,
but then this is not much better than what we
currently have. So after all I think "ignore_first_events"
should stay.
I presume this is the patch descriptions... in which case sf does not allow us to change it. I havn't patched the docs, have I?