Menu

#50 support for long press detection

1.0
closed
nobody
None
fixed,
2014-11-17
2014-09-22
No

Hi.

I'd like to add the long keypress detection
functionality into lirc. There are some work-arounds:
http://forum.xbmc.org/showthread.php?tid=115023
but they look clumsy.
I wanted to code up something clean and simple.
Patch attached.

1 Attachments

Discussion

<< < 1 2 (Page 2 of 2)
  • Alec Leamas

    Alec Leamas - 2014-10-07
    • status: open --> closed
     
    • Stas Sergeev

      Stas Sergeev - 2014-10-07

      You should as well remove drivers/*
      as it seems to be the dead, non-functional code.

       
  • Alec Leamas

    Alec Leamas - 2014-10-07

    No, it's example code referenced in the docs. But we should git mv drivers -> examples or so.

     

    Last edit: Alec Leamas 2014-10-07
  • Alec Leamas

    Alec Leamas - 2014-10-07

    new message: [1492e8]

     

    Related

    Commit: [1492e8]

  • Alec Leamas

    Alec Leamas - 2014-10-08

    Looking into drivers/ I see that there already is a README explaining the situation. Given that it takes some time to sort out all references to this, I'll keep it as-is for now.

     
  • Stas Sergeev

    Stas Sergeev - 2014-10-08

    I can see you calling "ignore_first_events" as
    "ignore_first_event" and write


    If set to 1 (true) the first event is suppressed
    which makes it is possible to define the reaction to long key-presses.


    Initially I thought this may make sense and even
    wanted to provide a patch. It will seemingly not
    conflict with "delay" and will actually be something
    new. But thinking more, it seems there will still
    be an inconsistency. Namely, if you disable "delay"
    and "repeat" while enable "ignore_first_event",
    you'll get no events at all, which is fatal.
    The workaround can be to force "delay" to 1 if it
    was disabled while "ignore_first_event" is enabled,
    but then this is not much better than what we
    currently have. So after all I think "ignore_first_events"
    should stay.

     
  • Alec Leamas

    Alec Leamas - 2014-10-08

    I presume this is the patch descriptions... in which case sf does not allow us to change it. I havn't patched the docs, have I?

     
  • Alec Leamas

    Alec Leamas - 2014-11-17
    • Resolution: --> fixed,
     
<< < 1 2 (Page 2 of 2)

Log in to post a comment.