Re: [PATCH 6/6] Ditch Python dependent make_rel_symlink with ln -sr

[Thomas U. <tho...@ma...>]

On Wed, 27 May 2026, Doron Behar wrote:

> [...]
>
> -	$(PYTHON) $(srcdir)/make_rel_symlink.py \
> -	    $(DESTDIR)$(vardocsdir) $(DESTDIR)$(plugindocsdir)/var
> -	$(PYTHON) $(srcdir)/make_rel_symlink.py \
> +	cd $(DESTDIR)$(plugindocsdir); ln -sr \
> +	    $(DESTDIR)$(vardocsdir) var
> +	cd $(DESTDIR)$(website_htmldir); ln -sr \
> 	    $(DESTDIR)$(vardocsdir)/index.html \
> -	    $(DESTDIR)$(website_htmldir)/plugins-index.html
> +	    plugins-index.html

Why do you use this combination of cd with ln instead of simply writing:

 	ln -sr $(DESTDIR)$(vardocsdir) $(DESTDIR)$(plugindocsdir)/var
 	ln -sr $(DESTDIR)$(vardocsdir)/index.html \
 	    $(DESTDIR)$(website_htmldir)/plugins-index.html

BTW, the non-POSIX option -r is a GNU extension, and I don't know if 
support for stripped-down Linux environments with only BusyBox for 
instance is something of concern.


> [...]
>
> -	$(PYTHON) $(srcdir)/make_rel_symlink.py \
> -	    $(DESTDIR)/$(setupdir)/lirc-setup \
> -	    $(DESTDIR)/$(bindir)/lirc-setup
> +	cd $(DESTDIR)/$(bindir); \
> +	    ln -sr \
> +	    	$(DESTDIR)/$(setupdir)/lirc-setup
> 	rm -rf $(DESTDIR)/$(setupdir)/configs
> -	$(PYTHON) $(srcdir)/make_rel_symlink.py \
> -	    $(DESTDIR)/$(pkgdatadir)/configs \
> -	        $(DESTDIR)/$(setupdir)/configs
> +	cd $(DESTDIR)/$(setupdir); \
> +	    ln -sr $(DESTDIR)/$(pkgdatadir)/configs

Same here, the following seems to be more simple:

 	ln -sr $(DESTDIR)/$(setupdir)/lirc-setup $(DESTDIR)/$(bindir)
 	ln -sr $(DESTDIR)/$(pkgdatadir)/configs $(DESTDIR)/$(setupdir)

Best regards,

Thomas Uhle