Re: [PATCH 5/6] configure.ac: query for a Python only with PKG_CHECK_MODULES

[Thomas U. <tho...@ma...>]

On Wed, 27 May 2026, Doron Behar wrote:

> [...]
>
> -AM_PATH_PYTHON([3.7],,)
> -PKG_CHECK_MODULES([PYTHON],[python-${PYTHON_VERSION}m],,[true])
> -test -z "$PYTHON_CFLAGS" && \
> -    PKG_CHECK_MODULES([PYTHON], [python-$PYTHON_VERSION],,[true])
> -test -n "$PYTHON_CFLAGS" || \
> -    AC_MSG_WARN([No python package found (missing devel package?)])
> +# Try the 'm' (malloc/abiflags) version first, fallback to standard python3
> +PKG_CHECK_MODULES([PYTHON], [python3m >= 3.7], [pkg_cv_python_name="python3m"], [
> +    PKG_CHECK_MODULES([PYTHON], [python3 >= 3.7], [pkg_cv_python_name="python3"], [
> +        AC_MSG_WARN([No python package found >= 3.1 (missing devel package?)])

The problem in hard-coding minimum required version numbers several times 
is that in the end there might be a mismatch like this here: 3.7 != 3.1.

Why don't you write:

m4_define([PYTHON_MIN_VERSION], [3.7])
# Try the 'm' (malloc/abiflags) version first, fallback to standard python3.
PKG_CHECK_MODULES([PYTHON], [python3m >= ]PYTHON_MIN_VERSION, [pkg_cv_python_name="python3m"], [
     PKG_CHECK_MODULES([PYTHON], [python3 >= ]PYTHON_MIN_VERSION, [pkg_cv_python_name="python3"], [
         AC_MSG_WARN([No python package found with version ]PYTHON_MIN_VERSION[ or newer (missing devel package?)])

Best regards,

Thomas Uhle