From: Bengt M. <bu...@be...> - 2014-05-08 21:11:42
|
On 05/08/14 13:57, Alec Leamas wrote: > On 2014-05-06 21:59, Bengt Martensson wrote: > >> [cut] > >> Minor points: I do not like the output of: >> >> $ sbin/lircd --help >> ciniparser: cannot open /etc/lirc/lirc_options.conf >> Usage: lircd [options] <config-file> >> [cut] > >> It should not be bothering the use about missing option file in this >> case; it is irrelevant. The same goes for --version. It appears as you misunderstod me here. I do not mind non-fatal warnings about option file not present for normal usage; however, --help and --version are not "normal usage" in this sense, and to complain about the non-existance of an optional file, is not really sensible. But also not a very important point :-). > > Hm... looking into this, I see that the Makefile actually already > installs /etc/lirc/lrc_options.conf, so that should just not happen. Are > you running this without running 'make install'? > > --alec > To answer your question first: I configured with --prefix=/local/lirc-ng and installed as non-root, because I did not want to destroy my system's carefully crafted lirc.conf. Therefore /etc/lirc/lirc_options.conf was not installed. But I still think that an option file belongs to fedora/ubuntu/debian/..., not to LIRC. And, how about lircd `cat /etc/lirc/lirc_options.conf` Finally, I do not think that a program like lircd should implement all this in its own code; it should go into some library that can be reused, also to guarantees a certain uniformness in usage (like Gnu getopt). (In Java, I use the Jcommander (http://jcommander.org), which buys me usage messages, option files, etc for free.) Sorry if I sound grumpy, I am very happy for the work you have done/are doing. |