Re: lirc_dev: generic implementation of LIRC_{GET|SET}_SEND_MODE

[Maxim L. <max...@gm...>]

On Sat, 2010-04-24 at 09:38 +0200, Christoph Bartelmus wrote: 
> Hi!
> 
> Maxim Levitsky "max...@gm..." wrote:
> > This is my first attempt at doing some cleanups in the lirc core.
> > This is the lowest hanging fruit I guess..
> >
> > What do you think?
> [...]
> > +	case LIRC_SET_SEND_MODE:
> [...]
> > +		/*
> > +		 * FIXME: Tell hardware driver that mode changed
> > +			For now all drivers support just one mode
> >  		 */
> 
> Actually, when we're already at it:
> How about obsoleting LIRC_SET_SEND_MODE and LIRC_SET_REC_MODE.
This is more or less what is done now for LIRC_SET_SEND_MODE
It just a matter of removing that comment.
Kernel interface shouldn't change suddenly, so lirc-dev should support
this for a while.

Besides that, whats your opinion on this patch?

Best regards,
Maxim Levitsky