Re: lirc nct667x support

[Jarod W. <ja...@wi...>]

On Fri, Apr 2, 2010 at 10:13 PM, Stephan Raue <mai...@op...> wrote:
> Hi all,
>
> i am trying to build the lirc driver for nct667 chipsets [1] for any
> other distribution as ubuntu. i am using the lirc driver patch for
> linux-2.6.33 that can be found in the latest fedora rawhide srpm`s.

Pardon, but why are you working from that and patching kcompat.h back
in on top, rather than just working from current cvs?

And for the record, the fedora rawhide lirc patch is generated from here:

http://git.kernel.org/?p=linux/kernel/git/jarod/linux-2.6-lirc.git;a=summary

If you look back at the history, you can see that quite a bit of
effort was put into eliminating kcompat.h, as the git tree only tracks
the current upstream kernel. If your driver is written correctly, it
should be able to drop into both the git tree and cvs without having
to use kcompat.h, unless building on an older kernel.

> in
> addition to this patch i have crated an patch based on the sources from
> [1] to integrate this nct667 driver also to my kernel sources. here you
> find my patch:
>
> can anyone help me to fix the problems for kernel 2.6.33 and later?

Sure.

> [1] http://www.asrock.com/Nettop/download.asp?Model=ION 330HT&o=Linux
> [2]
> http://sources.openelec.tv/tmp/patches/linux-2.6.33-02-add_lirc_driver_nct667x-0.3.diff
>
> errors:
>
>   CC [M]  drivers/input/lirc/lirc_wb677_main.o
> In file included from drivers/input/lirc/lirc_wb677.h:47,
>                  from drivers/input/lirc/lirc_wb677_main.c:3:
> drivers/input/lirc/lirc_wb677_common_extern.h:97: error: expected
> specifier-qualifier-list before 'lirc_t'

lirc_t doesn't appear to be defined anywhere in your patch. Everything
else falls apart from there. cscope is your friend.

-- 
Jarod Wilson
ja...@wi...