From: <li...@ba...> - 2007-09-02 08:05:25
|
Hi! Jarod Wilson "ja...@wi..." wrote: [...] > I think there's actually quite a bit that should probably go into LIRC CVS, > so things don't diverge too much. I'd actually like to open some discussion > about how this would best work. Things we need to do for kernel inclusion: > > 1) run <kernel source>/scripts/checkpatch.pl over any patches to be applied > to the kernel, reduce checkpatch output as much as possible. A lot of this > is coding style changes, whitespace clean-ups, etc. Is there a way to collect all these changes and get it as one patch file? This requires a careful review. E.g. in the lirc_parallel driver I noticed that the initialisation of tx_mask was removed, breaking the transmit functionality. > 2) fixes for compile errors and warnings with latest linus kernel This will have to go into LIRC CVS sooner or later anyway. > 3) flatten source tree so we have all bits in <kernel > source>/drivers/input/lirc/, rather than each driver in its own > sub-directory I think it should be easy to keep the current structure in LIRC CVS and convert to the other directory structure using a simple script. Makefiles will be different anyway. > 4) drop as much stuff in '#if LINUX_VERSION_CODE' wrappers as possible. Yes, 2.4 stuff can be dropped anyway. The idea of kcompat.h was to always use the latest kernel API and provide compatibility wrappers in kcompat.h for older kernels. Unfortunately this is not always possible. So the idea to remove the LINUX_VERSION_CODE stuff later by a script sounds like the way to go. Christoph |