Re: lirc_serial bugfix

[<li...@ba...>]

Hi!

Andrei Tanas "an...@un..." wrote:
[...]
>>> I've tested it, it fixed a real problem
>>
>> I agree. That's why I proposed a fix for your problem.
>> Did it solve the problem or not?
>>
> You did not "propose a fix for my problem" you rejected my solution for it.

I explained to you why I have chosen a different approach.
If you can give arguments why your solution is better than mine I will  
be happy to accept it.

>>> This autodetection code does not work properly in any case:
>>>
>>
>> It's there since lirc-0.5.4 released in '99. If there were a fundamental
>> problem with this code, it really should have appeared before.
>>
> The driver did not support suspend/resume, people were simply unloading
> it before going to standby, that piece of code was essentially "dead".
> Now the problem manifested itself very clearly and the solution is very
> simple.

The suspend/resume code introduced the problem, so it's just the normal  
way to fix it for the suspend/resume case.

> Anyway, it's great that LIRC is open source and I can use my modified
> code. Too bad others won't benefit from this.

Have you tested if the code in CVS solved the problem?

Christoph