Re: lirc_serial bugfix

[<li...@ba...>]

Hi!

Andrei Tanas "an...@un..." wrote:
[...]
>> I have modified part 1 slightly and have chosen a different approach
>> for
>> part 2. The code is in CVS already. I hope it will fix the problem.
>>
> Christoph, I don't think the approach you've chosen for part 2 will
> work. Scenario: the last interrupt received before standby is pulse (I
> am not even sure if this makes any difference, it can probably be space
> just as well),

It does not make any difference because pulse/space detection only  
relies on the current state of DCD, not the previous state.

> then, after resume (which is very possible, even if the
> box is being woken up by IR, by the time kernel is initialized and we
> could process our interrupt, any IR activity will be gone), lasttv is
> reset with gettimeofday, however, if no interrupt is received in the
> next 15 seconds, the sense flag will still be flipped.

If there is no activity the next 15 seconds, then the next signal  
received definitely is a space and must be recognized that way.

> Why do you insist on keeping that code, I just don't see under what
> conditions it could be useful to "change our mind" on what type of
> receiver is being used, especially if it was passed as module parameter.

If this condition still occurs, then it shows that there still is a bug  
somewhere else or we do not understand what is really going on.

Christoph