Re: Asus P5W DH remote

[braice <br...@br...>]

Christoph Bartelmus a écrit :
> Hi!
> 
> Brice DUBOST "br...@br..." wrote:
> [...]
>> I had a look on the patch by  Bernhard Frauendienst.
>> As there is very few changes to make to dvico driver to get this remote
>> working, I made a new patch.
>>
>> It's smaller, and, I hope, can be easely integrated in lirc source tree.
> 
> Please provide a patch for setup.data and configure.in that adds the  
> driver to the list in setup.sh.
> 

Ok

I thinked also that the dvico driver can be renamed to hiddev. What do
you think about that ?

> The hw_hiddev.c should contain a new struct hardware hw_asus_p5w entry.
> Also you should not read 8 events in hiddev_rec, but read 1 event at a  
> time and ignore all events not containing useful data by just returning  
> NULL.

That's what I planned to do at the beginning but there is some issues :



Here's an hexdump of hiddev when I press a key :

00000000  00 00 00 ff 02 00 00 00  00 00 00 ff 09 00 00 00
00000010  00 00 00 ff 00 00 00 00  00 00 00 ff 00 00 00 00

Here I pressed key number 9, but I get a similar event like I pressed
key number 2 (wich exists)




Here's an hexdump of hiddev when I release a key :

00000040  00 00 00 ff 02 00 00 00  00 00 00 ff 00 00 00 00
00000050  00 00 00 ff 00 00 00 00  00 00 00 ff 00 00 00 00

By reading one event I don't know if I release a key.

the issues are :
 * I don't know if key two have been pressed
 * I don't know if we press or release a key (but doesn't really matter
since it's not used)


> Your current code reads 8 events although you only reserve space for 4  
> causing a stack overflow.
> 

I didn't saw this issue on my computer but you're right
True

> Christoph
> 

-- 
Brice

Join us now and share the software;
You'll be free, hackers, you'll be free.
[Richard STALLMAN, free software song]