[linuxsh-dev] Re: Solution Engin's ATA PC-card enabler

[kaz K. <kk...@rr...>]

NIIBE Yutaka wrote:
>> --- linux-2.4.0-test1/arch/sh/kernel/io_se.c	Mon May 22 12:55:06 2000
>> +++ linux-sh/arch/sh/kernel/io_se.c	Wed Jun  7 12:55:33 2000
> 
> I'd like to listen comment from Kaz.  It seems there's some conflict
> on usage of sh_pcic_XXX semantics.

I think all changes by Nozawa-san are fine except

> unsigned long inb(unsigned int port)
> {
> 	if (sh_pcic_io_start <= port && port <= sh_pcic_io_stop)
>-		return *(__u8 *) (sh_pcic_io_wbase + 0x40000 + port); 
>+		return *(__u8 *) port2adr(port); 
> 	else if (shifted_port(port))

MR-SHPC-01 chip has 1MB window which is constructed as the set of
four 256KB spaces. First 256KB space is "real word" space and the
second is "real byte" space. So the above change makes byte input
from the "real word" space. It seems not good in the i/o window
case since the access to this area has 16-bit sizing which will
cause problems on some PCMCIA cards. Of course, it might not cause
any problem on CF(ATA) cards, but I'd like to be defensive for such
chip :-)

	kaz