Re: [Linuxptp-devel] [PATCH v2 0/4] Bug fix and improved clockcheck

[Keller, J. E <jac...@in...>]

> -----Original Message-----
> From: Miroslav Lichvar <mli...@re...>
> Sent: Thursday, October 20, 2022 7:13 AM
> To: lin...@li...
> Subject: [Linuxptp-devel] [PATCH v2 0/4] Bug fix and improved clockcheck
> 
> v2:
> - added patch to exit on errors returned by read-only clock_adjtime()
> - simplified last patch to reuse the set frequency and allow +/-1 ppb
>   error due to conversions between int, double and scaled ppm
> - improved commit messages
> 


Thanks! The series overall looks good to me. A minor documentation question/concern but I think the implementation seems fine.

Reviewed-by: Jacob Keller <jac...@in...>

> This set improves the clock check to consider the last frequency set by
> ptp4l/phc2sys in order to detect cases where multiple processes are
> trying to control the same clock due to a misconfiguration or bug.
> 
> Miroslav Lichvar (4):
>   phc2sys: Add clocks after processing configuration.
>   Drop support for old kernels returning zero frequency.
>   Don't accept errors in clockadj_get_freq().
>   Extend clockcheck to check for changes in frequency.
> 
>  clock.c      | 10 +++-------
>  clockadj.c   |  2 ++
>  clockcheck.c | 10 ++++++++++
>  clockcheck.h |  8 ++++++++
>  phc2sys.8    |  2 +-
>  phc2sys.c    | 48 ++++++++++++++++++++++++++----------------------
>  ptp4l.8      |  4 +++-
>  ts2phc.c     |  7 -------
>  8 files changed, 53 insertions(+), 38 deletions(-)
> 
> --
> 2.37.3
> 
> 
> 
> _______________________________________________
> Linuxptp-devel mailing list
> Lin...@li...
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel