Re: [Linux-uvc-devel] Small fix and help offered

[Laurent P. <lau...@sk...>]

Hi Per,

> Great work on this driver! Let's just hope that more manufacturers start
> using the standard.
>
> Looking through the code I found whan I think is an error. Se patch below.
>
> --- uvcvideo.c  (revision 22)
> +++ uvcvideo.c  (working copy)
> @@ -1327,7 +1327,7 @@
>
>                 video->iso_buffer[i] = usb_buffer_alloc(video->dev->udev,
>                         size, GFP_KERNEL, &urb->transfer_dma);
> -               if (video == NULL) {
> +               if (video->iso_buffer[i] == NULL) {
>                         usb_free_urb(urb);
>                         uvc_uninit_isoc(video);
>                         return -ENOMEM;

Thanks. Applied.

> I have experience of driver development and video systems, and I'd
> really like to help develop this driver furter. What needs to be done? Bulk
> transfer? Maybe I can try to get hold of one of those Fuji cameras....

If you can get hold of one of those cameras, bulk transfers shouldn't be very 
difficult to implement.

You could also implement the V4L2 read() method as it's currently not 
supported. Another area of the driver that could do with some improvements is 
video controls handling (VIDIOC_{GS}_CTRL). A few controls are currently 
mapped directly from V4L2 to UVC, but complex controls can't be easily 
supported this way. I can give you more information if you're interested.

Best regards, and thank you for your help.

Laurent Pinchart