Re: [Linux-uvc-devel] [PATCH] Fake a TV tuner for MPlayer and TV apps

[Eduardo P. U. <edu...@uc...>]

I submitted a patch a while ago that has some of the changes you submitted.
Maybe we need svn access to prevent this from happen again.
Anyway, I think hardcoding NTSC support may not be the best idea. I
copied my changes from:
http://www.saillard.org/linux/pwc/
And they are not hardcoding NTSC.
We need a standard API among drivers and applications to make v4l
a good standard otherwise only some applications will work correctly.

On 2006-02-21 23:55:37 +0100, Luca Barbieri wrote:
> This patch makes uvcvideo claim it supports the NTSC standard and makes
> it accept configuration to any TV standards.
> 
> Some programs like MPlayer will fail without this.
> 

> Index: uvcvideo.c
> ===================================================================
> --- uvcvideo.c	(revision 19)
> +++ uvcvideo.c	(working copy)
> @@ -2148,12 +2167,37 @@
>  		return uvc_video_enable(video, 0);
>  	}
>  
> +	case VIDIOC_G_STD:
> +	{
> +		v4l2_std_id *std = arg;
> +		*std = V4L2_STD_NTSC;
> +		return 0;
> +	}
> +
> +	case VIDIOC_S_STD:
> +		return 0;
> +		
>  	/* Analog video standards make no sense for digital cameras. */
>  	case VIDIOC_ENUMSTD:
> +	{
> +		struct v4l2_standard *std = arg;
> +		if(std->index != 0)
> +			return -EINVAL;
> +
> +		v4l2_video_std_construct(std, V4L2_STD_NTSC, "NTSC");
> +		return 0;
> +	}
> +		
>  	case VIDIOC_QUERYSTD:
> -	case VIDIOC_G_STD:
> -	case VIDIOC_S_STD:
> +	{
> +		//v4l2_std_id *std = arg;
> +		return 0;
> +		//if(*std == V4L2_STD_ALL || *std == V4L2_STD_NTSC)
> +		//	return 0;
>  
> +		//return -EINVAL;
> +	}
> +
>  	case VIDIOC_OVERLAY:
>  
>  	case VIDIOC_ENUMAUDIO: