RE: [linux-iscsi-devel] [PATCH] portal_failover in kernel - incorporating comments

[N.C.Krishna M. \(krmurthy\) <krm...@ci...>]

Mike,
	Please find my replies interlarded

> > 
> > P.S:There was a suggestion to remove timeouts from iscsi_session 
> > structure since they are present in portal structure. I am looking 
> > into that and if that is possible I'll submit a patch.
> > 
> 
> What about adding back portal info update support?
Am looking into it.
> 
> 
>   static int
>   iscsi_login_auth_failure(struct iscsi_session *session)
>   {
> @@ -298,39 +284,14 @@
>   		 * next time
>   		 */
>   		ret = -1;
> -	else {
> -		session->auth_failures = 0;
> +	else
>   		ret = 0;
> -	}
> +
>   	spin_unlock(&session->portal_lock);
>   	return ret;
>   }
> 
> Why do you need the portal lock here? Is the
> config mutex supposed to protect these settings?

That was left over when I cleaned the code. Have removed it.
> 
> 
>   		case ISCSI_LOGIN_STATUS_NO_VERSION:
>   			return (iscsi_login_status_no_version
>   				(session, status_class, status_detail));
> 
> did you miss this one? Could you remove the extra "(" "}" in the
> return statements of this function.
Removed the function.
> 
> Is iscsi_login_auth_failure too long to move still?
It's moved.


>