|
From: Frank M. H. <fm...@sp...> - 2008-09-17 18:07:19
|
On Tuesday 16 September 2008 12:33, Dan Lenski wrote: > You want it, you got it. Here's a patch on the current SVN. A whole > bunch of changes: Thanks. > * fixed error handling to get errno from the right place > * __doc__ strings for every function (modeled on the ones Keith had > written) * a few function names made less terse: > cmd->command > tmo->timeout > trg->trigger > (I left ren, rsp, and ifc alone since remote_enable, > request_serial_poll, and interface_clear seemed unreasonable long to me, > but those could be changed as well.) I'd like to keep it consistent with the full names. request_serial_poll could be shortened to just serial_poll, the others seem okay to me. > I'm itching to improve the Python wrapper class in Gpib.py, > but decided to restrain myself from any further changes in this patch > :-) Especially if some people are using it in its current form. Would you resubmit your patch with the longer names and the indentation fixed (indent with tabs)? I could do it myself, but it would probably cause you a bunch of bogus conflicts with your checkout when you update. |