[Linux-fbdev-devel] Re: Driver specific options

[Petr V. <VAN...@vc...>]

On 14 Nov 01 at 9:35, James Simmons wrote:
> static struct {
>         const char *name;
>         int (*init)(void);
>         int (*setup)(char*);
> } fb_drivers[] __initdata = {
> 
> to:
> 
> static struct {
>         struct fb_info* (*init)(void);
>         int (*setup)(char*);
> } fb_drivers[] __initdata = {

I think that it is much easier to create an

int is_it_a_general_framebuffer_option(struct fb_info* fbi, 
                 const char* option);
                
and then in driver do:

while ((this_opt = strsep(&options, ",")) != NULL) {
   if (!*this_opt) continue;
   if (is_it_a_general_framebuffer_option(fbi, this_opt)) continue;
   if (strcmp(this_opt, "....")) ...
}

In such case you have much better control over specified options
command line, you can parse some options in special way, you can
specify fbdev own defaults for fb_info fields, ... And you do not
have to change API. But I think that you all know my position very well.
                                        Petr Vandrovec
                                        van...@vc...