From: Geert U. <ge...@li...> - 2001-06-22 08:23:24
|
On Fri, 22 Jun 2001, Romain Dolbeau wrote: > Michel D=E4nzer wrote: > > The attached patch significantly enhances the 16 bit handling of aty1= 28fb. > > I've achieved this mainly by consequently distinguishing between 'dep= th' and > > 'bpp'. I've used these terms for the same meanings as in XFree86 4.x;= please > > let me know if you prefer other terms. > > > > While this now works perfectly in X for both depth 15 and 16 as well = as in > > console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for > > fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the pale= tte for > > 565 should have 32 or 64 entries. >=20 > Does the problem you mention occur when you switch directly > from RGBA 5551 to RGBA 5650 ? Does it also happen if you > switch to 32bpp RGB8888 or 8bpp CI8 in-between ? >=20 > I have a similar problem with pm3fb, if I change the RGBA > component but not the depth, colors are wrong, but changing > depth and back fix the problem. Maybe it's the same bug and > not directly related to the driver ? Is this in the console? If yes, the color map has to be updated when the depth is changed. Probab= ly fbgen (or pm3fb) tests for the bpp only. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6= 8k.org In personal conversations with technical people, I call myself a hacker. = But when I'm talking to journalists I just say "programmer" or something like= that. -- Linus Torvalds |