From: Geert U. <ge...@li...> - 2001-04-17 17:55:16
|
On Tue, 17 Apr 2001, James Simmons wrote: > I noticed we could make the switch_con functions for fbcon so much > simpler. At present most drivers use the switch_con function to save the > color palette in struct display fb_display[con] and then sets the palette. > If you notice in the higher level functions of the console system the > set_palette function is called right after con_switch is called in the > upper layers. This means the palette is set twice. What a waste!! What > should be done is fbcon_set_palette should set the colormap and save it > somewhere. If the VC is not visible we save th color palette in > fb_display[con] but don't change the hardware palette. Else we do. This > would make *con_switch much simpler for each driver. This is not completely correct. The console system sets the first 16 entries only, while the fbdev should save/restore the whole colormap. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |