Re: [Linux-fbdev-devel] Fix 8bpp RGB fields length

[Ville S. <sy...@sc...>]

On Sun, Mar 01, 2009 at 09:55:56PM +0100, Krzysztof Helt wrote:
> Hi,
> 
> I found that some fbdev drivers set RGB field's lengths incorrectly
> to 6 bits. This is incorrect as the field's length says how many bits
> has a color index when using color palette (6 bits = 64 colors).

A slight omission in the fbdev API I suppose since the LUT entries are
nearly always 3*8bits wide. VGA being the exception.

> Fix this error in uvesafb by dropping DAC switching to 8 bits 
> completely. Advantage of this approach is making the driver shorter,
> disadvantage is that some color fidelity is lost.

I don't see much point in dropping this. It would reduce the image
quality and it looks like after your first fix this code would amount
to less than a dozen lines. But not my call anyway.

-- 
Ville Syrjälä
sy...@sc...
http://www.sci.fi/~syrjala/