Re: [Linux-fbdev-devel] [PATCH 1/2] atyfb: fix CONFIG_ namespace violations

[Ville S. <sy...@sc...>]

On Tue, Feb 03, 2009 at 02:23:34PM -0800, Randy Dunlap wrote:
> Ville Syrjälä wrote:
> > On Tue, Feb 03, 2009 at 09:09:38AM +0100, Geert Uytterhoeven wrote:
> >> On Mon, 2 Feb 2009, Randy Dunlap wrote:
> >>> --- linux-2.6.29-rc3-git3.orig/drivers/video/aty/atyfb_base.c
> >>> +++ linux-2.6.29-rc3-git3/drivers/video/aty/atyfb_base.c
> >>> @@ -135,7 +135,7 @@
> >>>  #if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \
> >>>  defined (CONFIG_FB_ATY_GENERIC_LCD) || defined(CONFIG_FB_ATY_BACKLIGHT)
> >>>  static const u32 lt_lcd_regs[] = {
> >>> -	CONFIG_PANEL_LG,
> >>> +	CNFG_PANEL_LG,
> >> These were the official names as used in the ATI docs. After these changes, you
> >> can no longer easily grep for them.
> >>
> >> Perhaps it's better to prefix everything with ATI_? yes, I know it's more work
> >> (for the writer), but we want to optimize for the reader, right?
> 
> Everything??  not just the CONFIG_* namespace violations?
> 
> [If so,] Potentially 3600 changes just in 3 header files, then all of
> the corresponding .c files.  No thanks.

That does seem quite a bit of work. But even if you change only the
CONFIG_ violations I'd say adding a prefix is preferable to changing
the register name in a way that makes it more difficult to look it up
in the chip documentation.

-- 
Ville Syrjälä
sy...@sc...
http://www.sci.fi/~syrjala/