Re: [Linux-fbdev-devel] [PATCH] fb: clean the penguin's dirty feet

[Geert U. <ge...@li...>]

On Mon, 10 Nov 2008, Clemens Ladisch wrote:
> When booting in a direct color mode, the penguin has dirty feet,
> i.e., some pixels have the wrong color.  This is caused by
> fb_set_logo_directpalette() which does not initialize the last 32
> palette entries.

Nice catch!
It seems to be introduced by commit 0bcb4ab100ef9ac2afaab3e0e929314e43820fc8
("Supprt for switching hardware from/to vga text mode.", from
full-history-linux) back in 2002...

> Signed-off-by: Clemens Ladisch <cl...@la...>

Acked-by: Geert Uytterhoeven <ge...@li...>

> --- linux-2.6.orig/drivers/video/fbmem.c
> +++ linux-2.6/drivers/video/fbmem.c
> @@ -232,7 +232,7 @@ static void fb_set_logo_directpalette(st
>  	greenshift = info->var.green.offset;
>  	blueshift = info->var.blue.offset;
> 
> -	for (i = 32; i < logo->clutsize; i++)
> +	for (i = 32; i < 32 + logo->clutsize; i++)
>  		palette[i] = i << redshift | i << greenshift | i << blueshift;
>  }

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds