[Linux-fbdev-devel] ILI9320: Ensure resource cleanup on exit.

[Ben D. <ben...@fl...>]

Ensure we free our 'struct ili9320' on exit or error.

Signed-off-by: Ben Dooks <ben...@fl...>

Index: linux-2.6.26-rc7-quilt1/drivers/video/backlight/ili9320.c
===================================================================
--- linux-2.6.26-rc7-quilt1.orig/drivers/video/backlight/ili9320.c	2008-06-24 12:58:38.000000000 +0100
+++ linux-2.6.26-rc7-quilt1/drivers/video/backlight/ili9320.c	2008-06-24 14:33:30.000000000 +0100
@@ -259,18 +259,19 @@ int __devinit ili9320_probe_spi(struct s
 	lcd_device_unregister(lcd);
 
  err_free:
-	kfree(lcd);
+	kfree(ili);
+
 	return ret;
 }
 
 EXPORT_SYMBOL_GPL(ili9320_probe_spi);
 
-int __devexit ili9320_remove(struct ili9320 *lcd)
+int __devexit ili9320_remove(struct ili9320 *ili)
 {
-	ili9320_power(lcd, FB_BLANK_POWERDOWN);
+	ili9320_power(ili, FB_BLANK_POWERDOWN);
 
-	lcd_device_unregister(lcd->lcd);
-	kfree(lcd);
+	lcd_device_unregister(ili->lcd);
+	kfree(ili);
 
 	return 0;
 }

-- 
Ben (be...@fl..., http://www.fluff.org/)

  'a smiley only costs 4 bytes'