Re: [Linux-fbdev-devel] [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb v4

[Andrew M. <ak...@li...>]

On Fri, 29 Feb 2008 22:41:37 -0500 Jaya Kumar <jay...@gm...> wrote:

> Hi Andrew, fbdev,
> 
> Appended is version 4 of the metronomefb code. 
> 
> The fixes are for the issues you pointed out. These are:
> 
> - fixed and cleaned up metronomefb_write
> - use wait_event_timeout for uninterruptible wait in *_cmd() used in probe()
> - use msleep in disable_controller
> - use get_unaligned to handle unaligned access
> - make load_waveform static and some cleanup
> 
> I did not change the handling of display_cmd because I think that using
> interruptible wait there is not a problem. In the case of the defio
> page->mapping, I could not find an issue and I have left it unchanged because
> it seems to work in testing.
> 
> I welcome your feedback.

Well... assuming you've addressed everything I raised to your satisfaction,
I won't be reading it again.

I now do not have a usable changelog for this patch.  Please send one, and
please do always send the full changelog (possibly updated) with each iteration
of a patch, thanks.